New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 654072 link

Starred by 4 users
Status: Fixed
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Oct 2016
Cc:
tommycli@chromium.org
█ ericde@chromium.org
█ raymes@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
█ mummare...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

HBD - DefaultPluginsSetting (3) getting treated like BLOCK, settings says ASK

Project Member Reported by lafo...@chromium.org, Oct 7 2016 
Version: 55.0.2883.0
OS: Windows 7 + OSX 10.11.6

What steps will reproduce the problem?
(1) Visit http://www.adobe.com/software/flash/about/
(2) Either set SE sufficiently high, or accept to run Flash content on the site

What is the expected output?
Flash content runs.

What do you see instead?
Plugin placeholder remains in place, w/ no means of running the content.
Enterprise Setting 3 - Says ASK acting like BLOCK.png
115 KB View Download
Enterprise Setting 3 - About Flash Blocked - Adobe.com Setting.png
139 KB View Download
Enterprise Setting 3 - About Flash Blocked.png
402 KB View Download

Comment 1 by gov...@chromium.org, Oct 7 2016 

Please try to resolve this ASAP and request a merge to M55 once fix is landed as this is blocking block next Tuesday's Dev release.

Comment 2 by gov...@chromium.org, Oct 7 2016

Cc: pbomm...@chromium.org mummare...@chromium.org

Comment 3 by lafo...@chromium.org, Oct 7 2016

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
This will primarily affect Googlers (i.e. folks under Enterprise policy), who admittedly aren't bulk of our population are an important constituency.  

Given the timing, this likely won't block the initial Dev release, which is getting qualified this Sunday, however we should try and have it resolved before EOD Wed to get into the second Dev release.

Comment 4 by ericde@google.com, Oct 8 2016

Cc: raymes@chromium.org
Components: Internals>Plugins>Flash>PreferHTML5
+raymes for feedback on short term & long term options. 

challenge we have is that when DefaultPluginPolicy is set to ASK, it does not allow locally added overrides (see strikethrough adobe.com setting image above). So you click ALLOW to enable it, page refreshes, and it's back to ASK (not allowed). 

a SHORT TERM fix here would be if DefaultPluginPolicy is set to 3, we go back to C2P (disable HBD) for plugins in M55, and pursue a longer-term solution for M56.

LONG TERM SOLUTION : see discussion in crbug.com/654148

Comment 5 by gov...@chromium.org, Oct 11 2016 

Please make sure this is resolved by 5:00 PM PT Wed (10/12) to get into the second Dev release. Thank you.

Comment 6 by ericde@google.com, Oct 11 2016

Labels: -M-55 M-56
Owner: raymes@chromium.org
over to raymes to finish up. 

reviewed plans w/raymes@ & groby@. Plan is :
-M55 (this bug) : if DefaultPluginSetting is set, do not apply HBD (HBD is turned off).

-M56 (crbug.com/654148) : allow local URL overrides just for Flash/Plugins if Policy is set to 3/ASK, and re-enable HBD when policy is set.

Comment 7 by ericde@google.com, Oct 11 2016

Labels: -M-56 M-55
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b512db8bfb5266fb346540e24bca1416eb9260a7

commit b512db8bfb5266fb346540e24bca1416eb9260a7
Author: raymes <raymes@chromium.org>
Date: Tue Oct 11 23:07:27 2016

Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugins

This replaces occurences of base::FeatureList::IsEnabled(features::kPreferHtmlOverPlugins)
with PluginUtils::ShouldPreferHtmlOverPlugins which includes extra checks to
determine whether the feature should be enabled. PreferHtmlOverPlugins should
not be enabled if an enterprise setting is set because it currently doesn't
work correctly when the enterprise setting is set to ASK. The Profile has been
plumbed through to places where it's needed in order to make checking this
possible.

BUG= 654072 

Review-Url: https://codereview.chromium.org/2408613002
Cr-Commit-Position: refs/heads/master@{#424583}

[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/chrome_plugin_service_filter.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/flash_download_interception.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/flash_permission_context.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/plugin_info_message_filter.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/plugin_utils.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/plugin_utils.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/plugins_field_trial.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/plugins/plugins_field_trial.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/views/website_settings/permission_prompt_impl.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/views/website_settings/permission_selector_row.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/views/website_settings/permission_selector_row.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/website_settings/permission_menu_model.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/website_settings/permission_menu_model.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/website_settings/website_settings_ui.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/website_settings/website_settings_ui.h
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/b512db8bfb5266fb346540e24bca1416eb9260a7/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 9 by lafo...@chromium.org, Oct 12 2016

Labels: Merge-Request-55

Comment 10 by gov...@chromium.org, Oct 12 2016

Labels: -Merge-Request-55 Merge-Approved-55
Approving merge to M55 branch 2883. Please merge ASAP. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 12 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9007bb1014ecfd5702041f3183397758edc9ed7b

commit 9007bb1014ecfd5702041f3183397758edc9ed7b
Author: Raymes Khoury <raymes@chromium.org>
Date: Wed Oct 12 23:04:12 2016

Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugins

This replaces occurences of base::FeatureList::IsEnabled(features::kPreferHtmlOverPlugins)
with PluginUtils::ShouldPreferHtmlOverPlugins which includes extra checks to
determine whether the feature should be enabled. PreferHtmlOverPlugins should
not be enabled if an enterprise setting is set because it currently doesn't
work correctly when the enterprise setting is set to ASK. The Profile has been
plumbed through to places where it's needed in order to make checking this
possible.

BUG= 654072 

Review-Url: https://codereview.chromium.org/2408613002
Cr-Commit-Position: refs/heads/master@{#424583}
(cherry picked from commit b512db8bfb5266fb346540e24bca1416eb9260a7)

Review URL: https://codereview.chromium.org/2415773002 .

Cr-Commit-Position: refs/branch-heads/2883@{#76}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/chrome_plugin_service_filter.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/flash_download_interception.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/flash_permission_context.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugin_info_message_filter.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugin_utils.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugin_utils.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugins_field_trial.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugins_field_trial.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_prompt_impl.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_selector_row.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/permission_menu_model.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/permission_menu_model.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/website_settings_ui.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/website_settings_ui.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 12 by rbasuvula@chromium.org, Oct 13 2016

Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
Tested in reported chrome version #55.0.2883.0 & Flash #23.0.0.185 on win 10.0 & MAC 14.04 an not able to reproduce the issue.Please find the screen cast for you reference.
Observations:
1.Not able to find the "Ask first Before allowing sites to run flash(recommended)" option in above mentioned version(#55.0.2883.0).
2.Able to see the "Flash content runs" in given URL (Flash #23.0.0.185).
3.Not able to find the Blocked content in Flash Exception

@laforge:

Could you please let me know if i have missed anything to reproduce the issue from my end.

Thanks in Advance.
654072.mp4
2.4 MB View Download

Comment 13 by rbasuvula@chromium.org, Oct 13 2016 

Additional info : We tested the same on non corp machines as well but still couldn't reproduce the issue on reported version(#55.0.2883.0).

Thank you.

Comment 14 Deleted

Comment 15 by pbomm...@chromium.org, Oct 13 2016 

I have deleted my previous comment since the comment was not actual verification and misleading. Please find the correct verification below :

Verified on Chrome version 55.0.2883.11 on Windows 10(non corp machine), Mac(non corp machine) machine were Enterprise policy wasn't set.

Steps followed :
1. Install and launch Chrome version 55.0.2883.11
2. Enable the flag "Prefer HTML over Flash" from about://flags and relaunch
3. navigate to Chrome://settings --> Advanced settings --> Content settings --> Flash and make sure we see the option "Ask first Before allowing sites to run flash(recommended)"
4. Visit http://www.adobe.com/software/flash/about/ 
5. Click on the place holder and should see a bubble from Right side of the Omni box like "Run Flash block and Allow"
6. Select Allow 

Observed behavior :
Paged refreshed and flash content started playing. 


Note : If you are on Corp machine you wouldn't see the option ""Ask first Before allowing sites to run flash(recommended)" even after enabling the Flag from about flags.

Comment 16 by gov...@chromium.org, Oct 13 2016 

raymes@, can this be marked as fixed now?

Comment 17 by raymes@chromium.org, Oct 13 2016

Status: Fixed (was: Assigned)
I think so. Just to verify: on corp machines, the "Run Flash" prompt should never be shown. Instead a placeholder is shown which can be right-clicked on to run. Is that accurate?

Comment 18 by pbomm...@chromium.org, Oct 13 2016 

Yes that's the behavior what I saw on Corp machines.
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9007bb1014ecfd5702041f3183397758edc9ed7b

commit 9007bb1014ecfd5702041f3183397758edc9ed7b
Author: Raymes Khoury <raymes@chromium.org>
Date: Wed Oct 12 23:04:12 2016

Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugins

This replaces occurences of base::FeatureList::IsEnabled(features::kPreferHtmlOverPlugins)
with PluginUtils::ShouldPreferHtmlOverPlugins which includes extra checks to
determine whether the feature should be enabled. PreferHtmlOverPlugins should
not be enabled if an enterprise setting is set because it currently doesn't
work correctly when the enterprise setting is set to ASK. The Profile has been
plumbed through to places where it's needed in order to make checking this
possible.

BUG= 654072 

Review-Url: https://codereview.chromium.org/2408613002
Cr-Commit-Position: refs/heads/master@{#424583}
(cherry picked from commit b512db8bfb5266fb346540e24bca1416eb9260a7)

Review URL: https://codereview.chromium.org/2415773002 .

Cr-Commit-Position: refs/branch-heads/2883@{#76}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/chrome_plugin_service_filter.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/flash_download_interception.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/flash_permission_context.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugin_info_message_filter.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugin_utils.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugin_utils.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugins_field_trial.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/plugins/plugins_field_trial.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_prompt_impl.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_selector_row.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/permission_selector_row.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/permission_menu_model.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/permission_menu_model.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/website_settings_ui.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/website_settings/website_settings_ui.h
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/9007bb1014ecfd5702041f3183397758edc9ed7b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 20 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 21 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment