New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654067 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Overview shouldn't alter window state

Project Member Reported by lpique@chromium.org, Oct 7 2016

Issue description

Most android applications (running via ARC on a Chromebook) were designed for a single task/screen, and carry over some legacy limitations because of that. One of them is that they did not need to render output unless they were the active app -- if they were paused/in the background, they were generally not visible.

With Nougat, this will slowly change, as well-written apps will render content even when paused, but there are many older apps.

The problem with the Overview is that it is will restore a minimized window to make it visible in the overview UI. The problem is that for many Android apps this window will be blank since the window isn't activated (which unpauses it under ARC), and was previously hidden.

To support having content for minimized windows, ARC takes a snapshot of the window contents before the app is hidden, and associates that with the Chrome window. But unfortunately restoring the window also destroys this snapshot.

We tried a workaround by not actually telling the Android app it had been restored from a minimized state unless it was also activated, and while that worked (displayed the snapshot in the overview), it led to further issues since the window state was inconsistent.

Recent work with Alt-TAB involved mirroring window content, and doing something similar to support overview mode would seem to be the way to go.
 
Labels: OS-Chrome
Cc: -osh...@chromium.org
Owner: osh...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by osh...@chromium.org, Oct 28 2016

Cc: varkha@chromium.org est...@chromium.org
Status: Started (was: Assigned)
Another issue is that activating window also changes the state of the page. For example, this page http://daniemon.com/tech/webapps/page-visibility/ should pause playing when minimized, but activating overview starts video playback.


Comment 4 by osh...@chromium.org, Nov 10 2016

Cc: kuscher@chromium.org tbuck...@chromium.org
I discussed with tbuckley@ and kuscher@ and both agreed that overview mode/alt-tab should not change the page visibility, at least for now. We will revisit it if we get request/feedback to change this behavior. One option we discussed was that to update the visibility when the window is selected. This way, entering overview/alt-tab will not resume all of them.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d6f138d9c18c3c8843cddf43f06d4c0b484578

commit 49d6f138d9c18c3c8843cddf43f06d4c0b484578
Author: oshima <oshima@chromium.org>
Date: Wed Nov 16 17:27:13 2016

Use mirror layer for minimized windows in overview mode

* This CL changes overview mode to use the mirror layer for minimized windows (normal minimized, docked minimized).
* The mirror window already excludes header, so do not adjust the top insets.
* Reposition windows when a window gets minimized/unminimized.

BUG= 654067 
TEST=covered by unit tests.

Review-Url: https://codereview.chromium.org/2470343003
Cr-Commit-Position: refs/heads/master@{#432537}

[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/window_grid.h
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/49d6f138d9c18c3c8843cddf43f06d4c0b484578/ash/wm/window_mirror_view.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment