New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654061 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 641191
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Many "Loading content for a profile without session restore?" warnings at login

Project Member Reported by derat@chromium.org, Oct 7 2016

Issue description

I see a bunch of "Loading content for a profile without session restore?" warnings in the Chrome user log when I boot a ToT cyan device:

[start of log]
[17067:17067:1007/141911:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::WifiEnabledStateChanged not available.
[17067:17067:1007/141911:VERBOSE1:input_events_blocker.cc(15)] InputEventsBlocker 0x23bb1468ecc0 created.
[17067:17067:1007/141911:VERBOSE1:user_session_manager.cc(663)] RespectLocalePreference: app_locale='en-US', bkup_locale='en-US', account_locale - unused.  Selected 'en-US'
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:ERROR:component_loader.cc(154)] Failed to parse extension manifest.
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:WARNING:merge_session_throttling_utils.cc(138)] Loading content for a profile without session restore?
[17067:17067:1007/141911:VERBOSE1:user_image_manager_impl.cc(876)] Profile image initialized from disk.
[17067:17067:1007/141911:VERBOSE1:input_events_blocker.cc(20)] InputEventsBlocker 0x23bb1468ecc0 destroyed.
[17067:17067:1007/141911:VERBOSE1:oauth2_login_manager.cc(106)] Loading OAuth2 refresh token from database.

---

Here's the relevant code from chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc:

bool ShouldDelayRequestForProfile(Profile* profile) {
...
  switch (login_manager->state()) {
    case chromeos::OAuth2LoginManager::SESSION_RESTORE_NOT_STARTED:
      // The session restore for this profile hasn't even started yet. Don't
      // block for now.
      // In theory this should not happen since we should
      // kick off the session restore process for the newly added profile
      // before we attempt loading any page.
      if (user_manager::UserManager::Get()->IsLoggedInAsUserWithGaiaAccount() &&
          !user_manager::UserManager::Get()->IsLoggedInAsStub()) {
        LOG(WARNING) << "Loading content for a profile without "
                     << "session restore?";
      }
      return false;

---

I didn't have any previously-opened pages that got restored automatically, so this seems pretty weird.

Zel, it looks like you added this warning in https://chromiumcodereview.appspot.com/23678007 (with Scott and Xiyuan reviewing). Does it indicate a real problem? Have the assumptions about when this function is called changed?
 
Cc: -xiy...@chromium.org zelidrag@chromium.org
Owner: xiy...@chromium.org
hmm, it looks like merge session is not kicked off at all - is your browser restarting after crash or something like that?

Comment 2 by derat@chromium.org, Oct 7 2016

Nope, just a regular login after a clean logout. Seems to happen every time, and there are no tabs being restored.
then something regressed there recently - is this on TOT?
Labels: -Pri-2 Pri-1
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
alemate@ can you take a closer look at this?  For some reason session restore is getting skipped.

Comment 5 by derat@chromium.org, Oct 7 2016

Yep, ToT (56.0.2884.0).

Comment 6 by xiy...@chromium.org, Oct 10 2016

Cc: achuith@chromium.org
Dup of  issue 641191 .

I was not able to repro myself when I was looking at it. But it does seems to happen a lot in many feedback logs.

It should not be from session restore, i.e. browser tabs during start up. If we could repro it, maybe dump out the URLs would give us some clue.

Comment 7 by derat@chromium.org, Oct 10 2016

Mergedinto: 641191
Status: Duplicate (was: Assigned)

Sign in to add a comment