New issue
Advanced search Search tips

Issue 654056 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 471333



Sign in to add a comment

TransformPaintPropertyNode should flatten in more cases

Project Member Reported by pdr@chromium.org, Oct 7 2016

Issue description

Via Ali, we need to set the flattening bit on more cases in spv2:
------------------------------
cc's PropertyTreeBuilder currently infers that every render surface flattens, so sets flattening bits in the transform tree accordingly. Even after surface knowledge is removed from the transform tree, we'll still need flattening to be correctly represented there (in order to compute correct screen-space transforms).

It looks like blink::PaintPropertyTreeBuilder uses ComputedStyle::preserve3D to set flattening bits (just like CompositedLayerMapping does), but this doesn't currently cover all the things that can cause render surfaces to be created. Looking at the definition of ComputedStyle::usedTransformStyle3D, the flattening reasons that are handled are overflow clipping, filters, reflections, and non-1 opacity. But css clips (these create render surfaces when they’re not axis-aligned wrt the current target), masks, mix-blend-mode, and roots of isolated groups (that is, PaintLayer::shouldIsolateCompositedDescendants) aren't considered.
------------------------------
 
Blocking: 471333
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 9 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold PaintTeamTriaged-20171010 BugSource-Team
Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -trchen@chromium.org
Status: Available (was: Untriaged)

Comment 6 by chrishtr@chromium.org, Yesterday (33 hours ago)

Status: Assigned (was: Available)
-> pdr to verify fixed by BGPT and mark as such.

Comment 7 by chrishtr@chromium.org, Yesterday (33 hours ago)

Owner: pdr@chromium.org

Sign in to add a comment