New issue
Advanced search Search tips

Issue 654053 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

rebaseline-cl triggers try jobs for current issue even when --issue is passed.

Project Member Reported by qyears...@chromium.org, Oct 7 2016

Issue description

The webkit-patch rebaseline-cl triggers try jobs if there are no try job results ready. One current bug in how this is done currently is that since git cl try is called to start the try jobs, and this doesn't support specifying a particular CL number, 

To reproduce:
 1. First, have two different branches with two different CLs.
 2. On the branch for the first issue call `webkit-patch rebaseline-cl --issue <second issue number>`.
 3. Observe that try jobs are started for the first issue.


Other notes:
 - Another bug with rebaseline-cl's starting of try jobs is that if jobs are already started but not finished, more jobs are started.
 - In my opinion, having to start and wait for try jobs is still the most annoying part of rebaselining from try jobs. Still might want to consider (a) starting try jobs automatically for all changes that affect layout tests using a post-upload hook, (b) making a separate command to trigger try jobs, which explicitly only starts jobs for the current CL, not any given CL.
 
Status: WontFix (was: Available)
No longer applicable since now rebaseline-cl only supports rebaselining local issues.

Sign in to add a comment