New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654046 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 615535



Sign in to add a comment

[MD Feedback] Dialog shows "Unknown" in desktop taskbar.

Project Member Reported by apaci...@chromium.org, Oct 7 2016

Issue description

Can't take a screenshot of that area, but the dialog appears as "Unknown" (current: "Feedback") since there is no dialog title set.
 
Blocking: 615535
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baf0f65bc3c4abbf7c75a1f1626de7013c57d2dc

commit baf0f65bc3c4abbf7c75a1f1626de7013c57d2dc
Author: apacible <apacible@chromium.org>
Date: Fri Oct 14 16:27:58 2016

[MD Feedback] Add dialog title.

This replaces the "Unknown" title that appears in desktop nav with "Feedback".

BUG= 654046 

Review-Url: https://codereview.chromium.org/2400043002
Cr-Commit-Position: refs/heads/master@{#425349}

[modify] https://crrev.com/baf0f65bc3c4abbf7c75a1f1626de7013c57d2dc/chrome/app/generated_resources.grd
[modify] https://crrev.com/baf0f65bc3c4abbf7c75a1f1626de7013c57d2dc/chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment