NOTREACHED() reached in IsPersistentSessionType() |
||
Issue descriptionVersion: 55.0.2881.0 (Developer Build) unknown (64-bit) When running https://w3c-test.org/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events.html, I hit the NOTREACHED in IsPersistentSessionType(). Probably, the Unknown case is being hit. We probably shouldn't get to checking if a type is persistent for a session type we don't support. [1:1:1007/133042:FATAL:key_system_config_selector.cc(145)] Check failed: false. #0 0x7ff6216ccb1e base::debug::StackTrace::StackTrace() #1 0x7ff62173a95f logging::LogMessage::~LogMessage() #2 0x7ff60d691e60 media::(anonymous namespace)::IsPersistentSessionType() #3 0x7ff60d690be7 media::KeySystemConfigSelector::GetSupportedConfiguration() #4 0x7ff60d69251a media::KeySystemConfigSelector::SelectConfigInternal() #5 0x7ff60d6922b9 media::KeySystemConfigSelector::SelectConfig() #6 0x7ff60d6f0a49 media::WebEncryptedMediaClientImpl::requestMediaKeySystemAccess() #7 0x7ff6074d711f blink::NavigatorRequestMediaKeySystemAccess::requestMediaKeySystemAccess() #8 0x7ff60733541c blink::NavigatorPartialV8Internal::requestMediaKeySystemAccessMethod() #9 0x7ff6073343d5 blink::NavigatorPartialV8Internal::requestMediaKeySystemAccessMethodCallback() #10 0x7ff616ecdacd v8::internal::FunctionCallbackArguments::Call() #11 0x7ff616f86dd4 v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #12 0x7ff616f85bc8 v8::internal::Builtin_Impl_HandleApiCall() #13 0x7ff616f857b1 v8::internal::Builtin_HandleApiCall() #14 0x11dd5f4843a7 <unknown>
,
Oct 12 2016
Right, but we shouldn't hit this regardless of what the string is. A simple test, which we should add, is "foo".
,
Oct 18 2016
Fixed by https://codereview.chromium.org/2414983002. commit e150afdd8808dad8c4298d2003c8f946b959d962 EME: Fail if unsupported sessionTypes are provided BUG= 654040 TEST=modified EME layout test passes Cr-Commit-Position: refs/heads/master@{#425144} |
||
►
Sign in to add a comment |
||
Comment 1 by jrumm...@chromium.org
, Oct 12 2016