ARC log spam during login |
|||||||||
Issue descriptionIn a ToT build, there's a bunch of ARC spam in the Chrome user log: 7821:7821:1007/132634:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::WifiEnabledStateChanged not available. ... [7821:7821:1007/132634:VERBOSE1:arc_bridge_service_impl.cc(51)] Session started [7821:7821:1007/132634:VERBOSE1:arc_bridge_service_impl.cc(78)] Prerequisites changed. state=0, session_started=1 [7821:7821:1007/132634:INFO:arc_bridge_service_impl.cc(84)] Prerequisites met, starting ARC ... [7821:7821:1007/132635:VERBOSE1:arc_net_host_impl.cc(629)] New default network: /service/1 ... [7821:7821:1007/132635:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::WifiEnabledStateChanged not available. ... [7821:7821:1007/132635:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::DefaultNetworkChanged not available. ... [7821:7821:1007/132635:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132636:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::WifiEnabledStateChanged not available. ... [7821:7821:1007/132636:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::WifiEnabledStateChanged not available. ... [7821:7821:1007/132636:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132637:INFO:arc_bridge_service_impl.cc(130)] ARC ready [7821:7821:1007/132637:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132638:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132638:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::WifiEnabledStateChanged not available. [7821:7821:1007/132638:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::NetInstance::ScanCompleted not available. [7821:7821:1007/132639:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132640:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132641:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132642:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. [7821:7821:1007/132643:VERBOSE1:arc_net_host_impl.cc(597)] GetDefaultNetwork: default network is /service/1 [7821:7821:1007/132643:VERBOSE1:instance_holder.h(52)] Instance for arc::mojom::ProcessInstance::RequestProcessList not available. The messages like "Session started", "ARC ready", and so on seem useful and not too noisy, but the "not available" ones maybe not so much. Is it fine to remove that VLOG(1) from instance_holder.h? As an aside, is there a notification or observer interface or something that whoever's calling this can use to be notified when ARC and/or various mojo services are ready? It looks like some code is polling right now (see once-a-second RequestProcessList messages), which both wastes CPU time during login and means that we don't actually start using the service as quickly as we could once it's finally ready.
,
Nov 30 2016
,
Nov 30 2016
https://codereview.chromium.org/2541843003/ should fix it
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edea73c00927636fe885af9205c668633e65a691 commit edea73c00927636fe885af9205c668633e65a691 Author: lhchavez <lhchavez@chromium.org> Date: Thu Dec 01 02:45:12 2016 arc: Reduce logspam when ARC is not enabled/available There are some Chrome services that unconditionally try to call ARC code, and the latter will print stuff to the log if it's not enabled or avilable (yet). This change ensures that we only attempt to contact ARC when it is actually ready for the most chatty services: net and process. BUG= 654038 TEST=Opted out of ARC, did not see any logs Review-Url: https://codereview.chromium.org/2541843003 Cr-Commit-Position: refs/heads/master@{#435534} [modify] https://crrev.com/edea73c00927636fe885af9205c668633e65a691/chrome/browser/chromeos/arc/process/arc_process_service.cc [modify] https://crrev.com/edea73c00927636fe885af9205c668633e65a691/chrome/browser/chromeos/arc/process/arc_process_service.h [modify] https://crrev.com/edea73c00927636fe885af9205c668633e65a691/components/arc/net/arc_net_host_impl.cc [modify] https://crrev.com/edea73c00927636fe885af9205c668633e65a691/components/arc/net/arc_net_host_impl.h
,
Dec 1 2016
,
Dec 2 2016
,
Dec 2 2016
It would be very nice to get this onto R55 to make it easier to debug any issues on the forth-coming Stable channel release.
,
Dec 2 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Dec 2 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 5 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5 2016
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26ed24fd38f8c2b64ced3d3bb61ac04686d698ba commit 26ed24fd38f8c2b64ced3d3bb61ac04686d698ba Author: Luis Hector Chavez <lhchavez@google.com> Date: Mon Dec 05 17:21:49 2016 [Merge M-56] arc: Reduce logspam when ARC is not enabled/available There are some Chrome services that unconditionally try to call ARC code, and the latter will print stuff to the log if it's not enabled or avilable (yet). This change ensures that we only attempt to contact ARC when it is actually ready for the most chatty services: net and process. BUG= 654038 TEST=Opted out of ARC, did not see any logs TBR=yusukes@chromium.org Review-Url: https://codereview.chromium.org/2541843003 Cr-Commit-Position: refs/heads/master@{#435534} (cherry picked from commit edea73c00927636fe885af9205c668633e65a691) Review URL: https://codereview.chromium.org/2553713002 . Cr-Commit-Position: refs/branch-heads/2924@{#334} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/26ed24fd38f8c2b64ced3d3bb61ac04686d698ba/chrome/browser/chromeos/arc/process/arc_process_service.cc [modify] https://crrev.com/26ed24fd38f8c2b64ced3d3bb61ac04686d698ba/chrome/browser/chromeos/arc/process/arc_process_service.h [modify] https://crrev.com/26ed24fd38f8c2b64ced3d3bb61ac04686d698ba/components/arc/net/arc_net_host_impl.cc [modify] https://crrev.com/26ed24fd38f8c2b64ced3d3bb61ac04686d698ba/components/arc/net/arc_net_host_impl.h
,
Dec 9 2016
Please merge to M55 as per the merge request.
,
Dec 13 2016
M-55 is already on Stable so in general we should target this of M56 How risky is this change?
,
Mar 1 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by djkurtz@chromium.org
, Nov 12 2016Labels: -Pri-3 M-55 Pri-1