New issue
Advanced search Search tips

Issue 654015 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony - Button, textfield, dropdown strokes are too light

Project Member Reported by shrike@chromium.org, Oct 7 2016 
Version: 55.0.2883.0
OS: 10.11

This is with the cl from  Issue 647047  applied (Canary change log shows that it's in 2883). The code seems like it should be correct. although it's taking an alpha of the "text color", which should be black be who knows - that might be a good first place to investigate.

Attached is a screenshot showing bookmark dialog controls. Next to the Remove button I've placed a swatch that is #000 0.2a. Photoshop says the swatch is 204 (correct: 20% black is 80% white, and .8 * 255 = 204). Photoshop says the button stroke is 222, so too light.

Even better, Photoshop says the textfield stroke is 219, so it's not using the same color.
BookmarksDialogControls.png
4.9 KB View Download

Comment 1 by shrike@chromium.org, Oct 7 2016 

printf-ing the text color for buttons I see that it's ff5a5a5a, not ff000000, so that's the problem there. I guess this was not actually checked before committing.

For textfields it looks like the text color is black (at least according to Photoshop).

Button stroke is still not right, so can't get screenshots or even settle on a final stroke color. I guess I"m saying this is high priority to get fixed.

Comment 2 by shrike@chromium.org, Oct 10 2016 

According to the Harmony spec, button text color is #5a5a5a, not #000000. Will confirm with bettes@ tomorrow that that's correct.

Comment 3 by shrike@chromium.org, Oct 11 2016

Summary: Harmony - Button, textfield, dropdown strokes are too light (was: Harmony - button, textfield strokes are too light)
Dropdown stroke is also too light (56.0.2887.0 Canary).

Comment 4 by shrike@chromium.org, Oct 11 2016 

Spoke with bettes@ - button text color should be #5a5a5a, so button stroke color will need to be separate.

Dropdown button text color should be #000000, which I think it is already.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcfe5a45b59aeb5ccc16a74fc5312aa7a95ac74e

commit dcfe5a45b59aeb5ccc16a74fc5312aa7a95ac74e
Author: ellyjones <ellyjones@chromium.org>
Date: Wed Oct 12 18:45:07 2016

views: use darker stroke for non-prominent buttons

This change:
1) Introduces kColorId_{Non,}ProminentButtonBorderColor
2) Uses it for the stroke instead of an alpha blend of the text color
   in MdTextButton

BUG= 654015 

Review-Url: https://codereview.chromium.org/2409563002
Cr-Commit-Position: refs/heads/master@{#424805}

[modify] https://crrev.com/dcfe5a45b59aeb5ccc16a74fc5312aa7a95ac74e/ui/views/controls/button/md_text_button.cc

Comment 6 by ellyjo...@chromium.org, Oct 12 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2410303005/
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f12067efafa551f96cb9c9f93e0ffb06ca6b96d

commit 9f12067efafa551f96cb9c9f93e0ffb06ca6b96d
Author: ellyjones <ellyjones@chromium.org>
Date: Wed Oct 12 20:06:57 2016

views: change Harmony unfocused border color to 000 @ 0.2a

BUG= 654015 

Review-Url: https://codereview.chromium.org/2410303005
Cr-Commit-Position: refs/heads/master@{#424833}

[modify] https://crrev.com/9f12067efafa551f96cb9c9f93e0ffb06ca6b96d/ui/native_theme/common_theme.cc

Comment 8 by ellyjo...@chromium.org, Oct 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment