New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 654014 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Next button on the add account screen has changed from button to a link

Project Member Reported by cma...@chromium.org, Oct 7 2016

Issue description

Hello Benoit,

We noticed during Franky runs that the type of the Next button on the Add Account screen (https://drive.google.com/a/google.com/file/d/0B4w0bgEXN_fIbkVuaWRSc2dnZFk/view?usp=sharing) has changed from UIAButton to UIALink. Is this intentional? Can we help us understand the change?


 
Components: -UI>Settings Services>SignIn
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7b836835bab7240c010dff2e0f8acbff6fa7a49f

commit 7b836835bab7240c010dff2e0f8acbff6fa7a49f
Author: cmasso <cmasso@google.com>
Date: Fri Oct 07 20:06:55 2016

I'll ask the SSOAuth team whether this was intentional. Please keep in mind that this is a server-side change, so they might not know the answer directly.

My guess is that it was an intentional change by the GAIA team, and I don't think there is anything to understand for us. They are not notifying all their clients of every small changes, and they probably don't expect that to break anybody.

BTW, why are we relying on the fact it is a button? AFAICT the link provides the same functionalities as the button, so we shouldn't even be bothered by that change.


Comment 4 by cma...@chromium.org, Oct 17 2016

Status: WontFix (was: Assigned)
Alright, Thanks Benoit.
And here is the answer from the AppleJuice teams: "yes, we changed it to a link when it causes a navigation. This is a more accurate role for the button in this case."

Comment 6 by cma...@chromium.org, Oct 17 2016

Makes sense. Thanks Benoit!

Sign in to add a comment