New issue
Advanced search Search tips

Issue 653970 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Fix and reenable blink_perf.bindings referejce on Android Nexus6 Perf (3)

Project Member Reported by eyaich@chromium.org, Oct 7 2016

Issue description

Link to failing build:

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus6%20Perf%20%283%29/builds/3681

log: 
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus6%20Perf%20%283%29/builds/3681/steps/blink_perf.bindings.reference/logs/stdio


INFO:root:*************** BROWSER STANDARD OUTPUT ***************
INFO:root:Cannot get standard output on Android
INFO:root:*********** END OF BROWSER STANDARD OUTPUT ************
INFO:root:********************* BROWSER LOG *********************
INFO:root:No log file
INFO:root:***************** END OF BROWSER LOG ******************
INFO:devil.utils.cmd_helper:[host]> /b/rr/tmpJP4amE/w/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s ZX1G22X9CZ shell '( /system/bin/screencap -p /data/local/tmp/temp_file-4607038e0eab3.png );echo %$?'
INFO:devil.utils.cmd_helper:[host]> /b/rr/tmpJP4amE/w/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s ZX1G22X9CZ pull /data/local/tmp/temp_file-4607038e0eab3.png /tmp/tmp_mW8T8.png
INFO:devil.utils.cmd_helper:[host]> /b/rr/tmpJP4amE/w/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s ZX1G22X9CZ shell 'rm -f /data/local/tmp/temp_file-4607038e0eab3.png'
Traceback (most recent call last):
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 86, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 312, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpJP4amE/w/src/tools/perf/benchmarks/blink_perf.py", line 100, in ValidateAndMeasurePage
    tab.WaitForJavaScriptExpression('testRunner.isDone', 600)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 123, in WaitForJavaScriptExpression
    util.WaitFor(IsJavaScriptExpressionTrue, timeout)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/core/util.py", line 86, in WaitFor
    res = condition()
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 116, in IsJavaScriptExpressionTrue
    return bool(self.EvaluateJavaScript(expr))
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 187, in EvaluateJavaScript
    expr, context_id=None, timeout=timeout)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScriptInContext
    expr, context_id=context_id, timeout=timeout)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 34, in inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 208, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, context_id, timeout)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 45, in Evaluate
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 110, in SyncRequest
    res = self._Receive(timeout)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 166, in _Receive
    self._HandleNotification(result)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 179, in _HandleNotification
    self._domain_handlers[domain_name](result)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpJP4amE/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 362, in _HandleInspectorDomainNotification
    raise exception
DevtoolsTargetCrashException: Devtools target crashed



If the test is disabled, please downgrade to Pri-2.

 
Cc: haraken@chromium.org
Owner: yukishiino@chromium.org
blink_perf.bindings are important. This needs to be fixed.

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4179eacab39055ecf9d27a39a4fe97aac2c8ffdf

commit 4179eacab39055ecf9d27a39a4fe97aac2c8ffdf
Author: eyaich <eyaich@chromium.org>
Date: Sat Oct 08 04:31:15 2016

Disabling blink_perf.bindings on android reference

BUG= chromium:653970 

Review-Url: https://codereview.chromium.org/2403513002
Cr-Commit-Position: refs/heads/master@{#424066}

[modify] https://crrev.com/4179eacab39055ecf9d27a39a4fe97aac2c8ffdf/tools/perf/benchmarks/blink_perf.py

Comment 3 by zh...@chromium.org, Oct 8 2016

Labels: -Pri-1 Pri-2
Status: Assigned (was: Untriaged)
Summary: Fix and reenable blink_perf.bindings referejce on Android Nexus6 Perf (3) (was: blink_perf.bindings referejce failure on chromium.perf on Android Nexus6 Perf (3))
Components: Blink>Bindings
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39cbe807824bdd083a40d66a9958b1fdfb5a8af8

commit 39cbe807824bdd083a40d66a9958b1fdfb5a8af8
Author: nednguyen <nednguyen@google.com>
Date: Tue May 09 07:46:00 2017

Remove disabling reference logic for blink_perf benchmarks

BUG= 707237 ,  653970 , 576779
TBR=charliea@chromium.org

Review-Url: https://codereview.chromium.org/2864893002
Cr-Commit-Position: refs/heads/master@{#470263}

[modify] https://crrev.com/39cbe807824bdd083a40d66a9958b1fdfb5a8af8/tools/perf/benchmarks/blink_perf.py

Owner: nedngu...@google.com
Status: Fixed (was: Assigned)
Seems that nednguyen@ fixed this issue.

Sign in to add a comment