Feedback App: Slow Sys Info Page |
||||||||||||||
Issue descriptionWe have several issues and bottle necks, which became much more pronounced after the logs got much bigger in the post-ARC++ era: - Table rows are created synchronously in one shot when data is received from C++. - Expand/Collapse buttons are always created regardless of the line height of the values and then they all get processed at then end as one shot. - The use of element.scrollHeight is very very slow. - If the user opens the Sys Info page when the data has already been received from C++ side, the slow creation of the table makes it seem that the page is hung as it remains blank for several seconds until all the contents are created and laid out. Note: These issues are specific to the Sys Info page of the Feedback App, and not chrome://system.
,
Oct 7 2016
Yes, I agree. I will see what I can do about this in the process of fixing the other issue 463689.
,
Oct 8 2016
I've just sent a CL for review. The end result will be as attached.
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18870e37b4186d6d68529965cac48023436855ab commit 18870e37b4186d6d68529965cac48023436855ab Author: afakhry <afakhry@chromium.org> Date: Wed Oct 12 20:42:11 2016 Optimize the table creation in the Sys Info page of the feedback app Removes many bottle necks. Adds spinners to clearly show progress to the user. Builds the table incrementally to show incremental progress. BUG= 653968 TEST=manually CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403503003 Cr-Commit-Position: refs/heads/master@{#424842} [modify] https://crrev.com/18870e37b4186d6d68529965cac48023436855ab/chrome/browser/resources/about_sys/about_sys.css [modify] https://crrev.com/18870e37b4186d6d68529965cac48023436855ab/chrome/browser/resources/component_extension_resources.grd [add] https://crrev.com/18870e37b4186d6d68529965cac48023436855ab/chrome/browser/resources/feedback/css/sys_info.css [modify] https://crrev.com/18870e37b4186d6d68529965cac48023436855ab/chrome/browser/resources/feedback/html/sys_info.html [modify] https://crrev.com/18870e37b4186d6d68529965cac48023436855ab/chrome/browser/resources/feedback/js/feedback.js [modify] https://crrev.com/18870e37b4186d6d68529965cac48023436855ab/chrome/browser/resources/feedback/js/sys_info.js
,
Oct 13 2016
abodenha@, do you think it makes sense to merge this change to M55 and M54?
,
Oct 25 2016
Per our conversation in the weekly sync, requesting merge for M55 only.
,
Oct 26 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 26 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc3f19f73e42725b9c46224520854531020e671d commit cc3f19f73e42725b9c46224520854531020e671d Author: Ahmed Fakhry <afakhry@google.com> Date: Wed Oct 26 21:24:40 2016 [Merge to M55] Optimize the table creation in the Sys Info page of the feedback app Removes many bottle necks. Adds spinners to clearly show progress to the user. Builds the table incrementally to show incremental progress. TBR=xiyuan@chromium.org BUG= 653968 TEST=manually CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403503003 Cr-Commit-Position: refs/heads/master@{#424842} (cherry picked from commit 18870e37b4186d6d68529965cac48023436855ab) Review URL: https://codereview.chromium.org/2454843002 . Cr-Commit-Position: refs/branch-heads/2883@{#314} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/about_sys/about_sys.css [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/component_extension_resources.grd [add] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/css/sys_info.css [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/html/sys_info.html [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/js/feedback.js [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/js/sys_info.js
,
Oct 26 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc3f19f73e42725b9c46224520854531020e671d commit cc3f19f73e42725b9c46224520854531020e671d Author: Ahmed Fakhry <afakhry@google.com> Date: Wed Oct 26 21:24:40 2016 [Merge to M55] Optimize the table creation in the Sys Info page of the feedback app Removes many bottle necks. Adds spinners to clearly show progress to the user. Builds the table incrementally to show incremental progress. TBR=xiyuan@chromium.org BUG= 653968 TEST=manually CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403503003 Cr-Commit-Position: refs/heads/master@{#424842} (cherry picked from commit 18870e37b4186d6d68529965cac48023436855ab) Review URL: https://codereview.chromium.org/2454843002 . Cr-Commit-Position: refs/branch-heads/2883@{#314} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/about_sys/about_sys.css [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/component_extension_resources.grd [add] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/css/sys_info.css [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/html/sys_info.html [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/js/feedback.js [modify] https://crrev.com/cc3f19f73e42725b9c46224520854531020e671d/chrome/browser/resources/feedback/js/sys_info.js
,
Oct 27 2016
Verified that the fix works fine on the CrOS Build # 8872.27.0/55.0.2883.29 - Paine, Peppy & Blaze. Slow Sys Info Page opened via Feedback dialog is responding correctly [for scrolling, expanding/collapsing and etc].
,
Oct 27 2016
Verified on Chrome 55.0.2883.29/CrOS 8872.27.0 - Candy, Daisy, reks
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 10 2016
Based on #12 and #13 closing
,
Mar 3 2017
,
Mar 3 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by st...@chromium.org
, Oct 7 2016