Migrate Mac to SessionCrashedBubble and delete old infobar code |
||||||
Issue descriptionMigrate all platforms to SessionCrashedBubble and delete old infobar code. Currently, the session crashed bubble is available on Windows and Linux, while CrOS and Mac still use the infobar. Some work is needed to migrate the remaining two platforms to the bubble and remove the code for the infobar version of this UI. On Mac, maybe this could re-use the views code leveraging MacViews work?
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/744a55eb6a5bdcff9158ebc73814c41263e07223 commit 744a55eb6a5bdcff9158ebc73814c41263e07223 Author: sky <sky@chromium.org> Date: Fri Jan 27 22:12:22 2017 Makes SessionCrashedBubbleView work on chromeos I've also made SessionCrashedInfoBarDelege only compiled on mac non-views. BUG= 653966 TEST=none R=yiyaoliu@chromium.org Review-Url: https://codereview.chromium.org/2656213002 Cr-Commit-Position: refs/heads/master@{#446787} [modify] https://crrev.com/744a55eb6a5bdcff9158ebc73814c41263e07223/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/744a55eb6a5bdcff9158ebc73814c41263e07223/chrome/browser/ui/startup/session_crashed_infobar_delegate.h [modify] https://crrev.com/744a55eb6a5bdcff9158ebc73814c41263e07223/chrome/browser/ui/startup/startup_browser_creator_impl.cc [modify] https://crrev.com/744a55eb6a5bdcff9158ebc73814c41263e07223/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/744a55eb6a5bdcff9158ebc73814c41263e07223/chrome/browser/ui/views/session_crashed_bubble_view.cc [modify] https://crrev.com/744a55eb6a5bdcff9158ebc73814c41263e07223/chrome/test/BUILD.gn
,
Feb 21 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
+grt, maybe relevant to Issue 807072
,
Mar 12 2018
Thanks. I think this is more of a MacViews-Browser thing for macOS. For ChromeOS, maybe Chrome UX should weigh-in.
,
Mar 12 2018
Remaining work is on Mac, since CrOS was done by sky@ upthread. Renaming bug and target platforms.
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dd87d54ea9aaa30714b6d467350686bb34abf1b commit 4dd87d54ea9aaa30714b6d467350686bb34abf1b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Mar 16 13:55:45 2018 polychrome: wire SessionCrashedBubbleView This change: 1) Allows SessionCrashedBubbleView to anchor to a rect instead of a view; 2) Has it use a rect when a Cocoa browser window is in use; 3) Has SessionCrashedBubbleViewTest use a rect when a Cocoa browser window is in use too Bug: 653966 , 817408 Change-Id: I89d6327cc4df09e870891ace0b9cca151235051a Reviewed-on: https://chromium-review.googlesource.com/961501 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#543690} [modify] https://crrev.com/4dd87d54ea9aaa30714b6d467350686bb34abf1b/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/4dd87d54ea9aaa30714b6d467350686bb34abf1b/chrome/browser/ui/bubble_anchor_util.h [modify] https://crrev.com/4dd87d54ea9aaa30714b6d467350686bb34abf1b/chrome/browser/ui/cocoa/bubble_anchor_util_views_mac.mm [delete] https://crrev.com/aaa47c0d8a36bd4127d96c513b35e9c75db75fe1/chrome/browser/ui/cocoa/session_crashed_bubble.mm [modify] https://crrev.com/4dd87d54ea9aaa30714b6d467350686bb34abf1b/chrome/browser/ui/views/session_crashed_bubble_view.cc [modify] https://crrev.com/4dd87d54ea9aaa30714b6d467350686bb34abf1b/chrome/browser/ui/views/session_crashed_bubble_view.h [modify] https://crrev.com/4dd87d54ea9aaa30714b6d467350686bb34abf1b/chrome/browser/ui/views/session_crashed_bubble_view_browsertest.cc
,
Mar 23 2018
MacViews triage: we use SessionCrashedBubbleView starting in M67, and we'll always use it in the Views browser; I'm calling this Fixed even though the old code is not yet deleted. It will be deleted as part of the post-MacViews-Browser cleanup.
,
Mar 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tapted@chromium.org
, Oct 10 2016Status: Available (was: Untriaged)