Android download warnings show up empty, and then get stuck |
||||||
Issue descriptionVersion: 55.0.2883.0 (canary) Any of the file types in download_file_type.asciipb that are configured to warn on Android (or on all platforms) show a warning dialog with no text [1]. Looks like a string is missing. Test case: Try "foo.apl" at the end here: http://parkerly.com/sb-tests/downloads/downloads.html
,
Oct 7 2016
,
Oct 7 2016
Do you see this on Beta as well?
,
Oct 7 2016
Which device you are able repro this? I build from trunk and i didn't see the issue. Could it be that the text are in white color so you won't be able to see it? But wrong text color is also very strange.
,
Oct 7 2016
,
Oct 7 2016
On beta (54.0.2480.50) I do see the text. And there it warns on both .apk and .spl, even though my change to download_file_types.asciipb to additionally warn on apks is not in beta. So this is confusing to me.
,
Oct 7 2016
For beta, the finch experiment of disabling android DownloadManager is 50% So you have 50% of the chance that are still using android DM, and that code path checks .apk
,
Oct 11 2016
I was testing on my personal Nexus 5x, and I got the Canary build from the google.com part of playstore. https://play.google.com/store/apps/details?id=com.chrome.canary The blank warning still repros on the latest canary, 56.0.2886.0. It doesn't repro on dev or beta for me, but I'm unsure of my experiment state.
,
Oct 11 2016
Varun can also repro the blank warning on the same canary, on N5x.
,
Oct 11 2016
,
Oct 13 2016
qinmin -- Can you repro this?
,
Oct 13 2016
Yes, I can repro. The java implementation of the dangerous infobar should be deprecated, i am rewriting that.
,
Oct 13 2016
Sorry, wrong bug, I cannot repro this one.
,
Oct 13 2016
met with Varun, and we cannot repro the problem on his device, with both incognito and non-incognito mode.
,
Oct 14 2016
OK, I can no longer repro on 56.0.2889.0, so I'm assuming it was fixed between .2886.0 and .2889.0. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nparker@chromium.org
, Oct 7 2016214 KB
214 KB View Download