Issue metadata
Sign in to add a comment
|
No IME inside Flash and PDF plugins |
||||||||||||||||||||||
Issue descriptionToT (m55) Repro step 1) watch video on nicovideo.jp 2) set focus to comment text field. 3) try to activate ime shuchen@, can you look into this?
,
Oct 18 2016
This seems to be a recent regression, and the IME doesn't work on PDF plugin either.
,
Oct 24 2016
,
Oct 24 2016
CL bisecting in progress...
,
Oct 24 2016
,
Oct 24 2016
The regression root cause cl found: https://codereview.chromium.org/2285923002 Over to dglazkov@.
,
Oct 24 2016
Should we revert the CL in comment 6 or do we have a better fix? This is marked as release block beta and we are going for beta promotion in the next day or so, so we should try to land a fix into the 55 branch today if possible.
,
Oct 24 2016
Please feel free to revert. Apologies for causing the breakage.
,
Oct 24 2016
Revert is baking here: https://codereview.chromium.org/2442323004
,
Oct 25 2016
Since this is a revert, please feel free to merge to 55 when ready.
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97b6c2bd1278f651b9b30e22685ede87f761a9ca commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca Author: dglazkov <dglazkov@chromium.org> Date: Tue Oct 25 17:35:55 2016 Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG= 653958 TBR=esprehn Review-Url: https://codereview.chromium.org/2442323004 Cr-Commit-Position: refs/heads/master@{#427396} [modify] https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca/content/renderer/render_widget.cc [modify] https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca/content/renderer/render_widget.h [add] https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca/third_party/WebKit/public/web/WebTextInputType.h
,
Oct 25 2016
What's the branch number?
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cddb25425a67f01e75126631a0e03a6b86b1fa3a commit cddb25425a67f01e75126631a0e03a6b86b1fa3a Author: Dimitri Glazkov <dglazkov@chromium.org> Date: Tue Oct 25 17:58:42 2016 Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG= 653958 TBR=esprehn Review-Url: https://codereview.chromium.org/2442323004 Cr-Commit-Position: refs/heads/master@{#427396} (cherry picked from commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca) Review URL: https://codereview.chromium.org/2453503002 . Cr-Commit-Position: refs/branch-heads/2883@{#286} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/cddb25425a67f01e75126631a0e03a6b86b1fa3a/content/renderer/render_widget.cc [modify] https://crrev.com/cddb25425a67f01e75126631a0e03a6b86b1fa3a/content/renderer/render_widget.h
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff commit e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff Author: dglazkov <dglazkov@chromium.org> Date: Tue Oct 25 19:50:17 2016 Revert of Revert "Simplify handling of text input types in RenderWidget." (patchset #1 id:1 of https://codereview.chromium.org/2453503002/ ) Reason for revert: Bad diff editing on my part. Original issue's description: > Revert "Simplify handling of text input types in RenderWidget." > > This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, > because it broke IME. > > BUG= 653958 > TBR=esprehn > > Review-Url: https://codereview.chromium.org/2442323004 > Cr-Commit-Position: refs/heads/master@{#427396} > (cherry picked from commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca) > > Committed: https://chromium.googlesource.com/chromium/src/+/cddb25425a67f01e75126631a0e03a6b86b1fa3a TBR=esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 653958 Review-Url: https://codereview.chromium.org/2447213002 Cr-Commit-Position: refs/branch-heads/2883@{#293} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff/content/renderer/render_widget.cc [modify] https://crrev.com/e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff/content/renderer/render_widget.h
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f68829f011220cf1c0834d15f6245269fd136cae commit f68829f011220cf1c0834d15f6245269fd136cae Author: dglazkov <dglazkov@chromium.org> Date: Tue Oct 25 21:40:19 2016 Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df. This is a revert for the M55 branch. BUG= 653958 TBR=esprehn NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2445383003 Cr-Commit-Position: refs/branch-heads/2883@{#298} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/f68829f011220cf1c0834d15f6245269fd136cae/content/renderer/render_widget.cc [modify] https://crrev.com/f68829f011220cf1c0834d15f6245269fd136cae/content/renderer/render_widget.h [modify] https://crrev.com/f68829f011220cf1c0834d15f6245269fd136cae/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
,
Oct 26 2016
,
Oct 26 2016
Issue 652886 has been merged into this issue.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cddb25425a67f01e75126631a0e03a6b86b1fa3a commit cddb25425a67f01e75126631a0e03a6b86b1fa3a Author: Dimitri Glazkov <dglazkov@chromium.org> Date: Tue Oct 25 17:58:42 2016 Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG= 653958 TBR=esprehn Review-Url: https://codereview.chromium.org/2442323004 Cr-Commit-Position: refs/heads/master@{#427396} (cherry picked from commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca) Review URL: https://codereview.chromium.org/2453503002 . Cr-Commit-Position: refs/branch-heads/2883@{#286} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/cddb25425a67f01e75126631a0e03a6b86b1fa3a/content/renderer/render_widget.cc [modify] https://crrev.com/cddb25425a67f01e75126631a0e03a6b86b1fa3a/content/renderer/render_widget.h
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff commit e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff Author: dglazkov <dglazkov@chromium.org> Date: Tue Oct 25 19:50:17 2016 Revert of Revert "Simplify handling of text input types in RenderWidget." (patchset #1 id:1 of https://codereview.chromium.org/2453503002/ ) Reason for revert: Bad diff editing on my part. Original issue's description: > Revert "Simplify handling of text input types in RenderWidget." > > This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, > because it broke IME. > > BUG= 653958 > TBR=esprehn > > Review-Url: https://codereview.chromium.org/2442323004 > Cr-Commit-Position: refs/heads/master@{#427396} > (cherry picked from commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca) > > Committed: https://chromium.googlesource.com/chromium/src/+/cddb25425a67f01e75126631a0e03a6b86b1fa3a TBR=esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 653958 Review-Url: https://codereview.chromium.org/2447213002 Cr-Commit-Position: refs/branch-heads/2883@{#293} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff/content/renderer/render_widget.cc [modify] https://crrev.com/e1a7ff9b61c9e16607ee1550bcab8ce52d7332ff/content/renderer/render_widget.h
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f68829f011220cf1c0834d15f6245269fd136cae commit f68829f011220cf1c0834d15f6245269fd136cae Author: dglazkov <dglazkov@chromium.org> Date: Tue Oct 25 21:40:19 2016 Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df. This is a revert for the M55 branch. BUG= 653958 TBR=esprehn NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2445383003 Cr-Commit-Position: refs/branch-heads/2883@{#298} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/f68829f011220cf1c0834d15f6245269fd136cae/content/renderer/render_widget.cc [modify] https://crrev.com/f68829f011220cf1c0834d15f6245269fd136cae/content/renderer/render_widget.h [modify] https://crrev.com/f68829f011220cf1c0834d15f6245269fd136cae/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Jan 24 2017
chrome os 57.0.2987.6/9202.1.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shuchen@chromium.org
, Oct 10 2016