New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653941 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Watermark on PDF viewed through Chrome PDF Viewer is distorted

Reported by agreen...@gmail.com, Oct 7 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
There are two ways to reproduce this issue:

The simple way is:

1) Take the attached file and drag it into the Chrome browser on a Mac.  Make sure that it opens using the Chrome PDF Viewer.

BUG: There's a grey watermark that runs over each page.  It's supposed to display the user's name, email address and some other info.  However, it is distorted and unreadable. 

NOTE: If you open the PDF in the Mac system PDF viewer you'll see that the watermark is not distorted.  Also, the watermark is not distorted on Safari, Chrome (on Windows), Firefox and IE 11.

If you want to see how this works in our application you can also follow these instructions:

1. Navigate to https://ib.pelotondocs.com
2. Login using these credentials

chromemac_pdf@mailinator.com
2btsmY??KmoJ2NW

3. You should land on the Library page and see a tile for Project Fitness.  

4. Click the "View" button

5. You should land on our document viewer page.  

6. Click "Download & Print" in the right column. 

7. A modal should show up that says "Thank you for your patience..." and has a spinner.  Once the processing is complete a green "Download & Print" button should be displayed. 

8. Click the green "Download & Print" button and a PDF should be downloaded to the Chrome tray at the bottom of the browser

9.  Open this PDF in the Chrome PDF viewer.  

10 BUG: There's a grey watermark that runs over each page.  It's supposed to display the user's name, email address and some other info.  However, it is distorted and unreadable. 

NOTE: If you open the PDF in the Mac system PDF viewer you'll see that the watermark is not distorted.  Also, the watermark is not distorted on Safari, Chrome (on Windows), Firefox and IE 11.  

What is the expected behavior?
The watermark should not be distorted.  

What went wrong?
The watermark text is distorted. 

WebStore page: chrome-extension://mhjfbmdgcfjbbpaeojofohoefglehjai/

Did this work before? N/A 

Chrome version: 53.0.2785.143  Channel: stable
OS Version: 10.10.3
Flash Version: Shockwave Flash 23.0 0.166
 
Project Fitness CIP.pdf
4.1 MB Download
Components: -Platform>Apps Internals>Plugins>PDF
Status: Available (was: Unconfirmed)
Indeed it looks to be broken on Mac only.
Cc: npm@chromium.org caryclark@google.com
See attached renderings for Linux vs Mac without Skia vs Mac with Skia.

Mac with Skia still renders the text smaller than Linux, and the watermark is missing on some of the other pages.
linux.png
107 KB View Download
mac.png
92.7 KB View Download
mac_skia.png
84.2 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/4ea4281ad5775686317ef53f48eab39898d13d23

commit 4ea4281ad5775686317ef53f48eab39898d13d23
Author: npm <npm@chromium.org>
Date: Tue Oct 11 18:51:21 2016

Fix negative font rendering on Mac by reversing matrix c component.

Notice that this is just making it analoguous to how it works when the
font is positive: the b and d components are reversed. Currently, when
the font is negative, only the a component is reversed. The c one needs
to be reversed as well.

BUG= chromium:653941 

Review-Url: https://codereview.chromium.org/2411833002

[modify] https://crrev.com/4ea4281ad5775686317ef53f48eab39898d13d23/core/fxge/apple/fx_apple_platform.cpp

Owner: npm@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd3b4c8269b6543a97ebb308e75cacf1d6156b2c

commit bd3b4c8269b6543a97ebb308e75cacf1d6156b2c
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Tue Oct 11 21:42:31 2016

Roll src/third_party/pdfium/ 4526faf9d..19c198b7b (4 commits).

https://pdfium.googlesource.com/pdfium.git/+log/4526faf9d62b..19c198b7b806

$ git log 4526faf9d..19c198b7b --date=short --no-merges --format='%ad %ae %s'
2016-10-11 dsinclair Convert CPDFSDK_ActionHandler to CPDFSDK_FormFillEnvironment
2016-10-11 dsinclair Convert IJS_Runtime to CPDFSDK_FormFillEnvironment
2016-10-11 tsepez Rename fpdf_page_doc.cpp -> cpdf_docpagedata.h
2016-10-11 npm Fix negative font rendering on Mac by reversing matrix c component.

BUG= 653941 

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2414453003
Cr-Commit-Position: refs/heads/master@{#424558}

[modify] https://crrev.com/bd3b4c8269b6543a97ebb308e75cacf1d6156b2c/DEPS

Comment 6 by npm@chromium.org, Oct 28 2016

Labels: Merge-Request-55

Comment 7 by dimu@chromium.org, Oct 28 2016

Labels: -Merge-Request-55 Merge-Review-55 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 8 by gov...@chromium.org, Oct 29 2016

Before we approve merge to M55, could you please confirm whether this change is well baked/tested/verified in Canary and safe to merge?
Yes, the CL has been in Canary / Dev channel for ~2 weeks now.
Labels: -Merge-Review-55 Merge-Approved-55
Approving merge to M55 branch 2883 based on comment #9. Please merge before 4:00 PM PT on Monday (10/31/16) so we can take it for next week Beta release. Thank you.
**** Bulk edit -  please ignore if not applicable ****

Please merge your change to M55 branch 2883 today before 5:00 PM PT or latest by tomorrow, Tuesday (11/01/16) 4:00 PM PT so we can take it for this week Beta release. 
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/79c21fc410598af52d4602c45c64d2bd49604007

commit 79c21fc410598af52d4602c45c64d2bd49604007
Author: Nicolas Pena <npm@google.com>
Date: Mon Oct 31 17:59:02 2016

Comment 13 by npm@chromium.org, Oct 31 2016

Labels: -Hotlist-Merge-Review -Merge-Approved-55 merge-merged-2883

Sign in to add a comment