When the overwrite button is pressed, downloading is started but the existing files with the same URL are never deleted.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a97d07086a724662167d73893ab9d2ab00605d1 commit 6a97d07086a724662167d73893ab9d2ab00605d1 Author: dewittj <dewittj@chromium.org> Date: Tue Oct 11 22:20:28 2016 [Offline Pages] Fix several infobar bugs. * Overwrite button now deletes all page downloads with the same URL before saving the new page * Folder name is now called "Downloads" * Folder link now opens "Downloads home" BUG= 653936 Review-Url: https://codereview.chromium.org/2400213003 Cr-Commit-Position: refs/heads/master@{#424569} [modify] https://crrev.com/6a97d07086a724662167d73893ab9d2ab00605d1/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java [modify] https://crrev.com/6a97d07086a724662167d73893ab9d2ab00605d1/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/6a97d07086a724662167d73893ab9d2ab00605d1/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/6a97d07086a724662167d73893ab9d2ab00605d1/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/6a97d07086a724662167d73893ab9d2ab00605d1/chrome/browser/android/offline_pages/downloads/offline_page_infobar_delegate.cc [modify] https://crrev.com/6a97d07086a724662167d73893ab9d2ab00605d1/chrome/browser/android/offline_pages/downloads/offline_page_infobar_delegate.h
Your change meets the bar and is auto-approved for M55 (branch: 2883)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95bb537b8bc68e1c24a517976bb078373e9c66a8 commit 95bb537b8bc68e1c24a517976bb078373e9c66a8 Author: Justin DeWitt <dewittj@chromium.org> Date: Thu Oct 13 18:37:01 2016 [Offline Pages] Fix several infobar bugs. * Overwrite button now deletes all page downloads with the same URL before saving the new page * Folder name is now called "Downloads" * Folder link now opens "Downloads home" BUG= 653936 Review-Url: https://codereview.chromium.org/2400213003 Cr-Commit-Position: refs/heads/master@{#424569} (cherry picked from commit 6a97d07086a724662167d73893ab9d2ab00605d1) Review URL: https://codereview.chromium.org/2419843002 . Cr-Commit-Position: refs/branch-heads/2883@{#91} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/95bb537b8bc68e1c24a517976bb078373e9c66a8/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java [modify] https://crrev.com/95bb537b8bc68e1c24a517976bb078373e9c66a8/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/95bb537b8bc68e1c24a517976bb078373e9c66a8/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/95bb537b8bc68e1c24a517976bb078373e9c66a8/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/95bb537b8bc68e1c24a517976bb078373e9c66a8/chrome/browser/android/offline_pages/downloads/offline_page_infobar_delegate.cc [modify] https://crrev.com/95bb537b8bc68e1c24a517976bb078373e9c66a8/chrome/browser/android/offline_pages/downloads/offline_page_infobar_delegate.h
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by bugdroid1@chromium.org
, Oct 11 2016