New issue
Advanced search Search tips

Issue 653913 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

MeasureAs doesn't work in an interface when it has partial interface

Project Member Reported by xidac...@chromium.org, Oct 7 2016

Issue description

Please see details in here:
https://codereview.chromium.org/2398703004/

PS#2, shows the problem, PS#3 is one way to fix it, but I am not sure if that is the preferred way or not.
 
Cc: haraken@chromium.org bashi@chromium.org
Owner: yukishiino@chromium.org
yukishiino@: Would you take a look at this?

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99de2c286ec4ad051d562c6e1b7c2955fa860430

commit 99de2c286ec4ad051d562c6e1b7c2955fa860430
Author: xidachen <xidachen@chromium.org>
Date: Tue Oct 11 03:47:41 2016

Adding feature usage count for OffscreenCanvas

This CL adds [MeasureAs=xxx] in the .idl files that corresponding to the
OffscreenCanvas creation.

Also, we found that PS#2 has compilation error, and looks like
putting MeasureAs in an interface that has a partial interface
triggers the error. PS#3 is one way to fix it.

BUG= 653599 , 653913

Review-Url: https://codereview.chromium.org/2398703004
Cr-Commit-Position: refs/heads/master@{#424363}

[modify] https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl
[modify] https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.idl
[modify] https://crrev.com/99de2c286ec4ad051d562c6e1b7c2955fa860430/tools/metrics/histograms/histograms.xml

Sign in to add a comment