New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653905 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

new tab button's "pressed" state is missing (or not visible) on samus

Project Member Reported by osh...@chromium.org, Oct 7 2016

Issue description

Google Chrome	55.0.2878.0 (Official Build) dev (64-bit)
Revision	0
Platform	8861.0.0 (Official Build) dev-channel samus

see attached vid. not sure if this is md related.
assigning to tdanderson@ for triage.


 
VID_20161007_081841.mp4
6.5 MB View Download
Cc: tdander...@chromium.org
Labels: Proj-MaterialDesign-NativeUI
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
I think this is probably due to one of Evan's recent theme changes. Evan, can you please take a look?

oshima@, are you using a custom browser theme in the video?
no, it's default one.

Comment 3 by est...@chromium.org, Oct 10 2016

thanks for report, got over-zealous deleting stuff.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/434b901825d725fb21e7a98ab2f27b128c504159

commit 434b901825d725fb21e7a98ab2f27b128c504159
Author: estade <estade@chromium.org>
Date: Mon Oct 10 20:40:47 2016

Fix new tab button (broken when removing pre-MD code).

BUG= 653905 

Review-Url: https://codereview.chromium.org/2401423004
Cr-Commit-Position: refs/heads/master@{#424230}

[modify] https://crrev.com/434b901825d725fb21e7a98ab2f27b128c504159/chrome/browser/ui/views/tabs/tab_strip.cc

Comment 5 by est...@chromium.org, Oct 10 2016

Status: Fixed (was: Assigned)

Comment 6 by est...@chromium.org, Oct 24 2016

Labels: Merge-Request-55
Status: Started (was: Fixed)
oops, guess I need to merge this.

Comment 7 by est...@chromium.org, Oct 24 2016

Cc: kkaluri@chromium.org
 Issue 658615  has been merged into this issue.
Labels: -Merge-Request-55 Merge-Approved-55

Comment 9 by est...@chromium.org, Oct 24 2016

Status: Fixed (was: Started)
https://codereview.chromium.org/2447833002/

merged
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15762bd6c5d58d85a75fb4ebcb21be18ed6040ee

commit 15762bd6c5d58d85a75fb4ebcb21be18ed6040ee
Author: Evan Stade <estade@chromium.org>
Date: Mon Oct 24 17:48:42 2016

Fix new tab button (broken when removing pre-MD code).

BUG= 653905 

Review-Url: https://codereview.chromium.org/2401423004
Cr-Commit-Position: refs/heads/master@{#424230}
(cherry picked from commit 434b901825d725fb21e7a98ab2f27b128c504159)

Review URL: https://codereview.chromium.org/2447833002 .

Cr-Commit-Position: refs/branch-heads/2883@{#241}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/15762bd6c5d58d85a75fb4ebcb21be18ed6040ee/chrome/browser/ui/views/tabs/tab_strip.cc

Project Member

Comment 11 by sheriffbot@chromium.org, Oct 28 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-55
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.35.0, 55.0.2883.35

Comment 14 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment