Issue metadata
Sign in to add a comment
|
Fix and reenable battor.tough_video_cases on Win 10 High-DPI |
||||||||||||||||||
Issue descriptionCharlie there is not other owner in the spreadsheet for the battor benchmarks (https://docs.google.com/spreadsheets/d/1R_1BAOd3xeVtR0jn6wB5HHJ2K25mIbKp3iIRQKkX38o/edit#gid=0), could you assign to the appropriate person to investigate? A few different tests seem to be failing with the same stack trace on Win 10 High-DPI Perf (1) and (5) system_health.common_desktop:https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%2010%20High-DPI%20Perf%20%281%29/builds/336 battor.tough_video_cases & _reference:https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%2010%20High-DPI%20Perf%20%285%29/builds/220 Common stack trace: [ RUN ] video.html?src=crowd.wav&type=audio INFO:root:Trace config file string: {"trace_config": {"included_categories": ["toplevel", "rail", "blink.console"], "record_mode": "record-as-much-as-possible"}} INFO:py_utils.cloud_storage:Try to lock C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\bin\win\AMD64\battor_agent.exe INFO:py_utils.cloud_storage:Global file lock acquired, try to create pseudo_lock_path: C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\bin\win\AMD64\battor_agent.exe.pseudo_lock INFO:py_utils.cloud_storage:Downloading gs://chromium-telemetry/binary_dependencies/battor/battor_agent_binary_65e728f774c25958ccff2ec4613ca387413e26b5 to C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\bin\win\AMD64\battor_agent.exe INFO:py_utils.cloud_storage:Try to remove pseudo_lock_path: C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\bin\win\AMD64\battor_agent.exe.pseudo_lock INFO:py_utils.cloud_storage:Done locking C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\bin\win\AMD64\battor_agent.exe CRITICAL:root:Finding return code for BattOr shell. CRITICAL:root:Found return code: None CRITICAL:root:BattOr shell was not properly closed. Killing now. INFO:py_utils.cloud_storage:Uploading c:\users\chrome~1.lab\appdata\local\temp\tmp9iftqy to gs://chrome-telemetry-output/battor-serial-log-2016-10-07_04-13.txt-50143.txt WARNING:root:Cannot dump browser state: No browser. WARNING:root:Either tab has crashed or browser does not support taking tab screenshot. Skip taking screenshot on failure. Traceback (most recent call last): File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 78, in _RunStoryAndProcessErrorIfNeeded test.WillRunStory(state.platform) File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\web_perf\timeline_based_measurement.py", line 282, in WillRunStory platform.tracing_controller.StartTracing(self._tbm_options.config) File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\core\tracing_controller.py", line 43, in StartTracing self._tracing_controller_backend.StartTracing(tracing_config, timeout) File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_controller_backend.py", line 91, in StartTracing if agent.StartAgentTracing(config, timeout): File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_agent\battor_tracing_agent.py", line 73, in StartAgentTracing self._battor.StartTracing() File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\battor\battor_wrapper.py", line 155, in StartTracing self._SendBattorCommand(self._START_TRACING_CMD) File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\battor\battor_wrapper.py", line 266, in _SendBattorCommand self._UploadSerialLogToCloudStorage() File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\battor\battor\battor_wrapper.py", line 289, in _UploadSerialLogToCloudStorage self._serial_log_bucket, remote_path, self._serial_log_file.name) File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\py_utils\py_utils\cloud_storage.py", line 317, in Insert _RunCommand(command_and_args) File "C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\py_utils\py_utils\cloud_storage.py", line 162, in _RunCommand raise CloudStorageError(stderr) CloudStorageError: CommandException: Error opening file "file://c:\users\chrome~1.lab\appdata\local\temp\tmp9iftqy": . INFO:root:Try printing formatted exception: None None None Exception raised when cleaning story run: Traceback (most recent call last): _RunStoryAndProcessErrorIfNeeded at C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\internal\story_runner.py:104 state.DidRunStory(results) traced_function at C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py:75 return func(*args, **kwargs) DidRunStory at C:\b\c\b\Win_10_High_DPI_Perf__5_\src\third_party\catapult\telemetry\telemetry\page\shared_page_state.py:166 if self._current_page.credentials and self._did_login_for_current_page: AttributeError: 'NoneType' object has no attribute 'credentials' Locals: results : <telemetry.internal.results.page_test_results.PageTestResults object at 0x03B12430> [ FAILED ] video.html?src=crowd.wav&type=audio (9641 ms) If the test is disabled, please downgrade to Pri-2.
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93d3a4a026d6ad24981f394883b9947edda80bdf commit 93d3a4a026d6ad24981f394883b9947edda80bdf Author: zhenw <zhenw@chromium.org> Date: Sat Nov 12 04:56:13 2016 Disable system_health.common_desktop on Mac and Win10 perf bots TBR=nednguyen@google.com BUG=657665, 653893 , 664661 Review-Url: https://codereview.chromium.org/2498753002 Cr-Commit-Position: refs/heads/master@{#431774} [modify] https://crrev.com/93d3a4a026d6ad24981f394883b9947edda80bdf/tools/perf/benchmarks/system_health.py
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1 commit 14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1 Author: zhenw <zhenw@chromium.org> Date: Sat Nov 12 16:47:53 2016 Revert of Disable system_health.common_desktop on Mac and Win10 perf bots (patchset #1 id:1 of https://codereview.chromium.org/2498753002/ ) Reason for revert: According to Ned, we should disable the failing story only. Reverting this CL. Will disable the story on Monday. Original issue's description: > Disable system_health.common_desktop on Mac and Win10 perf bots > > TBR=nednguyen@google.com > BUG=657665, 653893 , 664661 > > Committed: https://crrev.com/93d3a4a026d6ad24981f394883b9947edda80bdf > Cr-Commit-Position: refs/heads/master@{#431774} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657665, 653893 , 664661 Review-Url: https://codereview.chromium.org/2498693003 Cr-Commit-Position: refs/heads/master@{#431789} [modify] https://crrev.com/14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1/tools/perf/benchmarks/system_health.py
,
Nov 15 2016
Charlie, is battor.tough_video_cases problem fixed? The bot is green as the system_health failing stories are disabled.
,
Jan 13 2017
Yep, this has been fixed.
,
Mar 14 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by martiniss@chromium.org
, Oct 24 2016