Should have asked you to file this in crbug. Moving it there and then will apply the appropriate labels.

Moved issue gerrit:4725 to now be  issue chromium:653880 .

Some context:

Rietveld has supported both revert flows-
* Re-use reverted issue since it contains context.
* Create a new issue to reland.

Both flows have passionate fans and I documented both flows for Rietveld's one-click revert here-
https://docs.google.com/document/d/1lMewWeARYME5S8TwlEkhfEwMioaHxWsEm_UZONt7Qco/edit#heading=h.vaccx5cfsgoo


I personally prefer supporting only one flow due to reduced documentation, maintenance, and tool support. But, it is a very valid point that losing the ability to reopen an issue is a regression from Rietveld. Not supporting the re-open"flow will result in some unhappy customers.

There is an existing bug for reopening an issue in Gerrit- https://bugs.chromium.org/p/gerrit/issues/detail?id=1703
But it is a P3. This crbug will help us decide whether we should push for that gerrit bug to be higher priority and whether it should be a blocker for the Chromium migration or not.

I definitely support allowing to reopen reverted CLs to amend them, and I use this feature often when a CL needs to be reverted. The main reason being the documentation of comments and patches as described in the initial report. Often things are reverted for very trivial errors in the code that are quick 1 line changes. It's a shame to lose all the history just this.

An additional thing that wasn't mentioned is it makes it simpler locally to keep working on the same git branch with all my local git history for a change.

To be clear, I want this feature for skia-review.googlesource.com.  I don't personally care whether Chromium's code review has this feature or not.

I also always reopen a reverted CL to continue working on it. Opening a new CL makes it more difficult to grasp the history of a change.

First off, we will get more signal as more users are onboarded and that will be the determinant factor on whether this blocks moving chromium/src over.

That said, let me provide my view on this issue. Please don’t read this as me being dismissive, but I have to be pragmatic when evaluating these decisions due to the immense workload on the Gerrit team.

Is this something that you would be OK with being in the afterglow milestone? This milestone is for issues that WILL be fixed, but are not considered launch blockers.

Afterglow sounds just fine to me.

Great. Will adjust the milestone accordingly. Thank you for understanding and please keep the feedback coming.

The majority of this work was done in https://bugs.chromium.org/p/chromium/issues/detail?id=718519

The "Reland" button now exists, but there are some improvements to be made:
* We'd like to show it only on Reverted patchsets, but gerrit doesn't yet explicitly track that information, so for now we show the button on all submitted changes
* It doesn't have great error handling for the case where you click the Reopen button on a change that hasn't been reverted, so the patch doesn't apply on top of master
* It doesn't preserve all metadata like the original reviewers; you currently have to add those back by hand

 Issue gerrit:6671  has been merged into this issue.

 Issue gerrit:7010  has been merged into this issue.

 Issue 762004  has been merged into this issue.

 Issue 762101  has been merged into this issue.

 Issue 792554  has been merged into this issue.

 Issue gerrit:8027  has been merged into this issue.

Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

Setting Pri-1 to target this for Q1 2018.

 Issue 813935  has been merged into this issue.

* We still can't show it only on changes which have been reverted; that information isn't available to us
* Improving error handling here: https://chromium-review.googlesource.com/#/c/infra/gerrit-plugins/chromium-behavior/+/982640
* Reviewers are now kept

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/9daf0ac7c15428b8ecbee31fa4e3b379b4d2ad82

commit 9daf0ac7c15428b8ecbee31fa4e3b379b4d2ad82
Author: Aaron Gable <agable@chromium.org>
Date: Tue Mar 27 21:33:05 2018

Pop-up error message when reland fails

R=rmistry

Bug:  653880 
Change-Id: I9876938003694adc47d1fee963798ea3abd2f421
[modify] https://crrev.com/9daf0ac7c15428b8ecbee31fa4e3b379b4d2ad82/src/main/resources/static/chromium-behavior.html