Issue 653874 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ lawrencewu@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Cc:	asvitk...@chromium.org skare@chromium.org isherman@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Use single shared memory segment for sharing field trials

Reported by lawrencewu@chromium.org, Oct 7 2016

Issue description

Currently, we create a new shared memory segment per process host (it gets stored in RenderProcessHostImpl or GpuProcessHost). Let's hoist that variable up into a static base::FieldTrialList member, and also start using the PersistentMemoryAllocator to store all the field trials instead of using a string.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b496492defaf5f2f70e08318c36568ccce9ce87

commit 0b496492defaf5f2f70e08318c36568ccce9ce87
Author: lawrencewu <lawrencewu@chromium.org>
Date: Tue Oct 25 16:28:14 2016

Use SharedPersistentMemoryAllocator to share field trial state

Change the method by which we share field trial state from using a
SharedMemory class to SharedPersistentMemoryAllocator. Adds this
allocator to the base::FieldTrialList singleton, so there is only one copy
of this state on the browser process vs. a copy for each process host
which is how it currently works (from
https://codereview.chromium.org/2365273004/)

BUG= 653874 

Review-Url: https://codereview.chromium.org/2412113002
Cr-Commit-Position: refs/heads/master@{#427378}

[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/base/metrics/field_trial.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/base/metrics/field_trial.h
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/base/metrics/field_trial_unittest.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/browser_child_process_host_impl.h
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/child_process_launcher.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/child_process_launcher.h
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/content/public/browser/browser_child_process_host.h
[modify] https://crrev.com/0b496492defaf5f2f70e08318c36568ccce9ce87/tools/metrics/histograms/histograms.xml