New issue
Advanced search Search tips

Issue 653873 link

Starred by 1 user
Status: Verified
Owner:
hbos@chromium.org
Closed: Jan 2017
Cc:
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 627816
issue 633550



Sign in to add a comment

RTCPeerConnection.getStats: RTCTransportStats

Project Member Reported by hbos@chromium.org, Oct 7 2016 
Add RTCTransportStats and all of its members.
https://w3c.github.io/webrtc-stats/#transportstats-dict*

dictionary RTCTransportStats : RTCStats {
    unsigned long long bytesSent;
    unsigned long long bytesReceived;
    DOMString          rtcpTransportStatsId;
    boolean            activeConnection;
    DOMString          selectedCandidatePairId;
    DOMString          localCertificateId;
    DOMString          remoteCertificateId;
};

Comment 1 by hbos@chromium.org, Oct 7 2016

Blocking: 633550

Comment 2 by hbos@chromium.org, Oct 7 2016

Blockedon: 633550

Comment 3 by hbos@chromium.org, Oct 11 2016

Blockedon: -633550

Comment 4 by hbos@chromium.org, Oct 11 2016

Components: Blink>WebRTC

Comment 5 by hbos@chromium.org, Oct 20 2016

Blocking: 627816

Comment 7 by anatolid@chromium.org, Nov 29 2016

Labels: M-56
Is this finished?

Comment 8 by hbos@chromium.org, Nov 29 2016

Labels: -M-56 M-57
Status: Started (was: Assigned)
While RTCTransportStats is done, there's still a cleanup-related TODO in the unittest. (Misleading to have this open still, I admit.) I will close this bug as soon as https://codereview.webrtc.org/2527113002/ lands.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0583b286e44b6f6d4d5c5185ed94b60f37aad598

commit 0583b286e44b6f6d4d5c5185ed94b60f37aad598
Author: hbos <hbos@webrtc.org>
Date: Wed Nov 30 09:50:14 2016

Collecting RTCIceCandidatePairStats.transport_id and improved unittests.

RTCIceCandidatePairStats.transport_id is set to the related
RTCTransportStats' id.

Unittest for RTCIceCandidatePairStats is updated to do EXPECT_EQ
between actual and an expected hardcoded dictionary. The previous way of
testing, ExpectReportContainsCandidatePair, is removed.

(ExpectReportContainsCandidate still exist, we might want to replace
this by EXPECT_EQ testing in a follow up.)

Unittest for RTCTransportStats is similarly updated and
ExpectReportContainsTransportStats is removed. A bug was uncovered where
the "rtcp_connection_info.best_connection = true" case was not tested
(a copy of rtcp_connection_info was used in the test, modifying that had
no affect on the test) - fixed.

rtcstats_integrationtest.cc updated to take transport_id into account.

In order to reuse an updated version of expected_rt[c]p_transport in the
unittest, timestamps are ignored by RTCStats::operator==.

BUG= chromium:627816 ,  chromium:653873 ,  chromium:653873 ,  webrtc:6755 

Review-Url: https://codereview.webrtc.org/2527113002
Cr-Commit-Position: refs/heads/master@{#15316}

[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/rtcstats_integrationtest.cc
[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/rtcstatscollector.cc
[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/rtcstatscollector_unittest.cc
[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/stats/rtcstats.h
[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/api/stats/rtcstats_objects.h
[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/stats/rtcstats.cc
[modify] https://crrev.com/0583b286e44b6f6d4d5c5185ed94b60f37aad598/webrtc/stats/rtcstats_unittest.cc

Comment 10 by anatolid@chromium.org, Jan 12 2017 

Is there any more work expected to be done here?

Comment 11 by hbos@chromium.org, Jan 12 2017

Status: Verified (was: Started)
This is done.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d28adf3696a330580b5fb705531322ca4f9f3297

commit d28adf3696a330580b5fb705531322ca4f9f3297
Author: hbos <hbos@chromium.org>
Date: Mon Jan 16 12:56:26 2017

RTCPeerConnection.getStats whitelist updated due to recent spec changes.

RTCRTPStreamStats.mediaTrackId renamed trackId: https://github.com/w3c/webrtc-stats/issues/113#issuecomment-271548836
RTCMediaStreamTrackStats.kind added: https://github.com/w3c/webrtc-stats/pull/127
RTCPeerConnectionStats.dataChannels[Opened/Closed/Requested/Accepted] added: https://github.com/w3c/webrtc-stats/pull/125/files
RTCTransportStats.activeConnection replaced by dtlsState: https://github.com/w3c/webrtc-stats/pull/122/files

BUG= chromium:657854 ,  chromium:659137 ,  chromium:679741 ,  chromium:653873 ,  chromium:627816 

Review-Url: https://codereview.chromium.org/2621733004
Cr-Commit-Position: refs/heads/master@{#443879}

[modify] https://crrev.com/d28adf3696a330580b5fb705531322ca4f9f3297/chrome/test/data/webrtc/peerconnection_getstats.js
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6398f107d8df0d71f9c989ea1b73630136b580f3

commit 6398f107d8df0d71f9c989ea1b73630136b580f3
Author: hbos <hbos@chromium.org>
Date: Thu Feb 02 17:36:17 2017

RTCPeerConnection.getStats whitelist updated.

Add type 'any' to be used if a member is about to change type so that
both old and new type is valid.

Change ssrc to 'any' and add a TODO to change it to 'number'.

Remove old members from whitelist now that the changes have been made
and rolled in.

BUG=webrtc:7065, webrtc:7066, webrtc:7064,  chromium:653873 

Review-Url: https://codereview.chromium.org/2670053003
Cr-Commit-Position: refs/heads/master@{#447789}

[modify] https://crrev.com/6398f107d8df0d71f9c989ea1b73630136b580f3/chrome/test/data/webrtc/peerconnection_getstats.js
►

Sign in to add a comment