This is a first step towards audio service.
Split in two bugs?
Not sure why it's still on me?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b3d6f66fdad637857837975a6146212b0bb4ebc commit 4b3d6f66fdad637857837975a6146212b0bb4ebc Author: Max Morin <maxmorin@chromium.org> Date: Wed Oct 25 14:19:31 2017 Add a browser-side mojo audio input stream impl. Mostly copied from MojoAudioOutputStream. There is no factory for this class yet. BUG= 653871 Change-Id: I39a8769b718a0c57a3a779985b5aee4be294216a Reviewed-on: https://chromium-review.googlesource.com/730503 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#511444} [modify] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/BUILD.gn [modify] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/interfaces/BUILD.gn [add] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/interfaces/audio_input_stream.mojom [modify] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/services/BUILD.gn [add] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/services/mojo_audio_input_stream.cc [add] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/services/mojo_audio_input_stream.h [add] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/services/mojo_audio_input_stream_unittest.cc [modify] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/services/mojo_audio_output_stream.cc [modify] https://crrev.com/4b3d6f66fdad637857837975a6146212b0bb4ebc/media/mojo/services/mojo_audio_output_stream_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f commit ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f Author: Max Morin <maxmorin@chromium.org> Date: Wed Dec 06 11:33:04 2017 Make MojoAudioInputStream share read only memory. This includes making SharedMemory::GetReadOnlyHandle() const. Getting a handle with write permissions is currently const, so it makes no sense at all that getting a handle with read only permissions is not const :). Bug: 653871 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie98fde38535f5ffe0ae51949ae043c38c9791eb8 Reviewed-on: https://chromium-review.googlesource.com/806655 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#522064} [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/base/memory/shared_memory.h [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/base/memory/shared_memory_fuchsia.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/base/memory/shared_memory_mac.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/base/memory/shared_memory_nacl.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/base/memory/shared_memory_posix.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/base/memory/shared_memory_win.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/content/browser/renderer_host/media/audio_input_sync_writer.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/content/renderer/media/mojo_audio_input_ipc_unittest.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/audio/audio_device_thread.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/audio/audio_device_thread.h [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/audio/audio_input_device.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/audio/audio_output_device.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/base/audio_bus.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/base/audio_bus.h [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/mojo/services/mojo_audio_input_stream.cc [modify] https://crrev.com/ef213bdafd36718f564bfe7fe6efb3d9fd18ad2f/media/mojo/services/mojo_audio_input_stream_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b commit f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b Author: Max Morin <maxmorin@chromium.org> Date: Wed Dec 06 12:59:34 2017 Change AudioLog in delegates to raw pointer. Also rearrange parameter ordering in AIDI::Create. Both of these changes are to simplify callback binding for the new factory in https://chromium-review.googlesource.com/c/chromium/src/+/771196. Bug: 653871 Change-Id: I825b519e664c0e4cafecff85f199d3bc145c8fda Reviewed-on: https://chromium-review.googlesource.com/795970 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#522074} [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_input_delegate_impl.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_input_delegate_impl.h [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_input_renderer_host.h [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_output_delegate_impl.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_output_delegate_impl.h [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_renderer_host.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/audio_renderer_host.h [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.cc [modify] https://crrev.com/f4e0ea1dfde5b9d8dcdf71554785f20d54ced63b/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70fb1d6b1a660690033b5b181fbd4b2ca529a122 commit 70fb1d6b1a660690033b5b181fbd4b2ca529a122 Author: Max Morin <maxmorin@chromium.org> Date: Thu Dec 14 07:52:29 2017 Add factory for MojoAudioInputStream. RenderFrameAudioInputStreamFactory is intended to be exposed to the renderer. The AudioInputStreamHandle class is introduced to bundle a stream and its client. When moving to the audio service, the AudioInputStreamHandle will stay in content/ while the MojoAudioInputStream will be in the audio service. This diagram shows how we want the stream setup to look in the near future: https://docs.google.com/drawings/d/1pSYEqiG46N0OD6rJhfTpohyn2ZkSWsp3ZIHe2PDh0Us/edit Bug: 653871 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4ff52dbc4797b595e3dd791d1bafa9325a0af9d2 Reviewed-on: https://chromium-review.googlesource.com/771196 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524020} [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/BUILD.gn [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/audio_input_stream_handle.cc [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/audio_input_stream_handle.h [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/audio_input_stream_handle_unittest.cc [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.h [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/render_frame_audio_output_stream_factory.cc [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/render_frame_audio_output_stream_factory.h [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/common/BUILD.gn [add] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/common/media/renderer_audio_input_stream_factory.mojom [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/common/media/renderer_audio_output_stream_factory.mojom [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/renderer/media/audio_ipc_factory_unittest.cc [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/renderer/media/mojo_audio_output_ipc.cc [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/renderer/media/mojo_audio_output_ipc_unittest.cc [modify] https://crrev.com/70fb1d6b1a660690033b5b181fbd4b2ca529a122/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/068c786ea56aff47173f8c3e1f16329bb0effd6d commit 068c786ea56aff47173f8c3e1f16329bb0effd6d Author: Max Morin <maxmorin@chromium.org> Date: Thu Dec 14 14:13:33 2017 Make MojoAudioInputIPC a FactoryClient. After https://chromium-review.googlesource.com/c/chromium/src/+/771196, the interface MojoAudioInputIPC should conform to is slightly different than originally expected. This CL updates it to fit the new interface. Bug: 653871 Change-Id: Iea76d3033087742a93943fad94a8875c12459236 Reviewed-on: https://chromium-review.googlesource.com/806222 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#524056} [modify] https://crrev.com/068c786ea56aff47173f8c3e1f16329bb0effd6d/content/renderer/media/mojo_audio_input_ipc.cc [modify] https://crrev.com/068c786ea56aff47173f8c3e1f16329bb0effd6d/content/renderer/media/mojo_audio_input_ipc.h [modify] https://crrev.com/068c786ea56aff47173f8c3e1f16329bb0effd6d/content/renderer/media/mojo_audio_input_ipc_unittest.cc [modify] https://crrev.com/068c786ea56aff47173f8c3e1f16329bb0effd6d/content/renderer/media/mojo_audio_output_ipc.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d464a42a785b72f46d8e61b418dfdc21e916702 commit 3d464a42a785b72f46d8e61b418dfdc21e916702 Author: Max Morin <maxmorin@chromium.org> Date: Mon Jan 15 11:17:00 2018 Add flag/glue for mojo audio input stream factories. This exposes the newly added RendererAudioInputStreamFactory in frame hosts, and enables the renderer to create streams using this factory. The AudioInputIPCFactory class will choose IPC implementation based on the new "UseMojoAudioInputStreamFactory" flag. Also rename AudioIPCFactory->AudioOutputIPCFactory to avoid confusion. Bug: 653871 Change-Id: I3590ee2fab8b3a65ba00c659da9b33b81f39b2a2 Reviewed-on: https://chromium-review.googlesource.com/800615 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#529247} [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.h [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/public/common/content_features.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/public/common/content_features.h [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/BUILD.gn [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/media/audio_device_factory.cc [add] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/media/audio_input_ipc_factory.cc [add] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/media/audio_input_ipc_factory.h [rename] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/media/audio_output_ipc_factory.cc [rename] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/media/audio_output_ipc_factory.h [rename] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/media/audio_output_ipc_factory_unittest.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/pepper/pepper_platform_audio_input.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/pepper/pepper_platform_audio_output.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/pepper/pepper_platform_audio_output_dev.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/render_frame_impl.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/render_frame_impl.h [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/render_thread_impl.cc [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/renderer/render_thread_impl.h [modify] https://crrev.com/3d464a42a785b72f46d8e61b418dfdc21e916702/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1d09725275d8bf7607a411c764bff503110a149 commit e1d09725275d8bf7607a411c764bff503110a149 Author: Max Morin <maxmorin@chromium.org> Date: Tue Jan 23 14:04:06 2018 Switch audio input IPC to mojo. Legacy code will be removed in a future CL Bug: 653871 Change-Id: If2ece51d217a961f5a9a012621f88101be2a7af7 Reviewed-on: https://chromium-review.googlesource.com/806224 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531224} [modify] https://crrev.com/e1d09725275d8bf7607a411c764bff503110a149/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c38c289ce805191472a389f4798e56e646ff608 commit 2c38c289ce805191472a389f4798e56e646ff608 Author: Max Morin <maxmorin@chromium.org> Date: Tue Apr 17 07:01:42 2018 Remove audio_messages.h and related code. The legacy IPC audio messages have been replaced by mojo interfaces. This CL also removes related experiment configs. Comments are also updated (diff against PS1), except for comments in audio_mirroring_manager.h, since that one is soon to be removed. A more comprehensive md file should be written when the audio service situation has settled a bit. Bug: 653871 ,721732 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia67ffe766802adec971b41dfc0593be61909175a Reviewed-on: https://chromium-review.googlesource.com/1010424 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551268} [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/BUILD.gn [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/renderer_host/media/audio_input_device_manager.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/browser/renderer_host/media/audio_input_renderer_host.cc [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/browser/renderer_host/media/audio_input_renderer_host.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/browser/renderer_host/media/audio_renderer_host.cc [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/browser/renderer_host/media/audio_renderer_host.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/browser/renderer_host/media/audio_renderer_host_unittest.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/common/BUILD.gn [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/common/content_message_generator.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/common/media/audio_messages.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/public/common/content_features.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/public/common/content_features.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/BUILD.gn [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/media/audio_input_ipc_factory.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/media/audio_input_ipc_factory.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/renderer/media/audio_input_message_filter.cc [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/renderer/media/audio_input_message_filter.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/renderer/media/audio_message_filter.cc [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/renderer/media/audio_message_filter.h [delete] https://crrev.com/f020de9f4788d81c05f0a4947dabfdb777604cc6/content/renderer/media/audio_message_filter_unittest.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/media/audio_output_ipc_factory.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/media/audio_output_ipc_factory.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/media/audio_output_ipc_factory_unittest.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/render_frame_impl.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/render_thread_impl.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/renderer/render_thread_impl.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/content/test/BUILD.gn [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/media/audio/audio_input_controller.cc [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/media/audio/audio_input_controller.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/media/audio/audio_input_device.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/media/audio/audio_input_ipc.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/media/audio/audio_output_device.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/media/audio/audio_output_ipc.h [modify] https://crrev.com/2c38c289ce805191472a389f4798e56e646ff608/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f506af593a23641ee76b07912cd26c7c0e1be591 commit f506af593a23641ee76b07912cd26c7c0e1be591 Author: Max Morin <maxmorin@chromium.org> Date: Tue Apr 17 12:23:32 2018 Remove plumbing of Origin to AudioOutputDevice. The Origin is now looked up in the browser, so passing the origin is unnecessary. This is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/1010424. Also fix some lint. Bug: 653871 ,721732 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I681dd754d71e1fe87e94f514428e1b3bea7aa736 Reviewed-on: https://chromium-review.googlesource.com/1012114 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#551301} [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/public/renderer/media_stream_audio_renderer.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/public/renderer/media_stream_renderer_factory.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_device_factory.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_device_factory.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_output_ipc_factory_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_mixer_manager.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_mixer_manager.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_mixer_manager_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_sink_cache.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_sink_cache_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_sink_cache_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/audio_renderer_sink_cache_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/media_factory.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/mock_audio_device_factory.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/mojo_audio_output_ipc.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/mojo_audio_output_ipc.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/mojo_audio_output_ipc_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/renderer_webaudiodevice_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/renderer_webaudiodevice_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/renderer_webaudiodevice_impl_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/media_stream_renderer_factory_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/media_stream_renderer_factory_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/track_audio_renderer.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/track_audio_renderer.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/webmediaplayer_ms.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/webmediaplayer_ms.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/stream/webmediaplayer_ms_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/webrtc/webrtc_audio_renderer.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/webrtc/webrtc_audio_renderer.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media/webrtc_local_audio_source_provider.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/pepper/pepper_audio_output_host.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/pepper/pepper_platform_audio_output_dev.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/pepper/pepper_platform_audio_output_dev.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/render_frame_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/render_frame_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/shell/renderer/layout_test/test_media_stream_renderer_factory.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/shell/test_runner/web_frame_test_client.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/shell/test_runner/web_frame_test_client.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/shell/test_runner/web_frame_test_proxy.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/content/test/renderer_audio_output_stream_factory_context_impl_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/audio/audio_output_device.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/audio/audio_output_device.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/audio/audio_output_device_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/audio/audio_output_ipc.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/audio/null_audio_sink.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/audio/null_audio_sink.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/audio_renderer_mixer_input.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/audio_renderer_mixer_input.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/audio_renderer_mixer_input_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/audio_renderer_mixer_pool.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/audio_renderer_mixer_unittest.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/audio_renderer_sink.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/mock_audio_renderer_sink.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/base/mock_audio_renderer_sink.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/blink/webaudiosourceprovider_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/blink/webaudiosourceprovider_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/media/blink/webmediaplayer_impl.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/public/platform/platform.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/public/platform/web_media_player.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/public/web/web_frame_client.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/modules/audio_output_devices/audio_output_device_client_impl.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/modules/webaudio/audio_context_test.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/modules/webaudio/base_audio_context_test.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/platform/audio/audio_destination.cc [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/platform/audio/audio_destination.h [modify] https://crrev.com/f506af593a23641ee76b07912cd26c7c0e1be591/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
Comment 1 by olka@chromium.org
, Oct 7 2016