New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653869 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 638807



Sign in to add a comment

Polish of the media controls menu style

Project Member Reported by mlamouri@chromium.org, Oct 7 2016

Issue description

Changing from:
    border-radius: 2px;
    box-shadow: 0 8px 10px 1px rgba(0, 0, 0, 0.14),
                0 3px 14px 2px rgba(0, 0, 0, 0.12),
                0 5px 5px -3px rgba(0, 0, 0, 0.4);
to:
    border-radius: 1px;
    box-shadow: 0 8px 20px 1px rgba(0, 0, 0, 0.14),
                0 3px 28px 2px rgba(0, 0, 0, 0.12),
                0 5px 10px -3px rgba(0, 0, 0, 0.4);

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f77595f33b4ad570f991a65f7ca8fc920d405f68

commit f77595f33b4ad570f991a65f7ca8fc920d405f68
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Oct 10 18:39:44 2016

Minor polish on the media controls menu style.

It reduces slightly the border-radius and increses the box-shadow.

BUG= 653869 
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2400193002
Cr-Commit-Position: refs/heads/master@{#424197}

[modify] https://crrev.com/f77595f33b4ad570f991a65f7ca8fc920d405f68/third_party/WebKit/Source/core/css/mediaControlsNew.css

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 11 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 4 by gov...@chromium.org, Oct 11 2016

Please merge your change to M55 branch 2883 before 5:00 PM PT today (latest before 5:00 PM PT tomorrow, Wednesday (10/12/16)) so we can pick it up for this week M55 Dev release.Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3cbca33bd6156945dcbd0bd4e69d53155a5f994

commit a3cbca33bd6156945dcbd0bd4e69d53155a5f994
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Oct 11 17:55:56 2016

Minor polish on the media controls menu style.

It reduces slightly the border-radius and increses the box-shadow.

BUG= 653869 
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2400193002
Cr-Commit-Position: refs/heads/master@{#424197}
(cherry picked from commit f77595f33b4ad570f991a65f7ca8fc920d405f68)

Review URL: https://codereview.chromium.org/2409253002 .

Cr-Commit-Position: refs/branch-heads/2883@{#36}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/a3cbca33bd6156945dcbd0bd4e69d53155a5f994/third_party/WebKit/Source/core/css/mediaControlsNew.css

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3cbca33bd6156945dcbd0bd4e69d53155a5f994

commit a3cbca33bd6156945dcbd0bd4e69d53155a5f994
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Oct 11 17:55:56 2016

Minor polish on the media controls menu style.

It reduces slightly the border-radius and increses the box-shadow.

BUG= 653869 
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2400193002
Cr-Commit-Position: refs/heads/master@{#424197}
(cherry picked from commit f77595f33b4ad570f991a65f7ca8fc920d405f68)

Review URL: https://codereview.chromium.org/2409253002 .

Cr-Commit-Position: refs/branch-heads/2883@{#36}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/a3cbca33bd6156945dcbd0bd4e69d53155a5f994/third_party/WebKit/Source/core/css/mediaControlsNew.css

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment