New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653862 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Notifications perform their onclick action on mouse down, not mouse up like other buttons

Project Member Reported by sdy@chromium.org, Oct 7 2016

Issue description

Version: 55.0.2882.0
OS: macOS

What steps will reproduce the problem?
(1) Make a website show a notification (`var n = new Notification('foo')`)
(2) Add a click handler to the notification (`n.onclick = e => { console.log('clicked'); };`)
(3) Click the notification.

What is the expected output?
The click handler is called only when I release the mouse button, so that I have a chance to change my mind by moving the cursor away from the notification before releasing.

What do you see instead?
The click handler fires as soon as I press down the mouse button.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e006b13348406840e21deaa6b77e7efb5862e960

commit e006b13348406840e21deaa6b77e7efb5862e960
Author: sdy <sdy@chromium.org>
Date: Fri Oct 07 16:27:17 2016

[Mac] Activate notifications on mouse *up*.

Buttons respond on mouse up. This is nice because it gives the user a
chance to change their mind by moving the mouse away from the button
before releasing.

This makes notifications behave the same way.

BUG= 653862 

Review-Url: https://codereview.chromium.org/2400033003
Cr-Commit-Position: refs/heads/master@{#423877}

[modify] https://crrev.com/e006b13348406840e21deaa6b77e7efb5862e960/ui/message_center/cocoa/notification_controller.mm

Comment 2 by sdy@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

Comment 3 by sdy@chromium.org, Dec 16 2016

Labels: -Proj-MacQualityOfLife Hotlist-MacQualityOfLife
Labels: -Hotlist-MacQualityOfLife Hotlist-PlatformExcellence
Migrating to more generic platform label, so that it can be applied to other platforms (i.e. I love the idea).

Sign in to add a comment