Separate IPC logistics from business logic and clean up the code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b2e94b644dc909c077430e3ae6fcec341ccf5c6 commit 6b2e94b644dc909c077430e3ae6fcec341ccf5c6 Author: olka <olka@chromium.org> Date: Fri Oct 14 16:49:57 2016 Audio input debug recording refactoring to reduce thread hops and simplify object ownership AudioInputRendererHost has to do too many thread hops to handle debug recording enable/disable. This CL: * Passes recording file management to AudioInputDebugWriter, which takes care of file operations executed on the correct thread. Now it can be deleted on any thread, and thus: * AudioInputDebugWriter ownership is passed to AudioInputController, AIRH does not care about its lifetime any more. * AudioEntry does not store audio parameters (required for debug recording only) any more. AudioInputDebugWriter holds them, and recording is controlled with Start()/Stop() instead of creation/deletion of the writer. See the diagram: https://drive.google.com/open?id=0Bw1QgdA2sQtMbDFXeUdvUnZzTE0. Red arrows are going away, blue arrows remain. So, now AIRH only (1) communicates with UI thread to get debug recording settings and (2) issues enable/disable recording calls for each registered AudioInputController. BUG= 586431 , 653861 TESTING=updated unit tests + manual debug recording Review-Url: https://codereview.chromium.org/2390153006 Cr-Commit-Position: refs/heads/master@{#425360} [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/content/browser/renderer_host/media/audio_input_debug_writer.cc [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/content/browser/renderer_host/media/audio_input_debug_writer.h [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/content/browser/renderer_host/media/audio_input_debug_writer_unittest.cc [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/media/audio/audio_input_controller.cc [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/media/audio/audio_input_controller.h [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/media/audio/audio_input_writer.h [modify] https://crrev.com/6b2e94b644dc909c077430e3ae6fcec341ccf5c6/media/audio/test_audio_input_controller_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69cdc9514c495f7612463039885efeb8000d5184 commit 69cdc9514c495f7612463039885efeb8000d5184 Author: maxmorin <maxmorin@chromium.org> Date: Wed Dec 14 18:29:16 2016 Unit tests of AudioInputRendererHost. Some cleanups. This change enables refactoring of AudioInputRendererHost and surrounding code. In this CL: * Cleaned up instances of handling DCHECK errors in AudioInputRendererHost, see style guide https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#CHECK_DCHECK_and-NOTREACHED * Sanitize volume in AudioInputRendererHost::OnSetVolume. * Generalized AudioInputController::Factory interface and made sure the factory is used for all the factory methods of AudioInputController. * Removed skipping authorization check for fake devices in AudioInputRendendererHost * Removed unused weak_factory member of AudioInputRendererHost. * Added unit tests for AudioInputRendererHost. BUG= 653861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2531333005 Cr-Commit-Position: refs/heads/master@{#438539} [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/content/browser/bad_message.h [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/content/browser/renderer_host/media/audio_input_renderer_host.h [add] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/content/renderer/media/audio_input_message_filter.cc [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/content/test/BUILD.gn [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/media/audio/audio_input_controller.cc [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/media/audio/audio_input_controller.h [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/media/audio/test_audio_input_controller_factory.cc [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/media/audio/test_audio_input_controller_factory.h [modify] https://crrev.com/69cdc9514c495f7612463039885efeb8000d5184/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72 commit e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72 Author: Max Morin <maxmorin@chromium.org> Date: Tue Jun 13 07:14:46 2017 Harmonize AudioInputSyncWriter w/ output. This CL rearranges ownership of IPC primitives to be similar to how it works on the output side of things. AudioInputSyncWriter::Init is removed in in favour of a Create method, which returns nullptr on failure. The logic for calculating the shared memory size is moved from AudioInputRendererHost to AudioInputSyncWriter::Create. Unnecessary friendship and protected member variable are removed from AudioInputSyncWriter. Some counters were also changed to size_t to avoid unnecessary casting to and from int. Drive-by: Fixing a rare case were AudioInputRendererHost could leak a shared memory handle. BUG= 653861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idb4e717b6d2a757617627e2c68d29b1b4bcf75d3 Reviewed-on: https://chromium-review.googlesource.com/524083 Reviewed-by: Henrik Grunell <grunell@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478919} [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_input_renderer_host.h [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_input_sync_writer.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_input_sync_writer.h [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_output_delegate_impl.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_output_delegate_impl.h [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_renderer_host.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_renderer_host.h [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_sync_reader.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/content/browser/renderer_host/media/audio_sync_reader.h [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/media/audio/audio_output_delegate.h [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/media/mojo/services/mojo_audio_output_stream.cc [modify] https://crrev.com/e9d3dd5d417aadf569e420fd6a9b6bb2b5dafd72/media/mojo/services/mojo_audio_output_stream.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/752deed34541bee5b918e583cb7328ce903b15ce commit 752deed34541bee5b918e583cb7328ce903b15ce Author: Max Morin <maxmorin@chromium.org> Date: Fri Jun 16 11:06:49 2017 Convert some audio input code to OnceCallback. I'll be doing some work around AudioInputController, so I figured I would convert it and some surrounding code to OnceCallback in a separate CL first to avoid noise in future CLs. BUG= 653861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I211ddb2016995b3303d88cb7da8b50e2797e5b51 Reviewed-on: https://chromium-review.googlesource.com/527074 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#480015} [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/content/browser/renderer_host/media/audio_input_device_manager.cc [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/content/browser/renderer_host/media/audio_input_device_manager.h [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/media/audio/audio_input_controller.cc [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/media/audio/audio_input_controller.h [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/media/audio/audio_input_controller_unittest.cc [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/media/audio/test_audio_input_controller_factory.cc [modify] https://crrev.com/752deed34541bee5b918e583cb7328ce903b15ce/media/audio/test_audio_input_controller_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36a53140a9f2a92f970dbce60216e6cc8ae25676 commit 36a53140a9f2a92f970dbce60216e6cc8ae25676 Author: Max Morin <maxmorin@chromium.org> Date: Fri Aug 25 10:04:54 2017 Use RAII class to manage keyboard mic registration. This helps making sure a registration isn't "lost" in cases such as "RegisterKeyboardMicStream(base::BindOnce(&CreateStream, weak_this))", which is approximately what we will have when switching to a per-frame input stream factory. It also obviates the need to remember to call "Unregister..." for each different case, which is otherwise bug-prone. Bug: 653861 Change-Id: I50b89c5393f368d22c0c392070f0b7d07f45bffe Reviewed-on: https://chromium-review.googlesource.com/632687 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#497369} [modify] https://crrev.com/36a53140a9f2a92f970dbce60216e6cc8ae25676/content/browser/renderer_host/media/audio_input_device_manager.cc [modify] https://crrev.com/36a53140a9f2a92f970dbce60216e6cc8ae25676/content/browser/renderer_host/media/audio_input_device_manager.h [modify] https://crrev.com/36a53140a9f2a92f970dbce60216e6cc8ae25676/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/36a53140a9f2a92f970dbce60216e6cc8ae25676/content/browser/renderer_host/media/audio_input_renderer_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30996fb5a5739c4ac9e5b1091027c5c8acceb65c commit 30996fb5a5739c4ac9e5b1091027c5c8acceb65c Author: Max Morin <maxmorin@chromium.org> Date: Fri Sep 01 13:28:35 2017 Remove some useless parameters from audio_messages.h. |segment_count| is passed from the renderer in the AudioInputHostMsg_CreateStream_Config, and just echoed back to the renderer. This is completely unnecessary. |length| is already known to the renderer, and thus it doesn't need be passed from the browser. Convenience functions ComputeAudio{In,Out}putBufferSize are introduced to safely compute the required size of the shared memory for given audio parameters. BUG= 653861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id192d16001c873867fedba52be9b52c2672890ab Reviewed-on: https://chromium-review.googlesource.com/623089 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#499179} [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_input_sync_writer.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_renderer_host.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_renderer_host_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_sync_reader.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/browser/renderer_host/media/audio_sync_reader.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/common/media/audio_messages.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/audio_input_message_filter.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/audio_input_message_filter.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/audio_ipc_factory_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/audio_message_filter.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/audio_message_filter.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/audio_message_filter_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/mojo_audio_output_ipc.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/mojo_audio_output_ipc_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/speech_recognition_audio_sink.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/media/speech_recognition_audio_sink_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/pepper/pepper_platform_audio_input.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/pepper/pepper_platform_audio_input.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/pepper/pepper_platform_audio_output.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/pepper/pepper_platform_audio_output.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/pepper/pepper_platform_audio_output_dev.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/content/renderer/pepper/pepper_platform_audio_output_dev.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_device_thread.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_device_thread.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_input_device.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_input_device.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_input_device_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_input_ipc.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_output_device.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_output_device.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_output_device_unittest.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/audio/audio_output_ipc.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/base/audio_parameters.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/media/base/audio_parameters.h [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/ppapi/proxy/audio_input_resource.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/ppapi/proxy/audio_output_resource.cc [modify] https://crrev.com/30996fb5a5739c4ac9e5b1091027c5c8acceb65c/ppapi/shared_impl/ppb_audio_shared.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbcab2905dec3439ca69d136ff7e6648e4a00feb commit fbcab2905dec3439ca69d136ff7e6648e4a00feb Author: Max Morin <maxmorin@chromium.org> Date: Fri Oct 20 09:57:12 2017 Introduce AudioInputDelegate. AudioInputDelegate handles IPC messages for a single audio input stream, and is introduced in this CL to separate the actual IPC layer from the stream logic. This will allow the current legacy IPC layer to be exchanged for a Mojo IPC layer in the future. AudioInputDelegate is similar to AudioOutputDelegate, and some design choices has been made for consistency with it. Suggested reading order: audio_input_delegate.h, audio_input_delegate_impl{.h,.cc,_unittest.cc}, audio_input_renderer_host.{h,cc}. The rest of the files are simple interface changes. Bug: 653861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icfa0f89ae85789bb259ada2a8dc5a8b85651d807 Reviewed-on: https://chromium-review.googlesource.com/719737 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510393} [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/BUILD.gn [add] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_input_delegate_impl.cc [add] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_input_delegate_impl.h [add] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_input_renderer_host.h [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_output_delegate_impl.cc [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/audio_output_delegate_impl.h [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/content/test/BUILD.gn [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/media/audio/BUILD.gn [add] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/media/audio/audio_input_delegate.cc [add] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/media/audio/audio_input_delegate.h [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/media/audio/audio_output_delegate.cc [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/media/audio/audio_output_delegate.h [modify] https://crrev.com/fbcab2905dec3439ca69d136ff7e6648e4a00feb/media/mojo/services/mojo_audio_output_stream_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f303b121393f950831f6cbb33d6387fdfea89659 commit f303b121393f950831f6cbb33d6387fdfea89659 Author: Max Morin <maxmorin@chromium.org> Date: Mon Nov 13 16:19:44 2017 Move keyboard stream ChromeOS ifdefs into AIDM. Adding #if defined(OS_CHROMEOS) everywhere in the new mojo input stream factory is a pain (and ugly), so add a dummy KeyboardMicRegistration for other platforms and put platform-checking macros in AudioInputDeviceManager instead. Bug: 653861 Change-Id: If538fb6452f048fd6175a46e0e39dda3a2adfe5e Reviewed-on: https://chromium-review.googlesource.com/757376 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515953} [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_delegate_impl.cc [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_delegate_impl.h [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_device_manager.cc [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_device_manager.h [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_renderer_host.cc [modify] https://crrev.com/f303b121393f950831f6cbb33d6387fdfea89659/content/browser/renderer_host/media/audio_input_renderer_host.h
This seems done enough.
Comment 1 by olka@chromium.org
, Oct 7 2016