New issue
Advanced search Search tips

Issue 653859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 360762



Sign in to add a comment

imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html fails only on WPTServe

Project Member Reported by tkent@chromium.org, Oct 7 2016

Issue description

All asserts are PASS, but there are many other validation message dumps.

https://codereview.chromium.org/2385063002/ doesn't work well with WPTServe.

 

Comment 1 by tkent@chromium.org, Oct 7 2016

Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ae64988afdf04a385075df956ce538b56f0754

commit 16ae64988afdf04a385075df956ce538b56f0754
Author: tkent <tkent@chromium.org>
Date: Fri Oct 07 12:50:47 2016

Update WPTServeExpectations.

This CL has no behaivor changes.

BUG= 653859 ,  508728 ,  627008 ,  508725 
TBR=kojii@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2399363002
Cr-Commit-Position: refs/heads/master@{#423841}

[modify] https://crrev.com/16ae64988afdf04a385075df956ce538b56f0754/third_party/WebKit/LayoutTests/WPTServeExpectations

Comment 3 by tkent@chromium.org, Oct 13 2016

Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d37f3cfb0ba4ed0a4ad4253b39a2c8122306862f

commit d37f3cfb0ba4ed0a4ad4253b39a2c8122306862f
Author: tkent <tkent@chromium.org>
Date: Thu Oct 13 03:52:42 2016

test_runner: Suppress validation messages on WPTServe too.

Form validation messages are suppressed for web-platform-tests since
[1]. However is_web_platform_tests_mode() returned false for tests served from
WPTServe.

[1] https://codereview.chromium.org/2385063002/

BUG= 653859 

Review-Url: https://codereview.chromium.org/2406363005
Cr-Commit-Position: refs/heads/master@{#424951}

[modify] https://crrev.com/d37f3cfb0ba4ed0a4ad4253b39a2c8122306862f/components/test_runner/test_interfaces.cc
[modify] https://crrev.com/d37f3cfb0ba4ed0a4ad4253b39a2c8122306862f/third_party/WebKit/LayoutTests/WPTServeExpectations

Comment 5 by tkent@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

Sign in to add a comment