New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653836 link

Starred by 1 user
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ tkonch...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Focus is lost after pressing 'Esc' key on chrome://md-settings/manageProfile page.

Reported by rk...@etouch.net, Oct 7 2016 
Chrome Version: 55.0.2883.0 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} (32/64-bit)
OS:Windows(7,8,8.1,10),Linux(14.04 LTS),Mac(10.10.5)(10.11.5)

What steps will reproduce the problem?
(1) Lunch chrome, navigate to chrome://md-settings/manageProfile page.
(2) Press Tab key upto focus reaches to profile icon then press esc key and observe.

Actual: Focus is lost after pressing Esc key on chrome://md-settings/manageProfile page.

Expected: Focus should not lost after pressing Esc key on chrome://md-settings/manageProfile page.

This is a regression issue, broken in 'M-55', will soon update the other info:
 
Good Build: 55.0.2868.0
bad Build: 55.0.2869.0
Focus_Actual.mp4
807 KB View Download
Focus_Expected.mp4
483 KB View Download

Comment 1 by brajkumar@chromium.org, Oct 7 2016

Cc: brajkumar@chromium.org
Labels: hasbisect-per-revision
Owner: mahmadi@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:55.0.2868.0(Revision: 420217).
Bad build: 55.0.2869.0 (Revision:420536).

You are probably looking for a change made after 420354 (known good), but no later than 420355 (first known bad).

CHANGELOG URL:
-----------------   https://chromium.googlesource.com/chromium/src/+log/f5a394b0e277189a4e7d57b68bb1ae3a0f4ee3ee..41da613e2425d5cd726390dcecdb4102315900c1

From the CL above, assigning the issue to the concern owner 

@mahmadi - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2269743002

Thanks!

Comment 2 by mahmadi@chromium.org, Oct 18 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c262d27647ccc3887bee4a9f8f6727b8d0ce474e

commit c262d27647ccc3887bee4a9f8f6727b8d0ce474e
Author: mahmadi <mahmadi@chromium.org>
Date: Tue Oct 25 00:50:53 2016

[MD Settings][People] Profile Avatar Selector won't lose focus on pressing esc

BUG= 653836 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2428083002
Cr-Commit-Position: refs/heads/master@{#427195}

[modify] https://crrev.com/c262d27647ccc3887bee4a9f8f6727b8d0ce474e/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector_grid.js

Comment 4 by mahmadi@chromium.org, Oct 25 2016

Status: Fixed (was: Started)
►

Sign in to add a comment