Regression : “No history entries found” faint text appears to be shifted downwards slightly in chrome://history.
Reported by
yfulgaon...@etouch.net,
Oct 7 2016
|
||
Issue descriptionChrome Version : 55.0.2883.0 (Official Build) 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} (32/64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) Precondition : Please sign-in to chrome using valid credentials. What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://history page and clear all history entries. 2. Go to ‘Tabs from other device’, click on ‘Actions’ iron icon and select ‘Hide for now’ option for all the ‘synced tabs’ entries. 3. Now switch between ‘Chrome history’ and ‘Tabs from other devices’ tabs and observe the faint text for both the tabs. Actual : “No history entries found” faint text appears to be shifted downwards slightly. Expected : “No history entries found” faint text should have proper positioning. (i.e same as “No synced tabs” faint text, seen in ‘Tabs from other device’) This is a regression issue broken in ‘M-55’, below is the Manual Regression and will soon update bisect info. Good build : 55.0.2862.0 Bad build : 55.0.2863.0 Change log URL : https://chromium.googlesource.com/chromium/src/+log/55.0.2862.0..55.0.2863.0?pretty=fuller&n=10000 (Unable to narrow down the range using tool as ‘sign-in’ to chrome feature is not supported on chromium builds, hence providing suspect from change log) Suspecting: r 419105 or 419101 ? from CL @tsergeant : Please help to re-assign if your change is not the cause for this issue.
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e5c2bc09cede88979793107a21d9202559eae40 commit 6e5c2bc09cede88979793107a21d9202559eae40 Author: tsergeant <tsergeant@chromium.org> Date: Wed Oct 19 14:26:30 2016 MD History: Fix minor visual inconsistencies * Remove tap highlight on synced device card titles * Adjust padding on history list so that 'no results' messages align correctly BUG= 653817 , 653782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2402913002 Cr-Commit-Position: refs/heads/master@{#426181} [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/synced_device_card.html
,
Oct 20 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tsergeant@chromium.org
, Oct 10 2016