New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653813 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Scrollbar is missing on 'http://soulwire.co.uk/experiments'

Reported by dmascare...@etouch.net, Oct 7 2016 
Chrome Version: 55.0.2883.0 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} (32/64-bit)
OS: Windows (7,8,10), Linux (14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and navigate to http://soulwire.co.uk/experiments
2. Observe at the bottom of the page.

Actual: Scrollbar is missing.
Expected: Scrollbar should be seen.

This is regression issue, broken in 'M 55' and below is manual bisect info:

Good build:55.0.2842.0
Bad build: 55.0.2843.0

Note: Issue is not seen on Mac OS.
Actual_soulwire.png
1.1 MB View Download
Exp_soulwire.png
1.0 MB View Download

Comment 1 by tkonch...@chromium.org, Oct 7 2016

Components: Blink>Paint>Invalidation
Labels: ReleaseBlock-Stable
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good build:55.0.2842.0 (revision : 414942 )
Bad build:55.0.2843.0 (revision : 414958 )

You are probably looking for a change made after 414950 (known good), but no later than 414951 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/fb8a6e63a1a18ae7fced2c373fdc06ab5dc6786d..537724421c0f5d046e56fb0eba001da3bcea0613

Adding RB label as this is  a recent regression

chrishtr@ Please reassign if this is not related to your change.

Comment 2 by tkonch...@chromium.org, Oct 7 2016

Labels: hasbisect-per-revision

Comment 3 by chrishtr@chromium.org, Oct 12 2016

Status: Started (was: Assigned)

Comment 5 by chrishtr@chromium.org, Oct 12 2016

Labels: Merge-Request-55

Comment 7 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 8 by mummare...@chromium.org, Oct 13 2016 

Tested on win7 (64 bit) with latest canary 56.0.2889.0 and looks issue is fixed. please find the attached screenshot.
Scrollbar.png
1.0 MB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 14 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f29477505735de47ee0cc1e170d1dd962dca3d

commit 67f29477505735de47ee0cc1e170d1dd962dca3d
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Oct 14 17:52:40 2016

Account for non-composited scroll offset of scrollbars.

We had previously done this for other code paths, but forgot about this one.

BUG= 653813 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2411193002
Cr-Commit-Position: refs/heads/master@{#424800}
(cherry picked from commit 3c806bffd03ce8d303f8ba210e075515472e39d1)

Review URL: https://codereview.chromium.org/2421903002 .

Cr-Commit-Position: refs/branch-heads/2883@{#111}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-yet-scrolled-with-custom-scrollbar-expected.txt
[add] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-yet-scrolled-with-custom-scrollbar.html
[modify] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

Comment 10 by chrishtr@chromium.org, Oct 14 2016

Status: Fixed (was: Started)

Comment 11 by brajkumar@chromium.org, Oct 18 2016

Labels: TE-Verified-M55 TE-Verified-55.0.2883.18
Verified the issue on Windows-10 and Ubuntu 14.04 using chrome latest Dev M55-55.0.2883.18. Observed the scroll bar is visible and able to scroll with no issue. Hence adding TE-Verified label.
653813.PNG
2.4 MB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f29477505735de47ee0cc1e170d1dd962dca3d

commit 67f29477505735de47ee0cc1e170d1dd962dca3d
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Oct 14 17:52:40 2016

Account for non-composited scroll offset of scrollbars.

We had previously done this for other code paths, but forgot about this one.

BUG= 653813 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2411193002
Cr-Commit-Position: refs/heads/master@{#424800}
(cherry picked from commit 3c806bffd03ce8d303f8ba210e075515472e39d1)

Review URL: https://codereview.chromium.org/2421903002 .

Cr-Commit-Position: refs/branch-heads/2883@{#111}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-yet-scrolled-with-custom-scrollbar-expected.txt
[add] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-yet-scrolled-with-custom-scrollbar.html
[modify] https://crrev.com/67f29477505735de47ee0cc1e170d1dd962dca3d/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

Comment 13 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment