New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653809 link

Starred by 1 user
Status: Fixed
Owner:
█ bauerb@chromium.org
Not on Chrome anymore
Closed: Oct 2016
Cc:
█ ian...@chromium.org
█ aber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

ChromeBackupIntegrationTest.testSimpleRestore failing on bots without GMSCore

Project Member Reported by bauerb@chromium.org, Oct 7 2016 
Since https://codereview.chromium.org/2399183002, ChromeBackupIntegrationTest.testSimpleRestore has been failing on Lollipop Phone (https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/7178):

[FAIL] org.chromium.chrome.browser.ChromeBackupIntegrationTest#testSimpleRestore:
junit.framework.AssertionFailedError
  at org.chromium.chrome.browser.ChromeBackupIntegrationTest.testSimpleRestore(ChromeBackupIntegrationTest.java:134)
  at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
  at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
  at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
  at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
  at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
  at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
  at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
  at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

The test checks whether restoring signs the user back in, which does not work if GMSCore is missing (which appears to be the case on that bot?).

We should probably skip that test if GMSCore is not available. Is there an existing annotation that can be used for that?
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad301d759bd710dc6223ab049e4618a21b944f12

commit ad301d759bd710dc6223ab049e4618a21b944f12
Author: bauerb <bauerb@chromium.org>
Date: Fri Oct 07 13:58:28 2016

Require Google Play Services in ChromeBackupIntegrationTest.

BUG= 653809 

Review-Url: https://codereview.chromium.org/2406453002
Cr-Commit-Position: refs/heads/master@{#423848}

[modify] https://crrev.com/ad301d759bd710dc6223ab049e4618a21b944f12/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java

Comment 2 by ian...@chromium.org, Oct 7 2016

Owner: ----
Status: Available (was: Assigned)
Q: Why am I the owner of this bug? :)

I do not know chrome backup tests.

Comment 3 by bauerb@chromium.org, Oct 10 2016

Cc: ian...@chromium.org
Owner: bauerb@chromium.org
Status: Fixed (was: Available)
Because your CL (https://codereview.chromium.org/2399183002) broke it :)

That being said, the test is now guarded with a check for GMSCore, and AFAIK the CL has been reverted, so this can be marked as fixed. If you should reland your CL though, please keep this test in mind, in case the annotation needs to be updated.
►

Sign in to add a comment