New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653806 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Crash in content::VideoCaptureImpl::~VideoCaptureImpl

Project Member Reported by ClusterFuzz, Oct 7 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5332765375725568

Fuzzer: cpaulin_mediarecorder
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  content::VideoCaptureImpl::~VideoCaptureImpl
  content::VideoCaptureImpl::~VideoCaptureImpl
  base::debug::TaskAnnotator::RunTask
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=423265:423391

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97KSTJj1-jT4szbRmW1M7a5KQYTa3dgp2eZhmySwiIigWR6MsQQwmHrNOEk6oni9iuqN322wVAf4RowNukXd3__TC5HDLX3meE_j_lHnohH5_r71xR3whWc0L98y6oY1YJh8x87SEUCp1pMJwlWUwhS_OvvOl6T7hQhykcfBChuDigqcgc?testcase_id=5332765375725568


Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

Issue manually filed by: ranjitkan

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: ranjitkan@chromium.org
Components: Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug Findit-for-crash M-55 Te-Logged Pri-2 Type-Bug-Regression
Owner: mcasas@chromium.org
Status: Assigned (was: Untriaged)
Author: mcasas
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/796b2e6cd3c150f29460c082fcc60ee2186ea9ab
Time: Thu Oct 06 01:48:14 2016
Lines 128, 134-137, 562-570 of file video_capture_impl.cc which potentially caused crash are changed in this cl (frame #0, "GetVideoCaptureHost"; frame #1, "content::VideoCaptureImpl::~VideoCaptureImpl"; frame #2, "content::VideoCaptureImpl::~VideoCaptureImpl").
Minimum distance from crash line to modified line: 0. (file: video_capture_impl.cc, crashed on: 128, modified: 128).

mcasas@: Assigning to you, request you to please take a look into it. Please help us to reassign to a right owner if not with respect to your change.

Thanks.!


Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81183123c82618825cd5734c5ace89fe1723d3c

commit f81183123c82618825cd5734c5ace89fe1723d3c
Author: mcasas <mcasas@chromium.org>
Date: Fri Oct 07 17:59:12 2016

VideoCaptureImpl: check that there's still a channel in ~VideoCaptureImpl() before sending

This was not hit when using IPC due to the channel ignoring
the late message, but now we need to protect against a
disappeared VideoCaptureHost explicitly.

Also, this CL  the unused |suspended_| variable
and simplified RemoveClient() method -- I know, I
know, I shouldn't bundle modifications in a CL...
but these were just too easy to let them pass.

BUG= 653806 ,  651897 

Review-Url: https://codereview.chromium.org/2396413002
Cr-Commit-Position: refs/heads/master@{#423907}

[modify] https://crrev.com/f81183123c82618825cd5734c5ace89fe1723d3c/content/renderer/media/video_capture_impl.cc
[modify] https://crrev.com/f81183123c82618825cd5734c5ace89fe1723d3c/content/renderer/media/video_capture_impl.h

Status: Fixed (was: Assigned)
#2 should fix this, could anyone please verify? Thanks
Project Member

Comment 4 by ClusterFuzz, Oct 8 2016

ClusterFuzz has detected this issue as fixed in range 423512:423881.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5332765375725568

Fuzzer: cpaulin_mediarecorder
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  content::VideoCaptureImpl::~VideoCaptureImpl
  content::VideoCaptureImpl::~VideoCaptureImpl
  base::debug::TaskAnnotator::RunTask
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=423265:423391
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=423512:423881

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97KSTJj1-jT4szbRmW1M7a5KQYTa3dgp2eZhmySwiIigWR6MsQQwmHrNOEk6oni9iuqN322wVAf4RowNukXd3__TC5HDLX3meE_j_lHnohH5_r71xR3whWc0L98y6oY1YJh8x87SEUCp1pMJwlWUwhS_OvvOl6T7hQhykcfBChuDigqcgc?testcase_id=5332765375725568


Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment