New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653802 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Oct 2016
Cc:
█ ranjitkan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Crash in views::Widget::AddObserver

Project Member Reported by ClusterFuzz, Oct 7 2016 
Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5001264918429696

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00000024
Crash State:
  views::Widget::AddObserver
  ToolbarView::ShowBookmarkBubble
  BrowserView::ShowBookmarkBubble
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_v8_arm&range=421807:422067

Minimized Testcase (0.62 Kb): https://cluster-fuzz.appspot.com/download/AMIfv9561GX2pjjYWD_0BrqccXIHG0kLzx0cJ-sx-_b-Jc7MGIy18j_svonwi-X_oTS1L3uCP5i8VHaqp6-rdUHaN5SkxxKuiLa_vpGxMtuau6SRNltuG8g0Jvf-raF1XfdzpZfNQh_0JoFcLDssQ9v6TXLObeFbaw?testcase_id=5001264918429696

Additional requirements: Requires Gestures

Issue manually filed by: ranjitkan

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

Comment 1 by ranjitkan@chromium.org, Oct 7 2016

Cc: ranjitkan@chromium.org
Components: Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug Findit-for-crash M-55 Te-Logged Pri-2 Type-Bug-Regression
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Author: estade
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9
Time: Thu Sep 29 20:41:35 2016
Lines 306-309 of file toolbar_view.cc which potentially caused crash are changed in this cl (frame #4, "ToolbarView::ShowBookmarkBubble").

Lines 1243-1244 of file browser_view.cc which potentially caused crash are changed in this cl (frame #5, "BrowserView::ShowBookmarkBubble").
Minimum distance from crash line to modified line: 0. (file: toolbar_view.cc, crashed on: 306, modified: 306).

@estade: Request you to please take a look into it. Please help us to reassign the issue to a right owner if not with respect to your change.

Thanks.!
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be64cef5970cb99d10548fea08eacede41387de5

commit be64cef5970cb99d10548fea08eacede41387de5
Author: estade <estade@chromium.org>
Date: Mon Oct 10 18:29:35 2016

Fix crash in ShowBookmarkBubble.

BookmarkBubbleView::ShowBubble can return null.

BUG= 653802 

Review-Url: https://codereview.chromium.org/2406933002
Cr-Commit-Position: refs/heads/master@{#424192}

[modify] https://crrev.com/be64cef5970cb99d10548fea08eacede41387de5/chrome/browser/ui/views/toolbar/toolbar_view.cc

Comment 3 by est...@chromium.org, Oct 10 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment