Regression: Unnecessary highlight is seen on card title of synced history while clicking on 'Actions' icon.
Reported by
rk...@etouch.net,
Oct 7 2016
|
||
Issue descriptionChrome Version: 55.0.2882.4 Revision f19386db7e14b3c591d3a320d500f7dd34837c98-refs/branch-heads/2882@{#7} OS:Windows(7,8,8.1,10), Linux(14.04 LTS),Mac(10.10.5)(10.11.5) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://history and click on ‘Tabs from other devices’. 2. Open devtools and click on ’Toggle device toolbar’ icon. 3. Now click on ‘Actions’ iron icon of ’Synced tab’ entries, observe. Actual: Unnecessary highlight is seen on card title of synced history while clicking on actions icon. Expected: No such a highlight should seen on card title of synced history. This is a regression issue broken in ‘M-55’, below is the Manual Regression and Change log URL. Good build : 55.0.2874.0 Bad build : 55.0.2875.0 Change log URL : https://chromium.googlesource.com/chromium/src/+log/55.0.2873.0..55.0.2875.0?pretty=fuller&n=10000 (Unable to narrow down the range using tool as ‘sign-in to chrome’ feature is not supported in chromium builds, hence providing the suspect from change log) Suspecting: r421430 ? from CL @tsergeant : Please help to re-assign if your change is not the cause for this issue.
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e5c2bc09cede88979793107a21d9202559eae40 commit 6e5c2bc09cede88979793107a21d9202559eae40 Author: tsergeant <tsergeant@chromium.org> Date: Wed Oct 19 14:26:30 2016 MD History: Fix minor visual inconsistencies * Remove tap highlight on synced device card titles * Adjust padding on history list so that 'no results' messages align correctly BUG= 653817 , 653782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2402913002 Cr-Commit-Position: refs/heads/master@{#426181} [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/6e5c2bc09cede88979793107a21d9202559eae40/chrome/browser/resources/md_history/synced_device_card.html
,
Oct 20 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tsergeant@chromium.org
, Oct 10 2016