Issue metadata
Sign in to add a comment
|
Captive portal interstitial shows neutral (i) icon, not red triangle |
||||||||||||||||||||
Issue descriptionVersion: 55.0.2882.0 OS: Mac OS X What steps will reproduce the problem? (1) Follow the instructions at https://gist.github.com/lgarron/5230cc1eebcc19385ed0 to trigger the captive portal interstitial. What is the expected output? Lock icon is red triangle... maybe? What do you see instead? Neutral (i) icon See attachment.
,
Oct 7 2016
,
Oct 10 2016
I'd be okay with this given that there is no way to proceed through this interstitial, but since bad clock also uses red triangle it makes sense to change it.
,
Oct 10 2016
Yeah, that makes sense to me too -- I'll send you a CL.
,
Oct 10 2016
Removing security labels since it's a non-overrideable interstitial, not really a security bug.
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e2553a9defa7bdf50be5d18f0cb8ce4ec539ad9 commit 3e2553a9defa7bdf50be5d18f0cb8ce4ec539ad9 Author: estark <estark@chromium.org> Date: Mon Oct 10 22:25:34 2016 Show red lock icon on captive portal SSL interstitial We were previously showing the neutral icon on captive portal interstitials. This isn't that big a deal because the interstitial is non-bypassable, but we should show a red/dangerous icon to be consistent with the bad clock interstitial. BUG= 653779 Review-Url: https://codereview.chromium.org/2408713003 Cr-Commit-Position: refs/heads/master@{#424265} [modify] https://crrev.com/3e2553a9defa7bdf50be5d18f0cb8ce4ec539ad9/chrome/browser/ssl/captive_portal_blocking_page.cc [modify] https://crrev.com/3e2553a9defa7bdf50be5d18f0cb8ce4ec539ad9/chrome/browser/ssl/captive_portal_blocking_page.h [modify] https://crrev.com/3e2553a9defa7bdf50be5d18f0cb8ce4ec539ad9/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
,
Oct 10 2016
,
Oct 11 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label
,
Jan 17 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by est...@chromium.org
, Oct 7 2016