New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653773 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Too many logs from mp4/aac parser in about://media-internals

Project Member Reported by xhw...@chromium.org, Oct 7 2016

Issue description

Version: M53
OS: All

What steps will reproduce the problem?
(1) Play a mp4/aac video
(2) Open a new tab and go to about://media-internals

What is the expected output?
We see useful logs there

What do you see instead?
We have too many logs from mp4/aac parsers. See attached screenshot for details.

 
Screen Shot 2016-10-06 at 10.45.48 PM.png
608 KB View Download
wolenetz: Do we really need these logs from the parsers? Should we only report audio/video configs in the demuxer level, e.g. for the initial config, and then only report when we have a config change?
Components: Internals>Media>Source
Some options:
1. Limit the successfully parsed decoder (re)configuration logs to just *initial* and *changed* decoder configs (e.g., Filter these in SourceBufferState::OnNewConfigs()).
2. We could do LIMITED_MEDIA_LOG in the parsers, though plumbing that might break some internal parser layers.
3. We could do 1 + LIMITED_MEDIA_LOG of non-changed, but newly emitted configs, in SourceBufferState::OnNewConfigs().
4**. Orthogonally, we could allow filtering in the media-internals UI by log-level (e.g., "only show me ERROR and DEBUG, but not INFO").

I think 1, or 3, is best done to fix this bug. xhwang@, wdyt?

**4 is something we've thought about and cross-cuts more than this bug, and can be done separately (I've filed bug 653996 to track option #4).
Agreed 1 or 3 is best. I like 1 better and feel we should limit the use of LIMITED_MEDIA_LOG if we can control what to log.

Comment 5 by xhw...@chromium.org, Feb 17 2017

Cc: -xhw...@chromium.org
Labels: -M-56 M-58
Owner: xhw...@chromium.org
This has not been fixed for several releases. Before we have a proper fix, I suggest remove these logs for now. We can alway add them back when we have a proper fix.

FYI, on https://www.youtube.com/watch?v=XVRcRZOQl_U, I saw new codec logs added every 1-2 seconds, which is really bad.
SGTM. Please keep this bug alive for adding option 1 or 3 (and orthogonally #4) from c#3.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c17e198a8ad64e0ca922329e701466f08161e6a

commit 9c17e198a8ad64e0ca922329e701466f08161e6a
Author: xhwang <xhwang@chromium.org>
Date: Sat Feb 18 06:06:36 2017

media-internals: Remove audio/video codec reporting from mp4 parser

These parsers generated too many logs, most of which don't provide much
value. When I watch youtube games channel, I can see new audio/video
codec logs in media-internals every second.

From the bug, it seems it'll take some more time before we have a proper
fix. I think we should remove these logs for now, and then if needed, we
can reenable them with the proper fix.

BUG= 653773 

Review-Url: https://codereview.chromium.org/2702803002
Cr-Commit-Position: refs/heads/master@{#451421}

[modify] https://crrev.com/9c17e198a8ad64e0ca922329e701466f08161e6a/media/formats/mp4/aac.cc
[modify] https://crrev.com/9c17e198a8ad64e0ca922329e701466f08161e6a/media/formats/mp4/aac_unittest.cc
[modify] https://crrev.com/9c17e198a8ad64e0ca922329e701466f08161e6a/media/formats/mp4/box_definitions.cc
[modify] https://crrev.com/9c17e198a8ad64e0ca922329e701466f08161e6a/media/formats/mp4/hevc.cc
[modify] https://crrev.com/9c17e198a8ad64e0ca922329e701466f08161e6a/media/formats/mp4/mp4_stream_parser_unittest.cc

Comment 8 by xhw...@chromium.org, Feb 18 2017

Cc: xhw...@chromium.org
Owner: ----
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
this bug has been stale for > 1 year. do we still want to keep it?
Status: WontFix (was: Untriaged)
resolve as wont fix. please feel free to activate and assign appropriately if need.

Sign in to add a comment