MD History: Search results are not announced to screen-reader users |
|||||||
Issue descriptionSee bug 606527 for context. I am switching the announcement to `iron-a11y-announcer` as a quick fix. We should also look into fixing `announceAccessibleMessage` to more reliably announce messages.
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2797cc88833b227a24dfd476cb9ce125b07004 commit 2a2797cc88833b227a24dfd476cb9ce125b07004 Author: tsergeant <tsergeant@chromium.org> Date: Fri Oct 07 20:14:07 2016 MD History: Use iron-a11y-announcer to announce search result messages The existing method we were using, `announceAccessibleMethod`, did not correctly announce messages on Canary, possibly due to timing issues. iron-a11y-announcer appears to be more robust for making sure messages are actually announced, since they do not immediately disappear from the DOM tree. BUG=606527, 653764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2399213004 Cr-Commit-Position: refs/heads/master@{#423949} [modify] https://crrev.com/2a2797cc88833b227a24dfd476cb9ce125b07004/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/2a2797cc88833b227a24dfd476cb9ce125b07004/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/2a2797cc88833b227a24dfd476cb9ce125b07004/chrome/browser/resources/md_history/list_container.html [modify] https://crrev.com/2a2797cc88833b227a24dfd476cb9ce125b07004/chrome/browser/resources/md_history/list_container.js
,
Oct 10 2016
,
Oct 10 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 10 2016
tsergeant@, could you please merge your change in to M55 (branch: 2883) as soon as possible. Thank you.
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44445bebac9e04a16653f5038f338d0ef2e6c5c2 commit 44445bebac9e04a16653f5038f338d0ef2e6c5c2 Author: Tim Sergeant <tsergeant@chromium.org> Date: Mon Oct 10 21:35:32 2016 MD History: Use iron-a11y-announcer to announce search result messages The existing method we were using, `announceAccessibleMethod`, did not correctly announce messages on Canary, possibly due to timing issues. iron-a11y-announcer appears to be more robust for making sure messages are actually announced, since they do not immediately disappear from the DOM tree. BUG=606527, 653764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2399213004 Cr-Commit-Position: refs/heads/master@{#423949} (cherry picked from commit 2a2797cc88833b227a24dfd476cb9ce125b07004) Review URL: https://codereview.chromium.org/2405993002 . Cr-Commit-Position: refs/branch-heads/2883@{#20} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/list_container.html [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/list_container.js
,
Oct 10 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44445bebac9e04a16653f5038f338d0ef2e6c5c2 commit 44445bebac9e04a16653f5038f338d0ef2e6c5c2 Author: Tim Sergeant <tsergeant@chromium.org> Date: Mon Oct 10 21:35:32 2016 MD History: Use iron-a11y-announcer to announce search result messages The existing method we were using, `announceAccessibleMethod`, did not correctly announce messages on Canary, possibly due to timing issues. iron-a11y-announcer appears to be more robust for making sure messages are actually announced, since they do not immediately disappear from the DOM tree. BUG=606527, 653764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2399213004 Cr-Commit-Position: refs/heads/master@{#423949} (cherry picked from commit 2a2797cc88833b227a24dfd476cb9ce125b07004) Review URL: https://codereview.chromium.org/2405993002 . Cr-Commit-Position: refs/branch-heads/2883@{#20} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/list_container.html [modify] https://crrev.com/44445bebac9e04a16653f5038f338d0ef2e6c5c2/chrome/browser/resources/md_history/list_container.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tsergeant@chromium.org
, Oct 7 2016