New issue
Advanced search Search tips

Issue 653751 link

Starred by 1 user
Status: Assigned
Owner:
pwnall@chromium.org
Cc:
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Pull storage/ tests from content_unittests to a new storage_unittests target

Project Member Reported by pwnall@chromium.org, Oct 7 2016 
The unit tests for the code in storage/ lives in content/, so it can (ab)use the content_unittests target. We should create a storage_unittests target and use it for the tests that belong in storage/.

An example follows below.
Code: https://cs.chromium.org/chromium/src/storage/browser/database/database_tracker.cc
Test: https://cs.chromium.org/chromium/src/content/browser/database_tracker_unittest.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38a061e08ece1f0894e7489afac24d47db964e4a

commit 38a061e08ece1f0894e7489afac24d47db964e4a
Author: pwnall <pwnall@chromium.org>
Date: Tue Oct 11 01:19:28 2016

Create storage_unittests target.

storage_unittests will eventually host the tests for files in storage/
that now live under content/browser/ so they can be included in the
content_unittests target. Follow up CLs will add storage_unittests to
trybots and waterfalls and, eventually, move the relevant tests from
content/browser/ to storage/

BUG=653751

Review-Url: https://codereview.chromium.org/2402593002
Cr-Commit-Position: refs/heads/master@{#424324}

[modify] https://crrev.com/38a061e08ece1f0894e7489afac24d47db964e4a/storage/browser/BUILD.gn
[add] https://crrev.com/38a061e08ece1f0894e7489afac24d47db964e4a/storage/browser/crbug653751_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035

commit 8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035
Author: pwnall <pwnall@chromium.org>
Date: Tue Oct 11 12:18:26 2016

Teach valgrind about the new storage_unittests target.

BUG=653751

Review-Url: https://codereview.chromium.org/2408553002
Cr-Commit-Position: refs/heads/master@{#424408}

[modify] https://crrev.com/8a4a2b4bf5c64772dcc8f9e20b779ee621b3b035/tools/valgrind/chrome_tests.py
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e6964dbe48c79441a64423241e48ef59f64cb71

commit 1e6964dbe48c79441a64423241e48ef59f64cb71
Author: pwnall <pwnall@chromium.org>
Date: Tue Oct 11 18:15:47 2016

Add the new storage_unittests target to chromecast/BUILD.gn

storage_unittests will contain some of the tests that now (incorrectly)
live under content_unittests. Therefore, it should be built whenever
content_unittests is built.

BUG=653751

Review-Url: https://codereview.chromium.org/2404163002
Cr-Commit-Position: refs/heads/master@{#424488}

[modify] https://crrev.com/1e6964dbe48c79441a64423241e48ef59f64cb71/chromecast/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3387d2697f8df0030805ad9218a217f767e1700e

commit 3387d2697f8df0030805ad9218a217f767e1700e
Author: pwnall <pwnall@chromium.org>
Date: Wed Oct 12 17:23:35 2016

Teach determinism tools about the new storage_unittests target.

BUG=653751

Review-Url: https://codereview.chromium.org/2410733002
Cr-Commit-Position: refs/heads/master@{#424772}

[modify] https://crrev.com/3387d2697f8df0030805ad9218a217f767e1700e/tools/determinism/compare_build_artifacts.py
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/008c02729b10638f42f3598272bd30342d194a42

commit 008c02729b10638f42f3598272bd30342d194a42
Author: pwnall <pwnall@chromium.org>
Date: Fri Oct 14 16:54:04 2016

Add storage_unittests to buildbots.

BUG=653751

Review-Url: https://codereview.chromium.org/2395363002
Cr-Commit-Position: refs/heads/master@{#425361}

[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/BUILD.gn
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/build/android/pylib/gtest/gtest_config.py
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.android.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.full.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.memory.full.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.memory.fyi.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium.win.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/chromium_memory_trybot.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/008c02729b10638f42f3598272bd30342d194a42/testing/buildbot/gn_isolate_map.pyl

Comment 6 by nya@chromium.org, Jan 12 2017

Cc: nya@chromium.org
Hi pwnall@, is this bug already fixed? I want to add unit tests to storage/.

Comment 7 by pwnall@chromium.org, Jan 19 2017 

Sorry for responding so late!

I haven't gotten around to doing the move, but the target is created. I suspect that the path of least resistance for you is to keep adding the tests to content, but you're welcome to try adding them to storage instead!

Comment 8 by nya@chromium.org, Jan 19 2017 

I see, thanks!
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119e4c228dd58f8b754735f92cb7e31e999e01de

commit 119e4c228dd58f8b754735f92cb7e31e999e01de
Author: pwnall <pwnall@chromium.org>
Date: Mon Mar 27 22:57:00 2017

Move some blob tests next to the files they cover.

BUG=653751

Review-Url: https://codereview.chromium.org/2774413002
Cr-Commit-Position: refs/heads/master@{#459920}

[modify] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/content/test/BUILD.gn
[modify] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/BUILD.gn
[rename] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/blob/blob_data_builder_unittest.cc
[rename] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/blob/blob_flattener_unittest.cc
[rename] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/blob/blob_memory_controller_unittest.cc
[rename] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/blob/blob_slice_unittest.cc
[rename] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/blob/blob_storage_registry_unittest.cc
[rename] https://crrev.com/119e4c228dd58f8b754735f92cb7e31e999e01de/storage/browser/blob/blob_transport_request_builder_unittest.cc
[delete] https://crrev.com/4616044b6d5b9ef6bf8b77c9fff4c687ee0438e0/storage/browser/crbug653751_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375c78221f4df786923744d9cc76e66b55775ecb

commit 375c78221f4df786923744d9cc76e66b55775ecb
Author: pwnall <pwnall@chromium.org>
Date: Tue Mar 28 00:04:43 2017

Move some fileapi tests next to the files they cover.

BUG=653751

Review-Url: https://codereview.chromium.org/2775383003
Cr-Commit-Position: refs/heads/master@{#459946}

[modify] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/content/test/BUILD.gn
[modify] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/BUILD.gn
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/external_mount_points_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/file_system_url_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/file_system_usage_cache_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/isolated_context_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/local_file_stream_reader_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/local_file_stream_writer_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/native_file_util_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/sandbox_isolated_origin_database_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/sandbox_prioritized_origin_database_unittest.cc
[rename] https://crrev.com/375c78221f4df786923744d9cc76e66b55775ecb/storage/browser/fileapi/timed_task_helper_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca04d1cb992560ad509e4497252371327c0cde83

commit ca04d1cb992560ad509e4497252371327c0cde83
Author: pwnall <pwnall@chromium.org>
Date: Wed Apr 05 07:13:39 2017

Delete content::MockURLRequestDelegate.

net::TestDelegate provides the functionality needed by the users of
content::MockURLRequestDelegate, and is maintained by net/. Therefore,
this CL moves all the clients to net::TestDelegate.

BUG=653751

Review-Url: https://codereview.chromium.org/2788583006
Cr-Commit-Position: refs/heads/master@{#461996}

[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/blob_storage/blob_url_request_job_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/cache_storage/cache_storage_cache_unittest.cc
[delete] https://crrev.com/8aeb209607030af0bad873e2d699a5df0d0d83da/content/browser/fileapi/mock_url_request_delegate.cc
[delete] https://crrev.com/8aeb209607030af0bad873e2d699a5df0d0d83da/content/browser/fileapi/mock_url_request_delegate.h
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/ca04d1cb992560ad509e4497252371327c0cde83/content/test/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343665e7bad5f7f1b01b8bfec116cff4194766d8

commit 343665e7bad5f7f1b01b8bfec116cff4194766d8
Author: pwnall <pwnall@chromium.org>
Date: Thu Apr 13 04:04:40 2017

Move a couple of blob tests next to the files they cover.

To keep dependencies clean, this CL creates a new target
//storage/browser:test_support. As storage tests are moved next to the
files they cover, the test doubles that they use will be moved to the
new test_support target.

BUG=653751
TBR=rdevlin.cronin

Review-Url: https://codereview.chromium.org/2815743002
Cr-Commit-Position: refs/heads/master@{#464290}

[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/chromeos/drive/file_system_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/net/quota_policy_channel_id_store_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/platform_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/appcache/chrome_appcache_service_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/blob_storage/blob_dispatcher_host_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/database_tracker_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/dom_storage/dom_storage_context_impl_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/copy_or_move_file_validator_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/dragged_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_context_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_file_stream_reader_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_operation_impl_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_operation_impl_write_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_operation_runner_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_quota_client_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_system_url_request_job_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/file_writer_delegate_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/fileapi_message_filter_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/local_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/obfuscated_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/plugin_private_file_system_backend_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/sandbox_file_system_backend_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/transient_file_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/quota/mock_quota_manager_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/quota/quota_database_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/quota/quota_manager_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/quota/storage_monitor_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/quota/usage_tracker_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/public/test/sandbox_file_system_test_helper.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/content/test/BUILD.gn
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/extensions/DEPS
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/extensions/browser/BUILD.gn
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/extensions/browser/api/file_handlers/mime_util_unittest.cc
[modify] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/BUILD.gn
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/blob/blob_reader_unittest.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/blob/blob_url_request_job_unittest.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/async_file_test_helper.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/async_file_test_helper.h
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/mock_special_storage_policy.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/mock_special_storage_policy.h
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/test_file_system_backend.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/test_file_system_backend.h
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/test_file_system_context.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/test_file_system_context.h
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/test_file_system_options.cc
[rename] https://crrev.com/343665e7bad5f7f1b01b8bfec116cff4194766d8/storage/browser/test/test_file_system_options.h
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6d19700c2ea1b349d2b9ffcf20a488cef00fa9

commit ef6d19700c2ea1b349d2b9ffcf20a488cef00fa9
Author: pwnall <pwnall@chromium.org>
Date: Fri Apr 14 06:01:45 2017

Remove unnecessary include in content/test/test_blink_web_unit_test_support.cc.

Asides from the slight increase in compilation time, the include gives
the wrong impression that the file depends on a low-level SQLite
integration detail.

BUG=653751

Review-Url: https://codereview.chromium.org/2818713004
Cr-Commit-Position: refs/heads/master@{#464684}

[modify] https://crrev.com/ef6d19700c2ea1b349d2b9ffcf20a488cef00fa9/content/test/test_blink_web_unit_test_support.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2383850584645fc89acd0332c11a592e0b0fd21c

commit 2383850584645fc89acd0332c11a592e0b0fd21c
Author: pwnall <pwnall@chromium.org>
Date: Fri Apr 14 06:08:39 2017

Move some File API backend unit tests next to the files that they cover.

BUG=653751

Review-Url: https://codereview.chromium.org/2813353003
Cr-Commit-Position: refs/heads/master@{#464687}

[modify] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/content/test/BUILD.gn
[modify] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/BUILD.gn
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/copy_or_move_file_validator_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/file_system_file_stream_reader_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/file_system_quota_client_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/file_system_url_request_job_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/file_writer_delegate_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/local_file_util_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/plugin_private_file_system_backend_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/sandbox_file_system_backend_unittest.cc
[rename] https://crrev.com/2383850584645fc89acd0332c11a592e0b0fd21c/storage/browser/fileapi/transient_file_util_unittest.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b57ef309c97d1fd37c5eb83377b7b5e511fb292

commit 7b57ef309c97d1fd37c5eb83377b7b5e511fb292
Author: pwnall <pwnall@chromium.org>
Date: Wed Apr 19 03:09:58 2017

Move browser-side File API unittests next to the files they cover.

BUG=653751

Review-Url: https://codereview.chromium.org/2819363003
Cr-Commit-Position: refs/heads/master@{#465479}

[modify] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc
[modify] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/content/browser/fileapi/file_system_operation_impl_write_unittest.cc
[modify] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/content/test/BUILD.gn
[modify] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/BUILD.gn
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/fileapi/dragged_file_util_unittest.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/fileapi/file_system_context_unittest.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/fileapi/file_system_operation_impl_unittest.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/fileapi/obfuscated_file_util_unittest.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/fileapi/recursive_operation_delegate_unittest.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/fileapi_test_file_set.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/fileapi_test_file_set.h
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/mock_file_change_observer.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/mock_file_change_observer.h
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/mock_file_update_observer.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/mock_file_update_observer.h
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/sandbox_file_system_test_helper.cc
[rename] https://crrev.com/7b57ef309c97d1fd37c5eb83377b7b5e511fb292/storage/browser/test/sandbox_file_system_test_helper.h
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82195125039f3fe5e7dc29ab7c382767750eb2ba

commit 82195125039f3fe5e7dc29ab7c382767750eb2ba
Author: pwnall <pwnall@chromium.org>
Date: Wed Apr 19 04:36:26 2017

Move a browser-side File API unittest next to the file it covers.

BUG=653751

Review-Url: https://codereview.chromium.org/2821303003
Cr-Commit-Position: refs/heads/master@{#465493}

[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc
[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc
[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc
[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/content/test/BUILD.gn
[modify] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/storage/browser/BUILD.gn
[rename] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/storage/browser/fileapi/file_system_operation_impl_write_unittest.cc
[rename] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/storage/browser/test/mock_blob_url_request_context.cc
[rename] https://crrev.com/82195125039f3fe5e7dc29ab7c382767750eb2ba/storage/browser/test/mock_blob_url_request_context.h
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f1622acdaf14425d2363cdac6bd05e79585d2ee

commit 9f1622acdaf14425d2363cdac6bd05e79585d2ee
Author: pwnall <pwnall@chromium.org>
Date: Fri Apr 21 09:39:02 2017

Move storage tests from content/common next to the files they cover.

I initially set up storage's unit tests target to live at
//storage/browser:storage_unittests, because I didn't notice the tests
hiding in content/common. This CL makes the target live at
//storage:storage_unittests, so it can hold the tests in both
storage/browser and storage/common.

BUG=653751

Review-Url: https://codereview.chromium.org/2827933003
Cr-Commit-Position: refs/heads/master@{#466294}

[modify] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/BUILD.gn
[modify] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/chromecast/BUILD.gn
[modify] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/content/test/BUILD.gn
[add] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/storage/BUILD.gn
[modify] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/storage/browser/BUILD.gn
[modify] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/storage/common/BUILD.gn
[rename] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/storage/common/database/database_connections_unittest.cc
[rename] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/storage/common/database/database_identifier_unittest.cc
[rename] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/storage/common/fileapi/file_system_util_unittest.cc
[modify] https://crrev.com/9f1622acdaf14425d2363cdac6bd05e79585d2ee/testing/buildbot/gn_isolate_map.pyl

Comment 23 by pwnall@chromium.org, Apr 21 2017 

The only two files left in content_unittests are listed below. They'll be more difficult to move.

blob/blob_transport_host_unittest.cc
- uses content/public/test/test_browser_thread_bundle.h

fileapi/file_system_operation_runner_unittest.cc
- uses content/public/test/test_browser_thread_bundle.h and content/public/test/test_browser_thread.h

On the mechanical side, all the test stuff that got moved is in the content namespace, and needs to be moved to the storage namespace. 

The files in storage/browser/test are used by content/, chrome/, and possibly extensions/. They should probably be renamed together, because the CLs will require broader reviews. Everything else can be renamed in reviews that go to storage/ OWNERS.
►

Sign in to add a comment