New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653738 link

Starred by 4 users
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Make network timeline a canvas

Project Member Reported by allada@chromium.org, Oct 7 2016 
We should make the timeline in network panel a canvas instead of doing it in the dom. This should allow us to draw arrows and other artifacts inside the canvas.

Comment 1 by allada@chromium.org, Oct 7 2016

Labels: -Pri-3 Pri-1

Comment 2 by allada@chromium.org, Oct 7 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcad61be353f50886a0983ed50e7ad6ef192010d

commit dcad61be353f50886a0983ed50e7ad6ef192010d
Author: allada <allada@chromium.org>
Date: Sat Oct 08 03:40:13 2016

[Devtools] New network timeline experiment Part 1

Introduces skeleton for new canvas based network timeline.

This dies not show any data but presents a model for how it will
work.

Raw image: http://imgur.com/a/NJZuA

R=lushnikov,dgozman,alph
BUG= 653738 

Review-Url: https://codereview.chromium.org/2400093002
Cr-Commit-Position: refs/heads/master@{#424060}

[modify] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[add] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
[modify] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/front_end/network/module.json
[modify] https://crrev.com/dcad61be353f50886a0983ed50e7ad6ef192010d/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ab590632793f5cb4411c8cf791fa72b3e4f93a

commit 69ab590632793f5cb4411c8cf791fa72b3e4f93a
Author: allada <allada@chromium.org>
Date: Tue Oct 11 22:14:23 2016

[Devtools] Added data to networking timeline canvas experiment

Added real data to the canvas timeline experiment for network timeline.

http://imgur.com/a/Ky1Q5

R=lushnikov,dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2411533002
Cr-Commit-Position: refs/heads/master@{#424567}

[modify] https://crrev.com/69ab590632793f5cb4411c8cf791fa72b3e4f93a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/69ab590632793f5cb4411c8cf791fa72b3e4f93a/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f35ac8b827d147b544f878852332a426dae0a39

commit 9f35ac8b827d147b544f878852332a426dae0a39
Author: allada <allada@chromium.org>
Date: Wed Oct 12 02:07:26 2016

[Devtools] Added row decoration to canvas timeline experiment

Introduces line decorations to stripe the lines in canvas timeline
experiment.

http://imgur.com/a/TL99L

R=lushnikov,dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2408023002
Cr-Commit-Position: refs/heads/master@{#424646}

[modify] https://crrev.com/9f35ac8b827d147b544f878852332a426dae0a39/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9dfceb47085397320ee0fbfedd3f962105d085

commit 2b9dfceb47085397320ee0fbfedd3f962105d085
Author: allada <allada@chromium.org>
Date: Thu Oct 20 05:28:14 2016

[Devtools] Added popover support to network timeline canvas expirement

This patch added hover/popover support to canvas timeline in network.

see: http://imgur.com/a/qlZOc

R=lushnikov,dgozman
BUG= 653738 

Review-Url: https://chromiumcodereview.appspot.com/2414853002
Cr-Commit-Position: refs/heads/master@{#426416}

[modify] https://crrev.com/2b9dfceb47085397320ee0fbfedd3f962105d085/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed6c761317066bfd0d24d3a2239c943dc3b83b5

commit 0ed6c761317066bfd0d24d3a2239c943dc3b83b5
Author: allada <allada@chromium.org>
Date: Thu Oct 20 19:00:04 2016

[Devtools] Added simplified/latency view to network timeline experiment

This patch introduces the colorized timeline view to network panel
timeline. This can currently be reached by turning on "Color-code
resource types" in settings.

See: http://imgur.com/a/MOInX

R=dgozman
BUG= 653738 

Review-Url: https://chromiumcodereview.appspot.com/2418953002
Cr-Commit-Position: refs/heads/master@{#426551}

[modify] https://crrev.com/0ed6c761317066bfd0d24d3a2239c943dc3b83b5/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
[modify] https://crrev.com/0ed6c761317066bfd0d24d3a2239c943dc3b83b5/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6950f20e996680a3075bbd6a094db90b3ac67b31

commit 6950f20e996680a3075bbd6a094db90b3ac67b31
Author: allada <allada@chromium.org>
Date: Fri Oct 21 03:40:59 2016

[Devtools] Removed dependency of networkLogView and dataGrid

Removed dependency of networkLogView and dataGrid from new network
timeline canvas experiment.

R=dgozman
BUG= 653738 

Review-Url: https://chromiumcodereview.appspot.com/2439453003
Cr-Commit-Position: refs/heads/master@{#426713}

[modify] https://crrev.com/6950f20e996680a3075bbd6a094db90b3ac67b31/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/6950f20e996680a3075bbd6a094db90b3ac67b31/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3f1ac093d15f744e41fd0a89a44ac2b591ea294

commit b3f1ac093d15f744e41fd0a89a44ac2b591ea294
Author: allada <allada@chromium.org>
Date: Sun Oct 23 13:47:53 2016

[Devtools] Fixed scrollbar offset in new timeline experiment

This patch fixes the timeline scrollbar offset for the canvas timeline
experiment.

R=dgozman
BUG= 653738 

Review-Url: https://chromiumcodereview.appspot.com/2438683004
Cr-Commit-Position: refs/heads/master@{#427000}

[modify] https://crrev.com/b3f1ac093d15f744e41fd0a89a44ac2b591ea294/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
[modify] https://crrev.com/b3f1ac093d15f744e41fd0a89a44ac2b591ea294/third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf

commit ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf
Author: allada <allada@chromium.org>
Date: Thu Oct 27 16:36:09 2016

[Devtools] Move NetworkTimelineColumn into NetworkLogViewColumns P1

This patch is restructuring NetworkLogView and NetworkLogViewColumns
in preporation of moving all code relating to NetworkTimelineColumn
into NetworkLogViewColumns.

This is Part 1.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2443683002
Cr-Commit-Position: refs/heads/master@{#428051}

[modify] https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/ab0c2f3cca120934b625f2ff7e8cc79ea4cf58cf/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611da05ec3bd65457637663321051109217a3bb1

commit 611da05ec3bd65457637663321051109217a3bb1
Author: allada <allada@chromium.org>
Date: Thu Oct 27 17:11:15 2016

[Devtools] Moved NetworkTimelineColumn to NetworkLogViewColumns P2

This patch removes all traces of timeline from NetworkLogView and moves
the dependency into NetworkLogViewColumns.

This is part 2.
Part 1 is: https://codereview.chromium.org/2443683002/

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2450603005
Cr-Commit-Position: refs/heads/master@{#428063}

[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html
[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html
[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html
[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/611da05ec3bd65457637663321051109217a3bb1/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/034e2796aa34802260bd4841e7781a66b8b33ce6

commit 034e2796aa34802260bd4841e7781a66b8b33ce6
Author: allada <allada@chromium.org>
Date: Fri Oct 28 23:19:28 2016

[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2461573002
Cr-Commit-Position: refs/heads/master@{#428539}

[modify] https://crrev.com/034e2796aa34802260bd4841e7781a66b8b33ce6/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/034e2796aa34802260bd4841e7781a66b8b33ce6/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8db439df7b58acd8db359b9fd78d649e7a13582

commit c8db439df7b58acd8db359b9fd78d649e7a13582
Author: allada <allada@chromium.org>
Date: Fri Oct 28 23:32:39 2016

[Devtools] Added contextmenu item to allow different timeline styles for exp

This patch adds the ability to go between modes in the header context menu
for the network timeline experiment.

See: http://imgur.com/a/8qGxd

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2454893004
Cr-Commit-Position: refs/heads/master@{#428545}

[modify] https://crrev.com/c8db439df7b58acd8db359b9fd78d649e7a13582/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/c8db439df7b58acd8db359b9fd78d649e7a13582/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f00059c2af3138080c7598dc487d18d3eef50e

commit 54f00059c2af3138080c7598dc487d18d3eef50e
Author: allada <allada@chromium.org>
Date: Mon Oct 31 20:52:58 2016

[Devtools] Fixed scrollers for new timeline canvas on mac

This patch fixes issue where scrollbars were not being shown on mac
for the new canvas timeline in network panel.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2466633002
Cr-Commit-Position: refs/heads/master@{#428803}

[modify] https://crrev.com/54f00059c2af3138080c7598dc487d18d3eef50e/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
[modify] https://crrev.com/54f00059c2af3138080c7598dc487d18d3eef50e/third_party/WebKit/Source/devtools/front_end/network/networkTimelineColumn.css
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d70482b0d98af3a78fba0425bf0ea18cad869548

commit d70482b0d98af3a78fba0425bf0ea18cad869548
Author: allada <allada@chromium.org>
Date: Mon Oct 31 22:48:24 2016

[Devtools] Fixed contextmenu in network timeline experiment.

This patch fixes a minor regression where if you summoned a context
menu from the timeline you would not get anything.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2466473003
Cr-Commit-Position: refs/heads/master@{#428852}

[modify] https://crrev.com/d70482b0d98af3a78fba0425bf0ea18cad869548/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/d70482b0d98af3a78fba0425bf0ea18cad869548/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f846737a09e14aafe1e40a2b7d823ade6703cf

commit 86f846737a09e14aafe1e40a2b7d823ade6703cf
Author: allada <allada@chromium.org>
Date: Tue Nov 01 01:01:09 2016

[Devtools] Fixed dividers in new network canvas timeline

Fixed dividers in network canvas timeline experiment. Before
they were not scrolling properly when the top timeline was moved.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2470523003
Cr-Commit-Position: refs/heads/master@{#428892}

[modify] https://crrev.com/86f846737a09e14aafe1e40a2b7d823ade6703cf/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
[modify] https://crrev.com/86f846737a09e14aafe1e40a2b7d823ade6703cf/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js
[modify] https://crrev.com/86f846737a09e14aafe1e40a2b7d823ade6703cf/third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4025c2cba57945b8b51ef021e2915906f3c71b0d

commit 4025c2cba57945b8b51ef021e2915906f3c71b0d
Author: allada <allada@chromium.org>
Date: Tue Nov 01 20:29:07 2016

[Devtools] Fix network timeline canvas selection splitview

This patch fixes a regression caused when a user selects a request
in the new network canvas timeline it would show the canvas to the left
instead of the name column.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2465373002
Cr-Commit-Position: refs/heads/master@{#429092}

[modify] https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/658b8cbc437f96577e955a48097c7923b7f146aa

commit 658b8cbc437f96577e955a48097c7923b7f146aa
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Nov 01 20:40:24 2016

Revert of [Devtools] Fix network timeline canvas selection splitview (patchset #1 id:1 of https://codereview.chromium.org/2465373002/ )

Reason for revert:
I'll reapply it.

Original issue's description:
> [Devtools] Fix network timeline canvas selection splitview
>
> This patch fixes a regression caused when a user selects a request
> in the new network canvas timeline it would show the canvas to the left
> instead of the name column.
>
> R=dgozman
> BUG= 653738 

TBR=dgozman@chromium.org,allada@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 653738 

Review-Url: https://codereview.chromium.org/2472523002
Cr-Commit-Position: refs/heads/master@{#429097}

[modify] https://crrev.com/658b8cbc437f96577e955a48097c7923b7f146aa/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8ce2ab11cbe520868896bfc52ca72e3e25e2165

commit a8ce2ab11cbe520868896bfc52ca72e3e25e2165
Author: allada <allada@chromium.org>
Date: Tue Nov 01 23:18:34 2016

[Devtools] Fix network timeline canvas selection splitview

This patch fixes a regression caused when a user selects a request
in the new network canvas timeline it would show the canvas to the left
instead of the name column.

R=dgozman
BUG= 653738 

Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d
Review-Url: https://codereview.chromium.org/2465373002
Cr-Original-Commit-Position: refs/heads/master@{#429092}
Cr-Commit-Position: refs/heads/master@{#429150}

[modify] https://crrev.com/a8ce2ab11cbe520868896bfc52ca72e3e25e2165/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca42907b2e71c9368673225abc480c05e898ce95

commit ca42907b2e71c9368673225abc480c05e898ce95
Author: allada <allada@chromium.org>
Date: Thu Nov 03 22:27:28 2016

[Devtools] Added constraints to new network timeline

This patch enforces a 100px minimum to network timeline canvas
experiment.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2468393002
Cr-Commit-Position: refs/heads/master@{#429712}

[modify] https://crrev.com/ca42907b2e71c9368673225abc480c05e898ce95/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d8671b5708aa90dde46133d85d75f4c17aedbd

commit c1d8671b5708aa90dde46133d85d75f4c17aedbd
Author: allada <allada@chromium.org>
Date: Fri Nov 04 05:54:19 2016

[Devtools] Moved new timeline canvas context menu to bottom

Moved the context menu item for timeline to bottom of context menu
instead of top per paulirish@.

R=dgozman,paulirish
BUG= 653738 

Review-Url: https://codereview.chromium.org/2466413007
Cr-Commit-Position: refs/heads/master@{#429802}

[modify] https://crrev.com/c1d8671b5708aa90dde46133d85d75f4c17aedbd/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f85750693cce8a4320b18552bdb51c0bcae90a67

commit f85750693cce8a4320b18552bdb51c0bcae90a67
Author: allada <allada@chromium.org>
Date: Fri Nov 04 07:16:55 2016

[Devtools] Fixed new timeline simplified bars popover hover

This patch fixes the new timeline canvas experiment to have a popover
for simplified bars.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2470273002
Cr-Commit-Position: refs/heads/master@{#429822}

[modify] https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/898d7400bebb7681d663255a7ffb60bcfcb57419

commit 898d7400bebb7681d663255a7ffb60bcfcb57419
Author: allada <allada@chromium.org>
Date: Fri Nov 04 22:58:26 2016

[Devtools] Added "wiskers" to new network timeline for colored mode

This patch adds "wiskers" for stalled/queued timeing bars in simplified
view mode.

See: http://imgur.com/a/bRXYL

R=dgozman,paulirish
BUG= 653738 

Review-Url: https://codereview.chromium.org/2474233002
Cr-Commit-Position: refs/heads/master@{#430052}

[modify] https://crrev.com/898d7400bebb7681d663255a7ffb60bcfcb57419/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/898d7400bebb7681d663255a7ffb60bcfcb57419/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 30 by bugdroid1@chromium.org, Nov 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7f8e7887cf4d32137d83dfd8d094309fd7c7ce

commit 2e7f8e7887cf4d32137d83dfd8d094309fd7c7ce
Author: allada <allada@chromium.org>
Date: Sat Nov 05 01:13:34 2016

[Devtools] Renamed network timeline to "Waterfall"

This patch renames the timeline in network panel to waterfall per
paulirish@.

R=dgozman,paulirish
BUG= 653738 

Review-Url: https://codereview.chromium.org/2476573003
Cr-Commit-Position: refs/heads/master@{#430112}

[modify] https://crrev.com/2e7f8e7887cf4d32137d83dfd8d094309fd7c7ce/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce36922953d67ded86eebf31837bfb2d002bb78d

commit ce36922953d67ded86eebf31837bfb2d002bb78d
Author: allada <allada@chromium.org>
Date: Mon Nov 07 20:23:13 2016

[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2460073002
Cr-Commit-Position: refs/heads/master@{#430358}

[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/BUILD.gn
[delete] https://crrev.com/78bd9c632ea526ced31aecc20b4e9c78f27f2b09/third_party/WebKit/Source/devtools/front_end/Images/graphLabelCalloutLeft.png
[delete] https://crrev.com/78bd9c632ea526ced31aecc20b4e9c78f27f2b09/third_party/WebKit/Source/devtools/front_end/Images/graphLabelCalloutRight.png
[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css
[modify] https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62980b89a07d6575426fb148822341c4ba07db2e

commit 62980b89a07d6575426fb148822341c4ba07db2e
Author: allada <allada@chromium.org>
Date: Tue Nov 08 19:49:17 2016

[Devtools] Added padding to hover area in network timeline

This patch allows for a minimum of 25px on each side of the bars
in network waterfall.

R=dgozman
BUG= 653738 

Review-Url: https://codereview.chromium.org/2486623002
Cr-Commit-Position: refs/heads/master@{#430688}

[modify] https://crrev.com/62980b89a07d6575426fb148822341c4ba07db2e/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0acfe47fa2b1c26f934d44f01fd0f671f339c865

commit 0acfe47fa2b1c26f934d44f01fd0f671f339c865
Author: allada <allada@chromium.org>
Date: Tue Nov 15 00:08:55 2016

[Devtools] Fixed waterfall area for scrollbars

Fixes some code left over from old timeline/waterfall in network where
it left space for scrollbars in the datagrid.

See: http://imgur.com/a/A4PDu

R=dgozman,lushnikov
BUG= 653738 

Review-Url: https://codereview.chromium.org/2497393002
Cr-Commit-Position: refs/heads/master@{#432003}

[modify] https://crrev.com/0acfe47fa2b1c26f934d44f01fd0f671f339c865/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css

Comment 35 by allada@chromium.org, Nov 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment