New issue
Advanced search Search tips

Issue 653730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Add Backing SQL store for previews blacklist

Project Member Reported by ryansturm@chromium.org, Oct 6 2016

Issue description

Add an implementation for the previews blacklist backing store.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae78ccf536394379900253a4099b5e089b07084

commit 2ae78ccf536394379900253a4099b5e089b07084
Author: ryansturm <ryansturm@chromium.org>
Date: Tue Oct 11 01:07:23 2016

Adding a SQL implementation of the backing store for previews opt outs

Previews maintains opt outs to determine eligibility of a navigation to
a domain. To persist this information, a SQLite database is created to
store opt out choice, host name, preview type, and time. This portion of
the implementation only implements creating the table, and returning an
empty result to PreviewBlackList (after running a real query).

BUG= 653730 

Review-Url: https://codereview.chromium.org/2390773003
Cr-Commit-Position: refs/heads/master@{#424319}

[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/chrome/common/chrome_constants.cc
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/chrome/common/chrome_constants.h
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/components/previews/core/BUILD.gn
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/components/previews/core/DEPS
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/components/previews/core/previews_black_list.cc
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/components/previews/core/previews_black_list.h
[add] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/components/previews/core/previews_opt_out_store_sql.cc
[add] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/components/previews/core/previews_opt_out_store_sql.h
[modify] https://crrev.com/2ae78ccf536394379900253a4099b5e089b07084/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd52f6bb42533bc43ea7095cba6aacf78c159572

commit fd52f6bb42533bc43ea7095cba6aacf78c159572
Author: ryansturm <ryansturm@chromium.org>
Date: Mon Oct 17 23:57:10 2016

Add remaining implementations to PreviewsOptOutStoreSQL

This adds an implementation for AddPreviewNavigation and ClearBlackList
to PreviewsOptOutStoreSQL.

AddPreviewNavigation adds a new row to the database with the passed in
fields. It then prunes the DB to at most 32 rows per host and 3200
rows total in the DB.

ClearBlackList removes all entries from the DB between two passed in
times.

BUG= 653730 

Review-Url: https://codereview.chromium.org/2410153008
Cr-Commit-Position: refs/heads/master@{#425821}

[modify] https://crrev.com/fd52f6bb42533bc43ea7095cba6aacf78c159572/components/previews/core/previews_opt_out_store_sql.cc

Status: Fixed (was: Started)

Sign in to add a comment