New issue
Advanced search Search tips

Issue 653717 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

with --secondary-ui-md, find bar corners are squared off

Project Member Reported by est...@chromium.org, Oct 6 2016

Issue description

see attachment
 
findbarback.png
6.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4629eb497b5d50a62a6757db82e9996cb69caf7

commit a4629eb497b5d50a62a6757db82e9996cb69caf7
Author: estade <estade@chromium.org>
Date: Mon Oct 10 18:19:25 2016

Fix corners of find bar view by using BubbleBackground instead of a
solid background.

This fixes the appearance in Harmony. It  has little visible effect
pre-Harmony because the roundedness of the border and where
it's drawn relative to the bg mean there's not much overlap
between border and background.

BUG= 653717 

Review-Url: https://codereview.chromium.org/2399033004
Cr-Commit-Position: refs/heads/master@{#424186}

[modify] https://crrev.com/a4629eb497b5d50a62a6757db82e9996cb69caf7/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/a4629eb497b5d50a62a6757db82e9996cb69caf7/chrome/browser/ui/views/find_bar_view.h

Comment 2 by est...@chromium.org, Oct 10 2016

Status: Fixed (was: Started)

Sign in to add a comment