New issue
Advanced search Search tips

Issue 653715 link

Starred by 2 users
Status: Verified
Owner:
dmazz...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility is spammy

Project Member Reported by thestig@chromium.org, Oct 6 2016 
Run browser_tests --gtest_filter=PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility

See ~1500 lines of output, mostly from render_accessibility_impl.cc:376.

Is that really needed? Can we be more terse?
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab6b47da9faa24b7e356d493ce21b940ba16fbca

commit ab6b47da9faa24b7e356d493ce21b940ba16fbca
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 17:38:55 2016

Replace VLOG(0) with VLOG(1) in accessibility code

VLOG(0) is the same as LOG(INFO) which is pretty spammy by
default, and DVLOG is only available in debug builds. Replace
with VLOG(1) for two cases of files where we don't want logging
by default but where it's useful to have the option to enable
logging for a release build.

BUG= 653715 

Review-Url: https://codereview.chromium.org/2444193003
Cr-Commit-Position: refs/heads/master@{#427399}

[modify] https://crrev.com/ab6b47da9faa24b7e356d493ce21b940ba16fbca/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/ab6b47da9faa24b7e356d493ce21b940ba16fbca/ui/chromeos/touch_exploration_controller.cc

Comment 2 by thestig@chromium.org, Oct 25 2016

Status: Fixed (was: Assigned)
Thanks!

Comment 3 by pbath...@chromium.org, Nov 8 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment