New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653708 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 646947



Sign in to add a comment

RequestCoordinator ending point

Project Member Reported by romax@chromium.org, Oct 6 2016 
RequestCoordinator would not invoke the scheduler_callback_ 
1. When OfflinerDoneCallback has a status of PRERENDERING_FAILED.
2. When OfflinerDoneCallback has a status of PRERENDERING_CANCELLED.

Both cases would not call the scheduler_callback_, or TryNextRequest()
However, 1 would call NotifyComplete with status RETRY_COUNT_EXCEEDED, 2 would call NotifyChanged.

For one of the test cases, I need to know when the RC stops processing requests so that I can call StartProcessing() manually to force RC process all the requests in one batch.

Comment 1 by romax@chromium.org, Oct 7 2016

Labels: -Pri-0 Pri-2
seems it's better to set a testing only callback using RC::SetProcessingCallbackForTest(). I'll try it out first to see if it would resolve the issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c1f5c1b9927576a524b1fe3476035f4d1128e79

commit 1c1f5c1b9927576a524b1fe3476035f4d1128e79
Author: romax <romax@chromium.org>
Date: Wed Oct 19 01:49:48 2016

[Offline Pages] Add evaluation test support in RequestCoodinator.

Added the function to add customized callback which would be called
after an user request is completed. Also fixed the issue where the
scheduler callback would not be invoked if there's a failure during the
offlining, also made it have the same behavior as described in comments.
Changed some tests regarding to the changes above.

BUG= 653708 , 646947 

Review-Url: https://chromiumcodereview.appspot.com/2425873003
Cr-Commit-Position: refs/heads/master@{#426115}

[modify] https://crrev.com/1c1f5c1b9927576a524b1fe3476035f4d1128e79/components/offline_pages/background/offliner_policy.h
[modify] https://crrev.com/1c1f5c1b9927576a524b1fe3476035f4d1128e79/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/1c1f5c1b9927576a524b1fe3476035f4d1128e79/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/1c1f5c1b9927576a524b1fe3476035f4d1128e79/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/1c1f5c1b9927576a524b1fe3476035f4d1128e79/components/offline_pages/background/request_picker_unittest.cc

Comment 3 by romax@chromium.org, Oct 19 2016

Owner: romax@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment