Feature description: Add a custom proto in UMA to lag Translate interactions. Eng owner:hamelphi@, rogerm@ Product owner: Design doc: go/translate-events
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01e12a12485f430701ec9c47974e71b3ecc99563 commit 01e12a12485f430701ec9c47974e71b3ecc99563 Author: hamelphi <hamelphi@chromium.org> Date: Fri Oct 07 21:27:02 2016 Add TranslateEventProto. BUG= 653700 , 634961 Review-Url: https://codereview.chromium.org/2394643002 Cr-Commit-Position: refs/heads/master@{#423969} [modify] https://crrev.com/01e12a12485f430701ec9c47974e71b3ecc99563/components/metrics/proto/BUILD.gn [modify] https://crrev.com/01e12a12485f430701ec9c47974e71b3ecc99563/components/metrics/proto/chrome_user_metrics_extension.proto [add] https://crrev.com/01e12a12485f430701ec9c47974e71b3ecc99563/components/metrics/proto/translate_event.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b257fe9351c22aaae756a8527442193ef412d6cf commit b257fe9351c22aaae756a8527442193ef412d6cf Author: hamelphi <hamelphi@chromium.org> Date: Wed Oct 12 22:07:53 2016 Send TranslateEventProtos to UMA Cache TranslateEvents and send them to UMA through the metrics provider. BUG= 653700 , 634961 Review-Url: https://codereview.chromium.org/2395253002 Cr-Commit-Position: refs/heads/master@{#424878} [modify] https://crrev.com/b257fe9351c22aaae756a8527442193ef412d6cf/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/b257fe9351c22aaae756a8527442193ef412d6cf/components/translate/core/browser/translate_ranker.cc [modify] https://crrev.com/b257fe9351c22aaae756a8527442193ef412d6cf/components/translate/core/browser/translate_ranker.h [modify] https://crrev.com/b257fe9351c22aaae756a8527442193ef412d6cf/components/translate/core/browser/translate_ranker_metrics_provider.cc [modify] https://crrev.com/b257fe9351c22aaae756a8527442193ef412d6cf/components/translate/core/browser/translate_ranker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce commit 2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce Author: rogerm <rogerm@chromium.org> Date: Wed Nov 16 07:17:05 2016 Integrate TranslateEventProto UMA logging into TranslateManager. This CL integrates the TranslateEventProto into the TranaslateManager in order to report these events via UMA. BUG= 634961 , 653700 Review-Url: https://codereview.chromium.org/2400503002 Cr-Commit-Position: refs/heads/master@{#432416} [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/translate/chrome_translate_client.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/translate/translate_manager_render_view_host_unittest.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/browser_commands.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/browser_window.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/cocoa/browser_window_cocoa.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/cocoa/browser_window_cocoa.mm [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/translate/translate_bubble_factory.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/translate/translate_bubble_factory.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/translate/translate_bubble_view_state_transition.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/test/base/test_browser_window.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/chrome/test/base/test_browser_window.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/components/metrics/proto/translate_event.proto [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/components/translate/core/browser/translate_manager.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/components/translate/core/browser/translate_ranker.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/components/translate/core/browser/translate_ranker.h [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/components/translate/core/browser/translate_ui_delegate.cc [modify] https://crrev.com/2847cf85bbbd9dcfc7f9bcc3b6add85d709155ce/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e98a60b54d634b3e9b34785de505f20fb576e36 commit 9e98a60b54d634b3e9b34785de505f20fb576e36 Author: hamelphi <hamelphi@chromium.org> Date: Mon Feb 13 19:50:30 2017 Add a country field to TranslateEventProto. This field will be useful to log explicitly the country that we get at inference time in the client, which may be different from the one we can infer from GWSLogs data on the server side. A discrepancy in data between inference and training can hurt the performance of translateRanker. See cl/146667100 for the Google3 side CL. BUG= 653700 Review-Url: https://codereview.chromium.org/2629173002 Cr-Commit-Position: refs/heads/master@{#450049} [modify] https://crrev.com/9e98a60b54d634b3e9b34785de505f20fb576e36/components/metrics/proto/translate_event.proto [modify] https://crrev.com/9e98a60b54d634b3e9b34785de505f20fb576e36/components/translate/core/browser/translate_manager.cc
Comment 1 by bugdroid1@chromium.org
, Oct 7 2016