New issue
Advanced search Search tips

Issue 653694 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in TIntermBinary::getRight

Project Member Reported by ClusterFuzz, Oct 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5434370024538112

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000088
Crash State:
  TIntermBinary::getRight
  TLoopIndexInfo::fillInfo
  TLoopStack::push
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=423381:423433

Minimized Testcase (0.39 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97RgS3ubSHea52vmmi5l78PptunTLjfhVc16ge3ppRPRpO81foJPU7cy9FApapzdApYlCBtqfGTrjK8pU7uSgAY3NgeRcCHaGV6Q0wJhIM9CMjkou-Kuwk2bIGBEenMEMmV-6rH9GxtSTvlvqVdBbFjok-gFA?testcase_id=5434370024538112

Issue manually filed by: mmohammad

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: zmo@chromium.org jmad...@chromium.org
Owner: cwallez@chromium.org
Status: Assigned (was: Untriaged)
cwallez @ could you please look into this.please feel free to re-assigned back if needed. thanks in advance !
Somehow I forgot to CQ the patch that fixes this. In the CQ now.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b2792db1c73f39e6016e7ee08594471a4f8f0a8a

commit b2792db1c73f39e6016e7ee08594471a4f8f0a8a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Oct 07 15:21:09 2016

translator: Reject invalid combination of compile flags

ADD_AND_TRUE_TO_LOOP_CONDITION breaks loop unrolling because LoopInfo
expects the loop condition to have been validated to be "symbol < constant"
and stayed that way.

BUG= chromium:653454 
BUG= chromium:653694 

Change-Id: I2057fde3a308623bd2dd7571ee878dd42b1fdac3
Reviewed-on: https://chromium-review.googlesource.com/395306
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/b2792db1c73f39e6016e7ee08594471a4f8f0a8a/src/compiler/translator/Compiler.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b2792db1c73f39e6016e7ee08594471a4f8f0a8a

commit b2792db1c73f39e6016e7ee08594471a4f8f0a8a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Oct 07 15:21:09 2016

translator: Reject invalid combination of compile flags

ADD_AND_TRUE_TO_LOOP_CONDITION breaks loop unrolling because LoopInfo
expects the loop condition to have been validated to be "symbol < constant"
and stayed that way.

BUG= chromium:653454 
BUG= chromium:653694 

Change-Id: I2057fde3a308623bd2dd7571ee878dd42b1fdac3
Reviewed-on: https://chromium-review.googlesource.com/395306
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/b2792db1c73f39e6016e7ee08594471a4f8f0a8a/src/compiler/translator/Compiler.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb4b0f4121967b4bb8a244d92d825d4a2b14a60

commit 3cb4b0f4121967b4bb8a244d92d825d4a2b14a60
Author: zmo <zmo@chromium.org>
Date: Sat Oct 22 04:11:33 2016

Roll ANGLE 336b147..f017315

https://chromium.googlesource.com/angle/angle.git/+log/336b147..f017315

BUG= chromium:657859 , chromium:653454 , chromium:653694 , chromium:656485 
TEST=bots
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2442143002
Cr-Commit-Position: refs/heads/master@{#426968}

[modify] https://crrev.com/3cb4b0f4121967b4bb8a244d92d825d4a2b14a60/DEPS
[modify] https://crrev.com/3cb4b0f4121967b4bb8a244d92d825d4a2b14a60/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 6 by ClusterFuzz, Oct 23 2016

ClusterFuzz has detected this issue as fixed in range 426965:426983.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5434370024538112

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000088
Crash State:
  TIntermBinary::getRight
  TLoopIndexInfo::fillInfo
  TLoopStack::push
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=423381:423433
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=426965:426983

Minimized Testcase (0.39 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97RgS3ubSHea52vmmi5l78PptunTLjfhVc16ge3ppRPRpO81foJPU7cy9FApapzdApYlCBtqfGTrjK8pU7uSgAY3NgeRcCHaGV6Q0wJhIM9CMjkou-Kuwk2bIGBEenMEMmV-6rH9GxtSTvlvqVdBbFjok-gFA?testcase_id=5434370024538112

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 23 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment