CloudPrint Job is getting stuck as "Creating a new print job" status. |
||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Steps to reproduce the problem: Steps to execute: 1.Visit the GCP Management Page "https://www.google.com/cloudprint". 2.Click on the Print button and select the "Upload a file to print" option. 3.Select any DOC file from the local file system which needs to be printed. 4.Select any Printer in GCP Print dialog & try to Print. What is the expected behavior? User should able to print the job successfully. What went wrong? Job is getting stuck in "Creating a new print job" status. Did this work before? Yes 53.0.2785.116 Chrome version: 54.0.2840.50 Channel: n/a OS Version: Flash Version: Shockwave Flash 23.0 r0
,
Oct 6 2016
+Anantha,Ligi - this is a potential blocker for M54 stable
,
Oct 6 2016
+thestig@,royans@
,
Oct 6 2016
,
Oct 6 2016
Tushari, can you get this bisected.
,
Oct 7 2016
Able to reproduce the issue on win10 chrome beta version 54.0.2840.50 and canary version 55.0.2882.4 - Job is getting stuck in "Creating a new print job" status. Please find the screenshot The issue can be seen on mac10.11.6 and Linux 14.04 OS as well This is a regression issue in M54 and below is the bisect info Manual Bisect Info: ------------------- Good Build:54.0.2839.0 Bad Build:54.0.2840.0 Bisect Tool Info: --------------- Possible suspect : https://chromium.googlesource.com/chromium/src/+log/e3195490a63d9545fb1bfe560aa21680ba0b5843..aaad992eef8e8c1e879f72afd9dabb05d3855e67 Please reassign if this is not related to your change
,
Oct 7 2016
> https://chromium.googlesource.com/chromium/src/+log/e3195490a63d9545fb1bfe560aa21680ba0b5843..aaad992eef8e8c1e879f72afd9dabb05d3855e67 If this is the culprit, this is a server-side bug of Cloud Print.
,
Oct 7 2016
,
Oct 7 2016
Lana/ Lei, can someone confirm whether the CL in #6 is the actual cause of the regression. FYI : M54 stable promotion release candidate cut is on Monday next week. We need this issue to be resolved ASAP.
,
Oct 7 2016
It was the change in my CL (https://codereview.chromium.org/2261393002/) that caused the problem. Our form submit behavior does match the spec now. I am not so sure if there was an edge case that I didn't catch or it is due to some implementation done in Google cloud print. That I will do further investigation. Revert the CL will fix the cloud print issue but the form submit behavior would not meet the spec. What would be good to do for now?
,
Oct 7 2016
lunalu: If you can reproduce the problem locally? Is it obvious to you what the Cloud Print webpage is doing wrong? And if so, is it easy to fix? If the answers are all "yes" then let's see if the CP server folks can just make those changes and then we don't have to do anything in Chrome.
,
Oct 7 2016
And alternatively, if we cannot make the server side fix in time, and we revert r414590, that would reopen bug 586749 . What's the impact there?
,
Oct 7 2016
The weird thing is cloud print works on Firefox. And with the change I made, Chrome form submit behavior now matches Firefox'. So I am suspecting that there are some edge cases I didn't catch.
,
Oct 7 2016
From the specs: "If form document is not connected, has no associated browsing context, or its active sandboxing flag set has its sandboxed forms browsing context flag set, then abort these steps without doing anything." https://html.spec.whatwg.org/multipage/forms.html#form-submission-algorithm Which is exactly what I did. I suspect it is still a Cloud Print bug. But it works on Firefox.
,
Oct 7 2016
Are we sure Firefox behaves exactly according to spec? Are we sure we match FF's behavior 100%? I suspect one of the answers to these questions is "no" ... otherwise how does it work in FF but not in Chrome?
,
Oct 10 2016
Issue 653804 has been merged into this issue.
,
Oct 10 2016
Can we have the latest update about this issue? IMPORTANT : We are planning a STABLE RC cut tomorrow(10/11), Tuesday at 4.00 PM PST. So please have the fix landed/verified in today's canary and merge to branch if all looks good before noon.We will not be taking any merges after noon !
,
Oct 10 2016
Per discussion we need this in by tonight so we can verify the issue in canary before cutting the RC. thestig@ can you do a revert of https://crrev.com/414590 on trunk and m54 (since today's a holiday in CA).
,
Oct 10 2016
Manual revert for trunk: https://codereview.chromium.org/2409863002
,
Oct 10 2016
Manual M54 revert: https://codereview.chromium.org/2405973003 Will need to do M55 as well, but let's see if the above lands safely.
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346142376c19b9744d684de17fff0382782b977e commit 346142376c19b9744d684de17fff0382782b977e Author: Lei Zhang <thestig@chromium.org> Date: Mon Oct 10 23:56:18 2016 M54: Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG= 586749 , 653692 Original code review: https://codereview.chromium.org/2261393002 Review URL: https://codereview.chromium.org/2405973003 . Cr-Commit-Position: refs/branch-heads/2840@{#712} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [delete] https://crrev.com/7d2681357ec66d5190519b2b824dea3dddd86ff2/third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/Source/core/html/HTMLFormElement.cpp [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/tools/metrics/histograms/histograms.xml
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/005750463baa9ec11ff139b5256f78eec8e6510f commit 005750463baa9ec11ff139b5256f78eec8e6510f Author: thestig <thestig@chromium.org> Date: Tue Oct 11 01:23:34 2016 Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG= 586749 , 653692 TBR=lunalu@chromium.org,tkent@chromium.org,jwd@chromium.org,iclelland@chromium.org Original code review: https://codereview.chromium.org/2261393002 Review-Url: https://codereview.chromium.org/2409863002 Cr-Commit-Position: refs/heads/master@{#424328} [delete] https://crrev.com/7e51c88420bc4520aaa4f4bc63fb5abe8c71567a/third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html [modify] https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html [modify] https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html [modify] https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f/third_party/WebKit/Source/core/html/HTMLFormElement.cpp [modify] https://crrev.com/005750463baa9ec11ff139b5256f78eec8e6510f/tools/metrics/histograms/histograms.xml
,
Oct 11 2016
Per comment #20, this also needs to be merged to M55. Please request a merge to M55 ASAP. Thank you.
,
Oct 11 2016
Yes, I intend to merge to M55, but can someone confirm this is fixed on Canary / M54?
,
Oct 11 2016
The revert missed yesterday's canary- 56.0.2887.0 (@424315) and latest M54- 54.0.2840.58 {#711} builds. We can verify this today night.
,
Oct 11 2016
Thanks. Let me know. lunalu: I think we will resolve this bug as "fixed" since we reverted. Of course, the issue actually still exists because you want to reland your reverted CL in the future. Do you want to fix this issue as part of bug 586749 , or do you want to open a new bug specially for this? Up to you.
,
Oct 12 2016
I read the client code of cloudprint, and my conclusion is that this is due to a combination of another WebKit-Blink-only bug and a bug of Closure Library (or Cloud print). r414590 itself had no problems. https://github.com/google/closure-library/blob/master/closure/goog/net/iframeio.js#L940 WebKit and Blink still have a problem described there ( Issue 71536 ), and Closure Library tries to submit the original form, which is not connected to any document. With Firefox, a cloned form is connected to the document in the iframe. This issue might affect other Google products using Closure Library and <input type=file>.
,
Oct 12 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome canary 56.0.2888.0 and beta 54.0.2840.59 with the steps mentioned in comment #0.Able to add print job successfully without any hang. Please find the attached screen cast for the same. Adding TE-Verified labels.
,
Oct 12 2016
,
Oct 12 2016
,
Oct 12 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94272796d09c2055db4d1ff48de2258fb9c608d0 commit 94272796d09c2055db4d1ff48de2258fb9c608d0 Author: Lei Zhang <thestig@chromium.org> Date: Wed Oct 12 18:40:03 2016 M55: Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG= 586749 , 653692 TBR=lunalu@chromium.org,tkent@chromium.org,jwd@chromium.org,iclelland@chromium.org Original code review: https://codereview.chromium.org/2261393002 Review-Url: https://codereview.chromium.org/2409863002 Cr-Commit-Position: refs/heads/master@{#424328} (cherry picked from commit 005750463baa9ec11ff139b5256f78eec8e6510f) Review URL: https://codereview.chromium.org/2416623003 . Cr-Commit-Position: refs/branch-heads/2883@{#68} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [delete] https://crrev.com/4da028c0d4dea59531117262422eef374288c400/third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/Source/core/html/HTMLFormElement.cpp [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/tools/metrics/histograms/histograms.xml
,
Oct 12 2016
Looks like there was nothing internal here - bug was restricted by auto-rule due to screenshot attachment from google.com. Opening up.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94272796d09c2055db4d1ff48de2258fb9c608d0 commit 94272796d09c2055db4d1ff48de2258fb9c608d0 Author: Lei Zhang <thestig@chromium.org> Date: Wed Oct 12 18:40:03 2016 M55: Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG= 586749 , 653692 TBR=lunalu@chromium.org,tkent@chromium.org,jwd@chromium.org,iclelland@chromium.org Original code review: https://codereview.chromium.org/2261393002 Review-Url: https://codereview.chromium.org/2409863002 Cr-Commit-Position: refs/heads/master@{#424328} (cherry picked from commit 005750463baa9ec11ff139b5256f78eec8e6510f) Review URL: https://codereview.chromium.org/2416623003 . Cr-Commit-Position: refs/branch-heads/2883@{#68} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [delete] https://crrev.com/4da028c0d4dea59531117262422eef374288c400/third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/third_party/WebKit/Source/core/html/HTMLFormElement.cpp [modify] https://crrev.com/94272796d09c2055db4d1ff48de2258fb9c608d0/tools/metrics/histograms/histograms.xml
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/346142376c19b9744d684de17fff0382782b977e commit 346142376c19b9744d684de17fff0382782b977e Author: Lei Zhang <thestig@chromium.org> Date: Mon Oct 10 23:56:18 2016 M54: Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG= 586749 , 653692 Original code review: https://codereview.chromium.org/2261393002 Review URL: https://codereview.chromium.org/2405973003 . Cr-Commit-Position: refs/branch-heads/2840@{#712} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [delete] https://crrev.com/7d2681357ec66d5190519b2b824dea3dddd86ff2/third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/third_party/WebKit/Source/core/html/HTMLFormElement.cpp [modify] https://crrev.com/346142376c19b9744d684de17fff0382782b977e/tools/metrics/histograms/histograms.xml
,
Jul 18 2017
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by bustamante@google.com
, Oct 6 2016