MD Settings: CrOS, Migrate from paper-dropdown-menu-light to native select. |
|||||||||
Issue descriptionChromeOS UI still uses paper-dropdown-menu at device_page/display.html printing_page/cups_add_printer_dialog.html internet_page/network_nameservers.html internet_page/network_apnlist.html internet_page/network_proxy.html internet_page/network_apnlist.js Since I am focusing on release blockers for the Desktop part of Settings, I will be working on action menus next [1], so filing this separately so that we don't lose track. For example migrations see CLs attached to the original bug [2]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=639718 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=651513
,
Oct 12 2016
,
Oct 14 2016
,
Oct 17 2016
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15 commit b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15 Author: stevenjb <stevenjb@chromium.org> Date: Tue Oct 18 01:59:40 2016 Use md-select instead of paper-dropdown-menu-light in internet page BUG= 653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2422423002 Cr-Commit-Position: refs/heads/master@{#425853} [modify] https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15/chrome/browser/resources/settings/internet_page/network_apnlist.html [modify] https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15/chrome/browser/resources/settings/internet_page/network_apnlist.js [modify] https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15/chrome/browser/resources/settings/internet_page/network_nameservers.html [modify] https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15/chrome/browser/resources/settings/internet_page/network_nameservers.js [modify] https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/b0e7fb52816a7b5efc7c1ca92a99cb3e5a6d1e15/chrome/browser/resources/settings/internet_page/network_proxy.js
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f65e96ed2c7b20476644e157fb8b6b97f86888f commit 5f65e96ed2c7b20476644e157fb8b6b97f86888f Author: stevenjb <stevenjb@chromium.org> Date: Thu Oct 20 18:49:44 2016 Use md-select instead of paper-dropdown-menu-light in display.html BUG= 653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2427833002 Cr-Commit-Position: refs/heads/master@{#426544} [modify] https://crrev.com/5f65e96ed2c7b20476644e157fb8b6b97f86888f/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/5f65e96ed2c7b20476644e157fb8b6b97f86888f/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/5f65e96ed2c7b20476644e157fb8b6b97f86888f/chrome/test/data/webui/settings/device_page_tests.js
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f65e96ed2c7b20476644e157fb8b6b97f86888f commit 5f65e96ed2c7b20476644e157fb8b6b97f86888f Author: stevenjb <stevenjb@chromium.org> Date: Thu Oct 20 18:49:44 2016 Use md-select instead of paper-dropdown-menu-light in display.html BUG= 653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2427833002 Cr-Commit-Position: refs/heads/master@{#426544} [modify] https://crrev.com/5f65e96ed2c7b20476644e157fb8b6b97f86888f/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/5f65e96ed2c7b20476644e157fb8b6b97f86888f/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/5f65e96ed2c7b20476644e157fb8b6b97f86888f/chrome/test/data/webui/settings/device_page_tests.js
,
Nov 4 2016
@steven: I believe there are no more paper-dropdown-menu-light instances in the MD Settings codebase. Still seeing a few, now obsolete, CSS rules at printing_page/cups_add_printer_dialog.html settings_shared_css.html Shall you have the honor of removing them?
,
Nov 4 2016
I'm fine either way, but I won't be able to get to this until Wednesday at the earliest.
,
Nov 15 2016
,
Nov 22 2016
,
Nov 22 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32ca522f776a4656163f9ff62c30c7d57d190364 commit 32ca522f776a4656163f9ff62c30c7d57d190364 Author: stevenjb <stevenjb@chromium.org> Date: Thu Dec 15 22:16:21 2016 MD Settings: Eliminate remaining references to paper-dropdown-menu-light BUG= 653689 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578813002 Cr-Commit-Position: refs/heads/master@{#438934} [modify] https://crrev.com/32ca522f776a4656163f9ff62c30c7d57d190364/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/32ca522f776a4656163f9ff62c30c7d57d190364/ui/webui/resources/polymer_resources.grdp
,
Dec 16 2016
,
Mar 16 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by michae...@chromium.org
, Oct 10 2016