New issue
Advanced search Search tips

Issue 653673 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Cancelling IT2Me connection on client side produces blank dialog box

Project Member Reported by ajnolley@chromium.org, Oct 6 2016

Issue description

Version: Windows Host 55.0.2867.0 or later; 


What steps will reproduce the problem?
(1)On Host side, click Share under Remote Asstance
(2)On Client side enter the 9 digit code and click OK
(3)Wait a moment for host to acknowledge code and present dialog, then on Client side, click Cancel

connection is cancelled and Client throws up a blank dialog. Screenshot attached

 
Screenshot from 2016-10-06 13:45:48.png
400 KB View Download
my apologies for not reporting this before. I noticed it, but figured it was part of  bug 652490 

Comment 2 by joedow@chromium.org, Oct 10 2016

I believe this is a pre-existing problem but before the dialog changes the window to hit this problem was much smaller.  I'll let triage determine if the webapp should be updated to handle this scenario.
Labels: M-55
Status: jamie (was: Untriaged)
Owner: jamiewa...@chromium.org
Status: Assigned (was: jamie)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0902d247940269d89f20a6c8d6585e882cf4c2e

commit f0902d247940269d89f20a6c8d6585e882cf4c2e
Author: jamiewalch <jamiewalch@chromium.org>
Date: Wed Oct 12 01:15:19 2016

Don't show an error message if there isn't one.

BUG= 653673 

Review-Url: https://codereview.chromium.org/2414453004
Cr-Commit-Position: refs/heads/master@{#424628}

[modify] https://crrev.com/f0902d247940269d89f20a6c8d6585e882cf4c2e/remoting/webapp/crd/js/it2me_activity.js

Labels: Merge-Request-55
This change only affects the Chrome Remote Desktop app; there is no change to Chrome browser.

Comment 7 by dimu@chromium.org, Oct 13 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1150a6c5dc0327098ed9eeb7e1f69f1bf12ae4e

commit c1150a6c5dc0327098ed9eeb7e1f69f1bf12ae4e
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Thu Oct 13 18:14:35 2016

Don't show an error message if there isn't one.

BUG= 653673 

Review-Url: https://codereview.chromium.org/2414453004
Cr-Commit-Position: refs/heads/master@{#424628}
(cherry picked from commit f0902d247940269d89f20a6c8d6585e882cf4c2e)

Review URL: https://codereview.chromium.org/2414093002 .

Cr-Commit-Position: refs/branch-heads/2883@{#90}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c1150a6c5dc0327098ed9eeb7e1f69f1bf12ae4e/remoting/webapp/crd/js/it2me_activity.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
erified Fixed in QA release 55.0.2883.17. No dialog box pops up on cancel.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1150a6c5dc0327098ed9eeb7e1f69f1bf12ae4e

commit c1150a6c5dc0327098ed9eeb7e1f69f1bf12ae4e
Author: Jamie Walch <jamiewalch@chromium.org>
Date: Thu Oct 13 18:14:35 2016

Don't show an error message if there isn't one.

BUG= 653673 

Review-Url: https://codereview.chromium.org/2414453004
Cr-Commit-Position: refs/heads/master@{#424628}
(cherry picked from commit f0902d247940269d89f20a6c8d6585e882cf4c2e)

Review URL: https://codereview.chromium.org/2414093002 .

Cr-Commit-Position: refs/branch-heads/2883@{#90}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/c1150a6c5dc0327098ed9eeb7e1f69f1bf12ae4e/remoting/webapp/crd/js/it2me_activity.js

Comment 12 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment