New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename rasterize_and_record_micro.top_25_smooth and key_mobile_sites_smooth

Project Member Reported by benjhayden@chromium.org, Oct 6 2016

Issue description

These benchmarks no longer use the Smooth pagesets.
They shouldn't use the Smooth pagesets since the scrolling parts of those pagesets cause noise in these metrics.

 
Cc: sullivan@chromium.org
THanks for taking this, Ben! After you land your CL, can you reassign to Annie so she can triage the naming update on the dashboard?
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeb7021c7962a466e254557f9164b742ac174c19

commit eeb7021c7962a466e254557f9164b742ac174c19
Author: benjhayden <benjhayden@chromium.org>
Date: Fri Oct 07 19:33:51 2016

Make rasterize_and_record_micro.key_mobile_sites_smooth actually use KeyMobileSites*Smooth*PageSet.

This benchmark currently uses KeyMobileSitesPageSet despite the name.

This change will cause data stoppage alerts for
rasterize_and_record_micro.key_mobile_sites_smooth and
rasterize_and_record_micro.top_25_smooth

The new benchmarks will need monitoring updated.

BUG= 653670 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2388423002
Cr-Commit-Position: refs/heads/master@{#423931}

[modify] https://crrev.com/eeb7021c7962a466e254557f9164b742ac174c19/tools/perf/benchmarks/rasterize_and_record_micro.py

Owner: sullivan@chromium.org
Annie, can you triage the naming update on the dashboard?
Status: Assigned (was: Started)
Cc: chrishtr@chromium.org vmp...@chromium.org
Hi, checking on this, how much work is involved in this to get the newly named rasterize_and_record_micro.top_25 to be monitored by perf sheriffs? As of Oct 7 I think all metrics are now gathered under the new name:

https://chromeperf.appspot.com/report?sid=79e865873432b0d4fcdfc9a65d61e4c48f4e6d87177226c5eede8985bc4374ab&start_rev=423948&end_rev=429542

and without that being monitored we are flying blind, I had forgotten about the need for this update. For example it looks like there was a raster regression at:

Point ID: 429824
Time added: 2016-11-04T10:08:46.000Z

+Annie for wkorman's monitoring request in #5
Status: Fixed (was: Assigned)
Apologies for the delay. Monitoring is updated.

Sign in to add a comment